You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Lyuben Todorov (JIRA)" <ji...@apache.org> on 2013/12/04 15:40:39 UTC
[jira] [Comment Edited] (CASSANDRA-5351) Avoid repairing
already-repaired data by default
[ https://issues.apache.org/jira/browse/CASSANDRA-5351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838926#comment-13838926 ]
Lyuben Todorov edited comment on CASSANDRA-5351 at 12/4/13 2:40 PM:
--------------------------------------------------------------------
Added checks to LeveledManifest#replace and LeveledManifest#add to ensure un-repaired data is kept at L0 ([patch here|https://github.com/lyubent/cassandra/commit/70f63e577f531f904997934c53022c1d6a94b9f3]) The out-of-order key error is still a problem, logs show same error as above comment. One thing that I haven't accounted for so far is, tables being added straight to levels higher than L0, is it possible for newly flushed data to go straight to a level > L0
was (Author: lyubent):
Added checks to LeveledManifest#replace and LeveledManifest#add to ensure un-repaired data is kept at L0 ([patch here|https://github.com/lyubent/cassandra/commit/70f63e577f531f904997934c53022c1d6a94b9f3]) The out-of-order key error is still a problem, logs show same error as above comment.
> Avoid repairing already-repaired data by default
> ------------------------------------------------
>
> Key: CASSANDRA-5351
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5351
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Lyuben Todorov
> Labels: repair
> Fix For: 2.1
>
>
> Repair has always built its merkle tree from all the data in a columnfamily, which is guaranteed to work but is inefficient.
> We can improve this by remembering which sstables have already been successfully repaired, and only repairing sstables new since the last repair. (This automatically makes CASSANDRA-3362 much less of a problem too.)
> The tricky part is, compaction will (if not taught otherwise) mix repaired data together with non-repaired. So we should segregate unrepaired sstables from the repaired ones.
--
This message was sent by Atlassian JIRA
(v6.1#6144)