You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org> on 2024/08/06 03:54:30 UTC
[PR] Fix IoTConsensus log explosion when stoping one node [iotdb]
OneSizeFitsQuorum opened a new pull request, #13101:
URL: https://github.com/apache/iotdb/pull/13101
<img width="1011" alt="image" src="https://github.com/user-attachments/assets/c61d718d-5b23-41fb-bce0-b395faa36463">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix IoTConsensus log explosion when stoping one node [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13101:
URL: https://github.com/apache/iotdb/pull/13101#issuecomment-2270336337
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13101) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=13101&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=13101&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=13101&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13101&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13101&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13101)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix IoTConsensus log explosion when stoping one node [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13101:
URL: https://github.com/apache/iotdb/pull/13101#issuecomment-2270371244
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/13101?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
> Project coverage is 41.73%. Comparing base [(`0835630`)](https://app.codecov.io/gh/apache/iotdb/commit/08356308a862cc45301852d4b92143928ad13a0c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c6789c9`)](https://app.codecov.io/gh/apache/iotdb/commit/c6789c9b3ce653731fc5cabc642112c15ae0ec3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files](https://app.codecov.io/gh/apache/iotdb/pull/13101?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/iotdb/consensus/iot/IoTConsensusServerImpl.java](https://app.codecov.io/gh/apache/iotdb/pull/13101?src=pr&el=tree&filepath=iotdb-core%2Fconsensus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconsensus%2Fiot%2FIoTConsensusServerImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25zZW5zdXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbnNlbnN1cy9pb3QvSW9UQ29uc2Vuc3VzU2VydmVySW1wbC5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #13101 +/- ##
============================================
- Coverage 41.73% 41.73% -0.01%
Complexity 71 71
============================================
Files 3331 3331
Lines 211546 211547 +1
Branches 25150 25150
============================================
- Hits 88292 88285 -7
- Misses 123254 123262 +8
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/13101?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix IoTConsensus log explosion when stoping one node [iotdb]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum merged PR #13101:
URL: https://github.com/apache/iotdb/pull/13101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org