You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/03 06:37:57 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29331: [SPARK-32517][CORE] Add StorageLevel.DISK_ONLY_3

HyukjinKwon commented on a change in pull request #29331:
URL: https://github.com/apache/spark/pull/29331#discussion_r464220055



##########
File path: core/src/main/scala/org/apache/spark/storage/StorageLevel.scala
##########
@@ -172,6 +173,7 @@ object StorageLevel {
     case "NONE" => NONE
     case "DISK_ONLY" => DISK_ONLY
     case "DISK_ONLY_2" => DISK_ONLY_2
+    case "DISK_ONLY_3" => DISK_ONLY_3

Review comment:
       Maybe we should fix Java, Python and R sides and the documentation together given that the changes are not so big. I checked it in https://github.com/apache/spark/search?q=DISK_ONLY_2&unscoped_q=DISK_ONLY_2.
   BTW, is it worth adding this? It was already possible before via using user-defined `StorageLevel`, and adding this seems making this list inconsistent.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org