You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2018/09/25 19:27:24 UTC
[GitHub] qpid-dispatch pull request #383: DISPATCH-1129 - Moved call to forwarding mu...
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/383
DISPATCH-1129 - Moved call to forwarding multicast messages to end of…
… forwarder function. Also modified qd_message_check_LH to not validate the message if bufferes have already been freed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1129-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/383.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #383
----
commit 67a210c93d9097999158b06c5b61a8726a2bdd0d
Author: Ganesh Murthy <gm...@...>
Date: 2018-09-24T17:06:47Z
DISPATCH-1129 - Moved call to forwarding multicast messages to end of forwarder function. Also modified qd_message_check_LH to not validate the message if bufferes have already been freed
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #383: DISPATCH-1129 - Moved call to forwarding mu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/383
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #383: DISPATCH-1129 - Moved call to forwarding multicast...
Posted by ChugR <gi...@git.apache.org>.
Github user ChugR commented on the issue:
https://github.com/apache/qpid-dispatch/pull/383
+1 Ship It
Looks good and works. Failing tests could never get beyond a few hundred messages. With this patch I'm past 100 million messages.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #383: DISPATCH-1129 - Moved call to forwarding multicast...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/383
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr&el=h1) Report
> Merging [#383](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/15c46db55bed4d5d7e88bd24fd1ccf255453e629?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `96.96%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
+ Coverage 84.75% 84.77% +0.02%
==========================================
Files 73 73
Lines 16437 16463 +26
==========================================
+ Hits 13931 13957 +26
Misses 2506 2506
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/383/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.9% <100%> (+0.24%)` | :arrow_up: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/383/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.75% <100%> (+0.13%)` | :arrow_up: |
| [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/383/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `88.1% <90%> (+0.1%)` | :arrow_up: |
| [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/383/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.21% <0%> (-0.58%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr&el=footer). Last update [15c46db...67a210c](https://codecov.io/gh/apache/qpid-dispatch/pull/383?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org