You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Vladimir Ivanov (JIRA)" <ji...@apache.org> on 2006/08/08 13:18:13 UTC
[jira] Created: (HARMONY-1103) [classlib][io] compatibility:
different checks order for DataInputStream(null).readFully(byte[], int,
int)
[classlib][io] compatibility: different checks order for DataInputStream(null).readFully(byte[], int, int)
-----------------------------------------------------------------------------------------------------------
Key: HARMONY-1103
URL: http://issues.apache.org/jira/browse/HARMONY-1103
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Vladimir Ivanov
The harmony method java.io.DataInputStream(null).readFully(byte[], int, int) initially checks boundary values while RI checks stream.
It leads to different exceptions: NPE for RI and IndexOutOfBoundsException for Harmony.
================= test.java =======================
import java.io.DataInputStream;
public class test {
public static void main(String args[]) throws Exception {
new DataInputStream(null).readFully(new byte[] {2, 2, 2, 2}, 1, 18);
}
}
===============================================
Output:
C:\tmp\tmp17>C:\jrockit-jdk1.5.0-windows-ia32\bin\java.exe -cp . -showversion test
java version "1.5.0"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
BEA WebLogic JRockit(R) (build dra-38972-20041208-2001-win-ia32, R25.0.0-75, GC: System optimized over throughput (initial strategy singleparpar))
java.lang.NullPointerException
at java.io.DataInputStream.readFully(DataInputStream.java:176)
at test.main(test.java:5)
C:\tmp\tmp17>C:\harmony\trunk_0427\deploy\jdk\jre\bin\java.exe -cp . -showversion test
java version 1.5 (subset)
(c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
Exception in thread "main" java.lang.IndexOutOfBoundsException
at java.io.DataInputStream.readFully(DataInputStream.java:205)
at test.main(test.java:5)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1103) [classlib][io] compatibility:
different checks order for DataInputStream(null).readFully(byte[], int,
int)
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1103?page=all ]
Paulex Yang resolved HARMONY-1103.
----------------------------------
Resolution: Fixed
Tony, patch applied at revision r447286, thanks a lot for this enhancement.
Vladimir, please verify that the problem is fully fixed as you expected.
> [classlib][io] compatibility: different checks order for DataInputStream(null).readFully(byte[], int, int)
> ----------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1103
> URL: http://issues.apache.org/jira/browse/HARMONY-1103
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vladimir Ivanov
> Assigned To: Paulex Yang
> Attachments: DataInputStream.patch, harmony-1103.diff
>
>
> The harmony method java.io.DataInputStream(null).readFully(byte[], int, int) initially checks boundary values while RI checks stream.
> It leads to different exceptions: NPE for RI and IndexOutOfBoundsException for Harmony.
> ================= test.java =======================
> import java.io.DataInputStream;
> public class test {
> public static void main(String args[]) throws Exception {
> new DataInputStream(null).readFully(new byte[] {2, 2, 2, 2}, 1, 18);
> }
> }
> ===============================================
> Output:
> C:\tmp\tmp17>C:\jrockit-jdk1.5.0-windows-ia32\bin\java.exe -cp . -showversion test
> java version "1.5.0"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
> BEA WebLogic JRockit(R) (build dra-38972-20041208-2001-win-ia32, R25.0.0-75, GC: System optimized over throughput (initial strategy singleparpar))
> java.lang.NullPointerException
> at java.io.DataInputStream.readFully(DataInputStream.java:176)
> at test.main(test.java:5)
> C:\tmp\tmp17>C:\harmony\trunk_0427\deploy\jdk\jre\bin\java.exe -cp . -showversion test
> java version 1.5 (subset)
> (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> Exception in thread "main" java.lang.IndexOutOfBoundsException
> at java.io.DataInputStream.readFully(DataInputStream.java:205)
> at test.main(test.java:5)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1103) [classlib][io] compatibility:
different checks order for DataInputStream(null).readFully(byte[], int,
int)
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1103?page=all ]
Paulex Yang closed HARMONY-1103.
--------------------------------
Verified by Vladimir.
> [classlib][io] compatibility: different checks order for DataInputStream(null).readFully(byte[], int, int)
> ----------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1103
> URL: http://issues.apache.org/jira/browse/HARMONY-1103
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vladimir Ivanov
> Assigned To: Paulex Yang
> Attachments: DataInputStream.patch, harmony-1103.diff
>
>
> The harmony method java.io.DataInputStream(null).readFully(byte[], int, int) initially checks boundary values while RI checks stream.
> It leads to different exceptions: NPE for RI and IndexOutOfBoundsException for Harmony.
> ================= test.java =======================
> import java.io.DataInputStream;
> public class test {
> public static void main(String args[]) throws Exception {
> new DataInputStream(null).readFully(new byte[] {2, 2, 2, 2}, 1, 18);
> }
> }
> ===============================================
> Output:
> C:\tmp\tmp17>C:\jrockit-jdk1.5.0-windows-ia32\bin\java.exe -cp . -showversion test
> java version "1.5.0"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
> BEA WebLogic JRockit(R) (build dra-38972-20041208-2001-win-ia32, R25.0.0-75, GC: System optimized over throughput (initial strategy singleparpar))
> java.lang.NullPointerException
> at java.io.DataInputStream.readFully(DataInputStream.java:176)
> at test.main(test.java:5)
> C:\tmp\tmp17>C:\harmony\trunk_0427\deploy\jdk\jre\bin\java.exe -cp . -showversion test
> java version 1.5 (subset)
> (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> Exception in thread "main" java.lang.IndexOutOfBoundsException
> at java.io.DataInputStream.readFully(DataInputStream.java:205)
> at test.main(test.java:5)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1103) [classlib][io] compatibility:
different checks order for DataInputStream(null).readFully(byte[], int,
int)
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1103?page=all ]
Paulex Yang reassigned HARMONY-1103:
------------------------------------
Assignee: Paulex Yang
> [classlib][io] compatibility: different checks order for DataInputStream(null).readFully(byte[], int, int)
> ----------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1103
> URL: http://issues.apache.org/jira/browse/HARMONY-1103
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vladimir Ivanov
> Assigned To: Paulex Yang
> Attachments: DataInputStream.patch, harmony-1103.diff
>
>
> The harmony method java.io.DataInputStream(null).readFully(byte[], int, int) initially checks boundary values while RI checks stream.
> It leads to different exceptions: NPE for RI and IndexOutOfBoundsException for Harmony.
> ================= test.java =======================
> import java.io.DataInputStream;
> public class test {
> public static void main(String args[]) throws Exception {
> new DataInputStream(null).readFully(new byte[] {2, 2, 2, 2}, 1, 18);
> }
> }
> ===============================================
> Output:
> C:\tmp\tmp17>C:\jrockit-jdk1.5.0-windows-ia32\bin\java.exe -cp . -showversion test
> java version "1.5.0"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
> BEA WebLogic JRockit(R) (build dra-38972-20041208-2001-win-ia32, R25.0.0-75, GC: System optimized over throughput (initial strategy singleparpar))
> java.lang.NullPointerException
> at java.io.DataInputStream.readFully(DataInputStream.java:176)
> at test.main(test.java:5)
> C:\tmp\tmp17>C:\harmony\trunk_0427\deploy\jdk\jre\bin\java.exe -cp . -showversion test
> java version 1.5 (subset)
> (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> Exception in thread "main" java.lang.IndexOutOfBoundsException
> at java.io.DataInputStream.readFully(DataInputStream.java:205)
> at test.main(test.java:5)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1103) [classlib][io] compatibility:
different checks order for DataInputStream(null).readFully(byte[], int,
int)
Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1103?page=all ]
Tony Wu updated HARMONY-1103:
-----------------------------
Attachment: harmony-1103.diff
Because this patch is out of date, I rewrite one and add more testcases.
Would you please try my patch?
> [classlib][io] compatibility: different checks order for DataInputStream(null).readFully(byte[], int, int)
> ----------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1103
> URL: http://issues.apache.org/jira/browse/HARMONY-1103
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vladimir Ivanov
> Attachments: DataInputStream.patch, harmony-1103.diff
>
>
> The harmony method java.io.DataInputStream(null).readFully(byte[], int, int) initially checks boundary values while RI checks stream.
> It leads to different exceptions: NPE for RI and IndexOutOfBoundsException for Harmony.
> ================= test.java =======================
> import java.io.DataInputStream;
> public class test {
> public static void main(String args[]) throws Exception {
> new DataInputStream(null).readFully(new byte[] {2, 2, 2, 2}, 1, 18);
> }
> }
> ===============================================
> Output:
> C:\tmp\tmp17>C:\jrockit-jdk1.5.0-windows-ia32\bin\java.exe -cp . -showversion test
> java version "1.5.0"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
> BEA WebLogic JRockit(R) (build dra-38972-20041208-2001-win-ia32, R25.0.0-75, GC: System optimized over throughput (initial strategy singleparpar))
> java.lang.NullPointerException
> at java.io.DataInputStream.readFully(DataInputStream.java:176)
> at test.main(test.java:5)
> C:\tmp\tmp17>C:\harmony\trunk_0427\deploy\jdk\jre\bin\java.exe -cp . -showversion test
> java version 1.5 (subset)
> (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> Exception in thread "main" java.lang.IndexOutOfBoundsException
> at java.io.DataInputStream.readFully(DataInputStream.java:205)
> at test.main(test.java:5)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1103) [classlib][io] compatibility:
different checks order for DataInputStream(null).readFully(byte[], int,
int)
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1103?page=all ]
Vladimir Ivanov updated HARMONY-1103:
-------------------------------------
Attachment: DataInputStream.patch
unit test + patch
> [classlib][io] compatibility: different checks order for DataInputStream(null).readFully(byte[], int, int)
> ----------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1103
> URL: http://issues.apache.org/jira/browse/HARMONY-1103
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vladimir Ivanov
> Attachments: DataInputStream.patch
>
>
> The harmony method java.io.DataInputStream(null).readFully(byte[], int, int) initially checks boundary values while RI checks stream.
> It leads to different exceptions: NPE for RI and IndexOutOfBoundsException for Harmony.
> ================= test.java =======================
> import java.io.DataInputStream;
> public class test {
> public static void main(String args[]) throws Exception {
> new DataInputStream(null).readFully(new byte[] {2, 2, 2, 2}, 1, 18);
> }
> }
> ===============================================
> Output:
> C:\tmp\tmp17>C:\jrockit-jdk1.5.0-windows-ia32\bin\java.exe -cp . -showversion test
> java version "1.5.0"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
> BEA WebLogic JRockit(R) (build dra-38972-20041208-2001-win-ia32, R25.0.0-75, GC: System optimized over throughput (initial strategy singleparpar))
> java.lang.NullPointerException
> at java.io.DataInputStream.readFully(DataInputStream.java:176)
> at test.main(test.java:5)
> C:\tmp\tmp17>C:\harmony\trunk_0427\deploy\jdk\jre\bin\java.exe -cp . -showversion test
> java version 1.5 (subset)
> (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> Exception in thread "main" java.lang.IndexOutOfBoundsException
> at java.io.DataInputStream.readFully(DataInputStream.java:205)
> at test.main(test.java:5)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1103) [classlib][io] compatibility:
different checks order for DataInputStream(null).readFully(byte[], int,
int)
Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1103?page=comments#action_12435410 ]
Vladimir Ivanov commented on HARMONY-1103:
------------------------------------------
verified, thanks
> [classlib][io] compatibility: different checks order for DataInputStream(null).readFully(byte[], int, int)
> ----------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1103
> URL: http://issues.apache.org/jira/browse/HARMONY-1103
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Vladimir Ivanov
> Assigned To: Paulex Yang
> Attachments: DataInputStream.patch, harmony-1103.diff
>
>
> The harmony method java.io.DataInputStream(null).readFully(byte[], int, int) initially checks boundary values while RI checks stream.
> It leads to different exceptions: NPE for RI and IndexOutOfBoundsException for Harmony.
> ================= test.java =======================
> import java.io.DataInputStream;
> public class test {
> public static void main(String args[]) throws Exception {
> new DataInputStream(null).readFully(new byte[] {2, 2, 2, 2}, 1, 18);
> }
> }
> ===============================================
> Output:
> C:\tmp\tmp17>C:\jrockit-jdk1.5.0-windows-ia32\bin\java.exe -cp . -showversion test
> java version "1.5.0"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
> BEA WebLogic JRockit(R) (build dra-38972-20041208-2001-win-ia32, R25.0.0-75, GC: System optimized over throughput (initial strategy singleparpar))
> java.lang.NullPointerException
> at java.io.DataInputStream.readFully(DataInputStream.java:176)
> at test.main(test.java:5)
> C:\tmp\tmp17>C:\harmony\trunk_0427\deploy\jdk\jre\bin\java.exe -cp . -showversion test
> java version 1.5 (subset)
> (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> Exception in thread "main" java.lang.IndexOutOfBoundsException
> at java.io.DataInputStream.readFully(DataInputStream.java:205)
> at test.main(test.java:5)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira