You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2019/05/06 10:35:14 UTC
[kudu-CR] [www] Show column count on table page
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13243
Change subject: [www] Show column count on table page
......................................................................
[www] Show column count on table page
Table column count is not obvious displayed when it has been altered
several times, there maybe some holes in column IDs. This patch show
the current column count of table.
Change-Id: I8c6d471b6ce4f226b58a29e43f3a0c1c916669b2
---
M src/kudu/master/master_path_handlers.cc
M www/table.mustache
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/13243/1
--
To view, visit http://gerrit.cloudera.org:8080/13243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c6d471b6ce4f226b58a29e43f3a0c1c916669b2
Gerrit-Change-Number: 13243
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
[kudu-CR] [www] Show column count on table page
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13243 )
Change subject: [www] Show column count on table page
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13243/1/src/kudu/master/master_path_handlers.cc
File src/kudu/master/master_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/13243/1/src/kudu/master/master_path_handlers.cc@331
PS1, Line 331: columns_count
> column_count
Done
http://gerrit.cloudera.org:8080/#/c/13243/1/www/table.mustache
File www/table.mustache:
http://gerrit.cloudera.org:8080/#/c/13243/1/www/table.mustache@34
PS1, Line 34: Columns Count
> Column count
Done
http://gerrit.cloudera.org:8080/#/c/13243/1/www/table.mustache@34
PS1, Line 34: columns_count
> column_count
Done
--
To view, visit http://gerrit.cloudera.org:8080/13243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6d471b6ce4f226b58a29e43f3a0c1c916669b2
Gerrit-Change-Number: 13243
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 07 May 2019 02:05:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [www] Show column count on table page
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13243 )
Change subject: [www] Show column count on table page
......................................................................
[www] Show column count on table page
Table column count is not obvious displayed when it has been altered
several times, there maybe some holes in column IDs. This patch show
the current column count of table.
Change-Id: I8c6d471b6ce4f226b58a29e43f3a0c1c916669b2
Reviewed-on: http://gerrit.cloudera.org:8080/13243
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
---
M src/kudu/master/master_path_handlers.cc
M www/table.mustache
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c6d471b6ce4f226b58a29e43f3a0c1c916669b2
Gerrit-Change-Number: 13243
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] [www] Show column count on table page
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13243 )
Change subject: [www] Show column count on table page
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6d471b6ce4f226b58a29e43f3a0c1c916669b2
Gerrit-Change-Number: 13243
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 07 May 2019 02:13:14 +0000
Gerrit-HasComments: No
[kudu-CR] [www] Show column count on table page
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13243 )
Change subject: [www] Show column count on table page
......................................................................
Patch Set 1:
(3 comments)
Oof. Missed this one for a while. SGTM just need to drop the 's' in some places.
http://gerrit.cloudera.org:8080/#/c/13243/1/src/kudu/master/master_path_handlers.cc
File src/kudu/master/master_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/13243/1/src/kudu/master/master_path_handlers.cc@331
PS1, Line 331: columns_count
column_count
http://gerrit.cloudera.org:8080/#/c/13243/1/www/table.mustache
File www/table.mustache:
http://gerrit.cloudera.org:8080/#/c/13243/1/www/table.mustache@34
PS1, Line 34: columns_count
column_count
http://gerrit.cloudera.org:8080/#/c/13243/1/www/table.mustache@34
PS1, Line 34: Columns Count
Column count
--
To view, visit http://gerrit.cloudera.org:8080/13243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6d471b6ce4f226b58a29e43f3a0c1c916669b2
Gerrit-Change-Number: 13243
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 06 May 2019 20:18:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] [www] Show column count on table page
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13243
to look at the new patch set (#2).
Change subject: [www] Show column count on table page
......................................................................
[www] Show column count on table page
Table column count is not obvious displayed when it has been altered
several times, there maybe some holes in column IDs. This patch show
the current column count of table.
Change-Id: I8c6d471b6ce4f226b58a29e43f3a0c1c916669b2
---
M src/kudu/master/master_path_handlers.cc
M www/table.mustache
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/13243/2
--
To view, visit http://gerrit.cloudera.org:8080/13243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c6d471b6ce4f226b58a29e43f3a0c1c916669b2
Gerrit-Change-Number: 13243
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>