You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "daniancu (via GitHub)" <gi...@apache.org> on 2025/03/07 16:00:06 UTC
[PR] OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated [jackrabbit-oak]
daniancu opened a new pull request, #2157:
URL: https://github.com/apache/jackrabbit-oak/pull/2157
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #2157:
URL: https://github.com/apache/jackrabbit-oak/pull/2157#discussion_r2022136277
##########
oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/document/RevisionsCommandTest.java:
##########
@@ -201,7 +201,7 @@ public void fullGC() {
assertTrue(output.contains("FullGcDelayFactory is : 2.0"));
assertTrue(output.contains("FullGcBatchSize is : 1000"));
assertTrue(output.contains("FullGcProgressSize is : 10000"));
- assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400"));
+ assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400\n"));
Review Comment:
This change breaks tests on Windows systems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on code in PR #2157:
URL: https://github.com/apache/jackrabbit-oak/pull/2157#discussion_r2022153024
##########
oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/document/RevisionsCommandTest.java:
##########
@@ -201,7 +201,7 @@ public void fullGC() {
assertTrue(output.contains("FullGcDelayFactory is : 2.0"));
assertTrue(output.contains("FullGcBatchSize is : 1000"));
assertTrue(output.contains("FullGcProgressSize is : 10000"));
- assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400"));
+ assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400\n"));
Review Comment:
> This change breaks tests on Windows systems.
Do we need to need this change before CF ?
> Nitpicking: why is there a space before the colons?
I think this has been done to it consistent with other verifications done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #2157:
URL: https://github.com/apache/jackrabbit-oak/pull/2157#discussion_r2022149649
##########
oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/document/RevisionsCommandTest.java:
##########
@@ -201,7 +201,7 @@ public void fullGC() {
assertTrue(output.contains("FullGcDelayFactory is : 2.0"));
assertTrue(output.contains("FullGcBatchSize is : 1000"));
assertTrue(output.contains("FullGcProgressSize is : 10000"));
- assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400"));
+ assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400\n"));
Review Comment:
Nitpicking: why is there a space before the colons?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated [jackrabbit-oak]
Posted by "Joscorbe (via GitHub)" <gi...@apache.org>.
Joscorbe merged PR #2157:
URL: https://github.com/apache/jackrabbit-oak/pull/2157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on code in PR #2157:
URL: https://github.com/apache/jackrabbit-oak/pull/2157#discussion_r2022153024
##########
oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/document/RevisionsCommandTest.java:
##########
@@ -201,7 +201,7 @@ public void fullGC() {
assertTrue(output.contains("FullGcDelayFactory is : 2.0"));
assertTrue(output.contains("FullGcBatchSize is : 1000"));
assertTrue(output.contains("FullGcProgressSize is : 10000"));
- assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400"));
+ assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400\n"));
Review Comment:
> This change breaks tests on Windows systems.
Do we need to change this before CF?
> Nitpicking: why is there a space before the colons?
I think this has been done to it consistent with other verifications done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #2157:
URL: https://github.com/apache/jackrabbit-oak/pull/2157#discussion_r2022191539
##########
oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/document/RevisionsCommandTest.java:
##########
@@ -201,7 +201,7 @@ public void fullGC() {
assertTrue(output.contains("FullGcDelayFactory is : 2.0"));
assertTrue(output.contains("FullGcBatchSize is : 1000"));
assertTrue(output.contains("FullGcProgressSize is : 10000"));
- assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400"));
+ assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400\n"));
Review Comment:
-> https://issues.apache.org/jira/browse/OAK-11630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #2157:
URL: https://github.com/apache/jackrabbit-oak/pull/2157#discussion_r2022156127
##########
oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/document/RevisionsCommandTest.java:
##########
@@ -201,7 +201,7 @@ public void fullGC() {
assertTrue(output.contains("FullGcDelayFactory is : 2.0"));
assertTrue(output.contains("FullGcBatchSize is : 1000"));
assertTrue(output.contains("FullGcProgressSize is : 10000"));
- assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400"));
+ assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400\n"));
Review Comment:
1) It should be trivial; I'm on it.
2) Ack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated [jackrabbit-oak]
Posted by "daniancu (via GitHub)" <gi...@apache.org>.
daniancu commented on code in PR #2157:
URL: https://github.com/apache/jackrabbit-oak/pull/2157#discussion_r1993213066
##########
oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/document/RevisionsCommandTest.java:
##########
@@ -201,7 +201,7 @@ public void fullGC() {
assertTrue(output.contains("FullGcDelayFactory is : 2.0"));
assertTrue(output.contains("FullGcBatchSize is : 1000"));
assertTrue(output.contains("FullGcProgressSize is : 10000"));
- assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400"));
+ assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400\n"));
Review Comment:
yes, the wrong value was `86400000` and was still passing the test
i've updated the same for all numeric values checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated [jackrabbit-oak]
Posted by "Joscorbe (via GitHub)" <gi...@apache.org>.
Joscorbe commented on code in PR #2157:
URL: https://github.com/apache/jackrabbit-oak/pull/2157#discussion_r1991580091
##########
oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/document/RevisionsCommandTest.java:
##########
@@ -201,7 +201,7 @@ public void fullGC() {
assertTrue(output.contains("FullGcDelayFactory is : 2.0"));
assertTrue(output.contains("FullGcBatchSize is : 1000"));
assertTrue(output.contains("FullGcProgressSize is : 10000"));
- assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400"));
+ assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400\n"));
Review Comment:
I assume the `\n` is to ensure the value is exactly **86400** and not something else containing that string, but I wonder if we should then apply the same to the rest of asserts to maintain consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org