You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Makundi (JIRA)" <ji...@apache.org> on 2009/10/14 10:20:31 UTC

[jira] Created: (WICKET-2522) Easy fix suggestion: In BaseWicketTester 'IFormSubmitting' component should be the submitting component, not just a 'Button'

Easy fix suggestion: In BaseWicketTester 'IFormSubmitting' component should be the submitting component, not just a 'Button'
----------------------------------------------------------------------------------------------------------------------------

                 Key: WICKET-2522
                 URL: https://issues.apache.org/jira/browse/WICKET-2522
             Project: Wicket
          Issue Type: Bug
            Reporter: Martin Makundi


Line "if (!((formComponent instanceof Button) && (component instanceof Button)) ||"

should be changed into

Line "if (!((formComponent instanceof IFormSubmittingComponent) && (component instanceof IFormSubmittingComponent)) ||"

See attached quickstart.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-2522) Easy fix suggestion: In BaseWicketTester 'IFormSubmitting' component should be the submitting component, not just a 'Button'

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-2522.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M1
                   1.4.3
         Assignee: Juergen Donnerstag

thanks

> Easy fix suggestion: In BaseWicketTester 'IFormSubmitting' component should be the submitting component, not just a 'Button'
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-2522
>                 URL: https://issues.apache.org/jira/browse/WICKET-2522
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Martin Makundi
>            Assignee: Juergen Donnerstag
>             Fix For: 1.4.3, 1.5-M1
>
>         Attachments: patch_wicket_2522.txt, Wicket-Quickstart.zip
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Line "if (!((formComponent instanceof Button) && (component instanceof Button)) ||"
> should be changed into
> Line "if (!((formComponent instanceof IFormSubmittingComponent) && (component instanceof IFormSubmittingComponent)) ||"
> See attached quickstart.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2522) Easy fix suggestion: In BaseWicketTester 'IFormSubmitting' component should be the submitting component, not just a 'Button'

Posted by "Martin Makundi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Makundi updated WICKET-2522:
-----------------------------------

    Attachment: patch_wicket_2522.txt

Patch 

> Easy fix suggestion: In BaseWicketTester 'IFormSubmitting' component should be the submitting component, not just a 'Button'
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-2522
>                 URL: https://issues.apache.org/jira/browse/WICKET-2522
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Martin Makundi
>         Attachments: patch_wicket_2522.txt, Wicket-Quickstart.zip
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Line "if (!((formComponent instanceof Button) && (component instanceof Button)) ||"
> should be changed into
> Line "if (!((formComponent instanceof IFormSubmittingComponent) && (component instanceof IFormSubmittingComponent)) ||"
> See attached quickstart.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2522) Easy fix suggestion: In BaseWicketTester 'IFormSubmitting' component should be the submitting component, not just a 'Button'

Posted by "Martin Makundi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Makundi updated WICKET-2522:
-----------------------------------

    Affects Version/s: 1.4.0

> Easy fix suggestion: In BaseWicketTester 'IFormSubmitting' component should be the submitting component, not just a 'Button'
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-2522
>                 URL: https://issues.apache.org/jira/browse/WICKET-2522
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Martin Makundi
>         Attachments: Wicket-Quickstart.zip
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Line "if (!((formComponent instanceof Button) && (component instanceof Button)) ||"
> should be changed into
> Line "if (!((formComponent instanceof IFormSubmittingComponent) && (component instanceof IFormSubmittingComponent)) ||"
> See attached quickstart.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2522) Easy fix suggestion: In BaseWicketTester 'IFormSubmitting' component should be the submitting component, not just a 'Button'

Posted by "Martin Makundi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Makundi updated WICKET-2522:
-----------------------------------

    Attachment: Wicket-Quickstart.zip

Line "if (!((formComponent instanceof Button) && (component instanceof Button)) ||"

of "BaseWicketTester" should be changed into

Line "if (!((formComponent instanceof IFormSubmittingComponent) && (component instanceof IFormSubmittingComponent)) ||"

See attached quickstart.

> Easy fix suggestion: In BaseWicketTester 'IFormSubmitting' component should be the submitting component, not just a 'Button'
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-2522
>                 URL: https://issues.apache.org/jira/browse/WICKET-2522
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Martin Makundi
>         Attachments: Wicket-Quickstart.zip
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Line "if (!((formComponent instanceof Button) && (component instanceof Button)) ||"
> should be changed into
> Line "if (!((formComponent instanceof IFormSubmittingComponent) && (component instanceof IFormSubmittingComponent)) ||"
> See attached quickstart.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.