[GitHub] [flink] rmetzger commented on pull request #12823: FLINK-18013: Refactor Hadoop utils to a single module

[GitBox <gi...@apache.org>]

rmetzger commented on pull request #12823:
URL: https://github.com/apache/flink/pull/12823#issuecomment-661059133


   Thanks a lot for your contribution. 
   Sorry for the delay. I was on vacation.
   
   Regarding the dependency convergence: Since Hadoop's dependencies do not converge, we can not really achieve dependency convergence in modules depending on Hadoop.
   I would suggest to disable the convergence check in `flink-hadoop-utils` as follows:
   ```
   			<plugin>
   				<groupId>org.apache.maven.plugins</groupId>
   				<artifactId>maven-enforcer-plugin</artifactId>
   				<executions>
   					<execution>
   						<id>dependency-convergence</id>
   						<goals>
   							<goal>enforce</goal>
   						</goals>
   						<configuration>
   							<skip>true</skip>
   						</configuration>
   					</execution>
   				</executions>
   			</plugin>
   ```
   I will soon review all the proposed changes ...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org