You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/28 07:14:14 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request, #4221: fix line ending
aldettinger opened a new pull request, #4221:
URL: https://github.com/apache/camel-quarkus/pull/4221
On my local machine I ended up with message like:
```
warning: CRLF will be replaced by LF in integration-test-groups/cxf-soap/cxf-soap-mtom-awt/src/test/resources/linux-image.png.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in integration-test-groups/cxf-soap/cxf-soap-mtom/src/test/resources/linux-image.png.
The file will have its original line endings in your working directory.
diff --git a/integration-test-groups/cxf-soap/cxf-soap-mtom-awt/src/test/resources/linux-image.png b/integration-test-groups/cxf-soap/cxf-soap-mtom-awt/src/test/resources/linux-image.png
index 17d7bfe..4dc8fda 100644
Binary files a/integration-test-groups/cxf-soap/cxf-soap-mtom-awt/src/test/resources/linux-image.png and b/integration-test-groups/cxf-soap/cxf-soap-mtom-awt/src/test/resources/linux-image.png differ
diff --git a/integration-test-groups/cxf-soap/cxf-soap-mtom/src/test/resources/linux-image.png b/integration-test-groups/cxf-soap/cxf-soap-mtom/src/test/resources/linux-image.png
index 17d7bfe..4dc8fda 100644
Binary files a/integration-test-groups/cxf-soap/cxf-soap-mtom/src/test/resources/linux-image.png and b/integration-test-groups/cxf-soap/cxf-soap-mtom/src/test/resources/linux-image.png differ
[main_upstream @ camel-quarkus-upstream]$ git commit -am 'fix line ending'
warning: CRLF will be replaced by LF in integration-test-groups/cxf-soap/cxf-soap-mtom-awt/src/test/resources/linux-image.png.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in integration-test-groups/cxf-soap/cxf-soap-mtom/src/test/resources/linux-image.png.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in integration-test-groups/cxf-soap/cxf-soap-mtom-awt/src/test/resources/linux-image.png.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in integration-test-groups/cxf-soap/cxf-soap-mtom/src/test/resources/linux-image.png.
The file will have its original line endings in your working directory.
```
Should we fix it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4221: fix line ending
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #4221:
URL: https://github.com/apache/camel-quarkus/pull/4221#issuecomment-1294621217
Seems to work locally. Let's see if the build pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4221: fix line ending
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #4221:
URL: https://github.com/apache/camel-quarkus/pull/4221#issuecomment-1294605390
Sounds like a good idea, let's experiment with that then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4221: fix line ending
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #4221:
URL: https://github.com/apache/camel-quarkus/pull/4221#issuecomment-1294910905
The CI failure is not related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4221: fix line ending
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on PR #4221:
URL: https://github.com/apache/camel-quarkus/pull/4221#issuecomment-1294580312
Probably better to add `*.png binary` to `.gitattributes`.
There's some other stuff that we should probably add like:
```
*.jks binary
*.ttf binary
*.zip binary
*.jar binary
```
Not sure if there's a catch-all way of handling it without defining things individually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #4221: fix line ending
Posted by GitBox <gi...@apache.org>.
aldettinger merged PR #4221:
URL: https://github.com/apache/camel-quarkus/pull/4221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org