You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/04 21:42:05 UTC

[GitHub] [beam] rehmanmuradali commented on pull request #12433: [BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn

rehmanmuradali commented on pull request #12433:
URL: https://github.com/apache/beam/pull/12433#issuecomment-668839401


   > Thanks @Imfuyuwei
   > 
   > > Yes, one of my previous commit has some tests related to NULL case.
   > > [a960772#diff-4f4ffa265fe666e99c37c346d50da67dR428-R434](https://github.com/apache/beam/commit/a960772cde0a5e1d31f4de7c9349ad23f97954ce#diff-4f4ffa265fe666e99c37c346d50da67dR428-R434)
   > 
   > @rehmanmuradali can you check this test case and make sure it passes before get this PR merged?
   
   
   @amaliujia  the test is failing. Seems like the issue is reported here [BEAM-10379](https://issues.apache.org/jira/browse/BEAM-10379)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org