You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2025/09/08 18:52:31 UTC
[PR] chore: Add yarn package manager file [texera]
aglinxinyuan opened a new pull request, #3719:
URL: https://github.com/apache/texera/pull/3719
The current Wiki Step for installing yarn is outdated and no longer works on Windows, making it unnecessary.
<img width="916" height="192" alt="Screenshot 2025-09-08 at 11 48 53" src="https://github.com/user-attachments/assets/ace66aca-5b54-4cc6-9fdf-9a7fa1fba361" />
https://github.com/apache/texera/wiki/Guide-for-Developers#yarn
Following the offcial yarn guide, we can add the yarn to codebase, and avoid additional step for developer.
Source: https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Add yarn package manager file [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #3719:
URL: https://github.com/apache/texera/pull/3719#discussion_r2332224939
##########
core/gui/.gitignore:
##########
@@ -15,10 +15,11 @@ src/environments/version.ts
.angular
# yarn v4 related
-.pnp.*
.yarn/*
+!.yarn/cache
Review Comment:
it's explained in the link: `
.yarn/cache and .pnp.* may be safely ignored, but you'll need to run yarn install to regenerate them between each branch switch - which would be optional otherwise, cf Zero-Installs.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Add yarn package manager file [texera]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3719:
URL: https://github.com/apache/texera/pull/3719#discussion_r2331116029
##########
.licenserc.yaml:
##########
@@ -23,4 +23,6 @@ header:
- 'site.webmanifest'
- '.gitignore'
- '.licenserc.yaml'
+ - 'core/gui/.yarn/*'
+ -
Review Comment:
There's an empty exclude entry on line 27. This should be removed as it serves no purpose and could cause confusion.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Add yarn package manager file [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #3719:
URL: https://github.com/apache/texera/pull/3719#discussion_r2332224939
##########
core/gui/.gitignore:
##########
@@ -15,10 +15,11 @@ src/environments/version.ts
.angular
# yarn v4 related
-.pnp.*
.yarn/*
+!.yarn/cache
Review Comment:
it's explained in the link: `If you're interested to know more about each of these files:
.yarn/cache and .pnp.* may be safely ignored, but you'll need to run yarn install to regenerate them between each branch switch - which would be optional otherwise, cf Zero-Installs.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Add yarn package manager file [texera]
Posted by "yunyad (via GitHub)" <gi...@apache.org>.
yunyad commented on code in PR #3719:
URL: https://github.com/apache/texera/pull/3719#discussion_r2332210010
##########
core/gui/.gitignore:
##########
@@ -15,10 +15,11 @@ src/environments/version.ts
.angular
# yarn v4 related
-.pnp.*
.yarn/*
+!.yarn/cache
Review Comment:
Why don't we ignore cache?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Add yarn package manager file [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #3719:
URL: https://github.com/apache/texera/pull/3719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org