You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mintsweet (via GitHub)" <gi...@apache.org> on 2023/06/14 03:04:33 UTC
[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #5468: fix: fix jira remote api
mintsweet commented on code in PR #5468:
URL: https://github.com/apache/incubator-devlake/pull/5468#discussion_r1228922193
##########
backend/plugins/jira/api/remote.go:
##########
@@ -58,14 +58,21 @@ func RemoteScopes(input *plugin.ApiResourceInput) (*plugin.ApiResourceOutput, er
}
resBody := struct {
- Values []apiv2models.Board `json:"values"`
+ MaxResults int `json:"maxResults"`
+ StartAt int `json:"startAt"`
+ Values []apiv2models.Board `json:"values"`
}{}
err = api.UnmarshalResponse(res, &resBody)
if err != nil {
return nil, err
}
+ if (queryData.PerPage != resBody.MaxResults) ||
Review Comment:
why not use `isLast` as the condition?

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org