You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "bbeaudreault (via GitHub)" <gi...@apache.org> on 2023/03/03 17:35:33 UTC
[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5063: HBASE-27646 Should not use pread when prefetching in HFilePreadReader
bbeaudreault commented on code in PR #5063:
URL: https://github.com/apache/hbase/pull/5063#discussion_r1124801564
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java:
##########
@@ -269,6 +269,7 @@ private FSDataInputStream tryOpen() throws IOException {
}
}
currentPath = path;
+ fileLink.setReaderPath(path);
Review Comment:
I think it's odd that doing `new FileLinkInputStream(fs, fileLink)` modifies my passed in FileLink.
Maybe not the end of the world, but seems better to keep immutable. Is there any other way to do what you're trying to do without mutating the passed in link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org