You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/07/20 15:10:14 UTC
[GitHub] [trafficserver] shinrich opened a new pull request #8096: Fail requests with incomplete line ends
shinrich opened a new pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096
To be RFC compliant, trafficserver should reject requests that use \n instead of \r\n. This required updating a number of our test files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8096: Fail requests with incomplete line ends
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096#issuecomment-883597914
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich merged pull request #8096: Fail requests with incomplete line ends
Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #8096: Fail requests with incomplete line ends
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096#issuecomment-897377332
[approve ci Clang-Analyzer]
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt removed a comment on pull request #8096: Fail requests with incomplete line ends
Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096#issuecomment-883602587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8096: Fail requests with incomplete line ends
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096#issuecomment-883656957
Lots of files changed, but only one file is core. One file for unit tests. And the rest are updates where are autests were relying on newline only line endings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8096: Fail requests with incomplete line ends
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096#issuecomment-909697958
I'm going to remove this from 9.1.x project, since we have a better patch soon to replace this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8096: Fail requests with incomplete line ends
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096#issuecomment-909697958
I'm going to remove this from 9.1.x project, since we have a better patch soon to replace this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #8096: Fail requests with incomplete line ends
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096#issuecomment-886450286
This may be slightly different from the original issue, but would you add these tests and update the parser while you are at it?
```
{"GET /index.html HTTP/1.0\r\na\rb\n", PARSE_RESULT_ERROR, 30},
{"GET /index.html HTTP/1.0\r\nUser-Agent: foobar\r \n", PARSE_RESULT_ERROR, 47},
```
Also, I noticed that the test case below is untestable because it causes a crash, regardless of this change. It's probably because the request string is static. I couldn't reproduce the crash if I send the request over network (to traffic_server by nc command).
```
{"GET /index.html HTTP/1.0\r\nUser-Agent: foobar\r\n \r\n", PARSE_RESULT_ERROR, 49},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #8096: Fail requests with incomplete line ends
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096#issuecomment-898071199
It seems like Autest fails due to file name mismatch. "test-0rtt-s_client.py" probably need to be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8096: Fail requests with incomplete line ends
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096#issuecomment-901403195
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8096: Fail requests with incomplete line ends
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096#issuecomment-894536436
Pushed new commit adding the tests @maskit. Plus fixing the issues these tests introduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8096: Fail requests with incomplete line ends
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096#issuecomment-883607871
[approve ci clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8096: Fail requests with incomplete line ends
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8096:
URL: https://github.com/apache/trafficserver/pull/8096#issuecomment-883602587
[approve ci clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org