[GitHub] [skywalking-java] kezhenxu94 commented on pull request #466: fix tomcat-10x-plugin and add test case to support tomcat7.x-8.x-9.x

["kezhenxu94 (via GitHub)" <gi...@apache.org>]

kezhenxu94 commented on PR #466:
URL: https://github.com/apache/skywalking-java/pull/466#issuecomment-1452944810

   > > Somehow Spring 6 case fails? Could you recheck?
   > 
   > The only issue I could find is that we expected `POST:/create` call returns status code 200, but in the actual data is 201.
   > 
   > But I don't think this PR is relevant. Since for `EntrySpan`, the tag is set when `stackDepth == currentMaxDepth`. This means only the Spring plugin can set tags.
   
   
   This is somewhat relevant, I tested Spring 6 and expected the status code to be 201 but it was always 200, I was sure it was not an issue of Spring plugin but didn't dig deeper to the cause, so this PR accidentally fixes the bug too, so, please update the expected data for Spring 6, change status code from 200 to 201.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org