[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7373: SQL support for time-ordered scan

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #7373: SQL support for time-ordered scan
URL: https://github.com/apache/incubator-druid/pull/7373#discussion_r271460386
 
 

 ##########
 File path: sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java
 ##########
 @@ -452,12 +455,20 @@ private static ProjectRowOrderAndPostAggregations computePostAggregations(
   {
     final Aggregate aggregate = Preconditions.checkNotNull(partialQuery.getAggregate());
     final List<DimensionExpression> dimensions = new ArrayList<>();
-    final String outputNamePrefix = Calcites.findUnusedPrefix("d", new TreeSet<>(querySignature.getRowSignature().getRowOrder()));
+    final String outputNamePrefix = Calcites.findUnusedPrefix(
+        "d",
+        new TreeSet<>(querySignature.getRowSignature()
 
 Review comment:
   this treeset declaration can be on one line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org