You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Paulex Yang (JIRA)" <ji...@apache.org> on 2006/04/21 11:42:05 UTC
[jira] Created: (HARMONY-383) java.lang.StringBuilder should
implement Appendable
java.lang.StringBuilder should implement Appendable
---------------------------------------------------
Key: HARMONY-383
URL: http://issues.apache.org/jira/browse/HARMONY-383
Project: Harmony
Type: Bug
Components: Classlib
Reporter: Paulex Yang
Priority: Minor
java.lang.StringBuilder should implement Appendable, but not implemented in Harmony(project luni).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
RE: [jira] Created: (HARMONY-383) java.lang.StringBuilder should implement Appendable
Posted by Nathan Beyer <nb...@kc.rr.com>.
Thanks for the heads up. I posted a patch on the issue.
-Nathan
> -----Original Message-----
> From: Paulex Yang [mailto:paulex.yang@gmail.com]
> Sent: Friday, April 21, 2006 5:07 AM
> To: harmony-dev@incubator.apache.org
> Subject: Re: [jira] Created: (HARMONY-383) java.lang.StringBuilder should
> implement Appendable
>
> Nathan,
>
> My work on java.util.Formatter blocks on this issue and Harmony-348,
> because you are the contributor of initial StringBuilder implementation,
> so I'd like to know if you are willing to patch them? Otherwise I'll
> try. Thank you. :-)
>
> Paulex Yang (JIRA) wrote:
> > java.lang.StringBuilder should implement Appendable
> > ---------------------------------------------------
> >
> > Key: HARMONY-383
> > URL: http://issues.apache.org/jira/browse/HARMONY-383
> > Project: Harmony
> > Type: Bug
> >
> > Components: Classlib
> > Reporter: Paulex Yang
> > Priority: Minor
> >
> >
> > java.lang.StringBuilder should implement Appendable, but not implemented
> in Harmony(project luni).
> >
> >
>
>
> --
> Paulex Yang
> China Software Development Lab
> IBM
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [jira] Created: (HARMONY-383) java.lang.StringBuilder should
implement Appendable
Posted by Paulex Yang <pa...@gmail.com>.
Nathan,
My work on java.util.Formatter blocks on this issue and Harmony-348,
because you are the contributor of initial StringBuilder implementation,
so I'd like to know if you are willing to patch them? Otherwise I'll
try. Thank you. :-)
Paulex Yang (JIRA) wrote:
> java.lang.StringBuilder should implement Appendable
> ---------------------------------------------------
>
> Key: HARMONY-383
> URL: http://issues.apache.org/jira/browse/HARMONY-383
> Project: Harmony
> Type: Bug
>
> Components: Classlib
> Reporter: Paulex Yang
> Priority: Minor
>
>
> java.lang.StringBuilder should implement Appendable, but not implemented in Harmony(project luni).
>
>
--
Paulex Yang
China Software Development Lab
IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
[jira] Closed: (HARMONY-383) java.lang.StringBuilder should
implement Appendable
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-383?page=all ]
Stepan Mishura closed HARMONY-383:
----------------------------------
Verified by Nathan.
> java.lang.StringBuilder should implement Appendable
> ---------------------------------------------------
>
> Key: HARMONY-383
> URL: http://issues.apache.org/jira/browse/HARMONY-383
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: StringBuffer_Appendable_patch.txt, StringBuilder_Appendable_patch.txt
>
> java.lang.StringBuilder should implement Appendable, but not implemented in Harmony(project luni).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-383) java.lang.StringBuilder should
implement Appendable
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-383?page=all ]
Nathan Beyer updated HARMONY-383:
---------------------------------
Attachment: StringBuffer_Appendable_patch.txt
Another patch for StringBuffer, which needed this as well.
> java.lang.StringBuilder should implement Appendable
> ---------------------------------------------------
>
> Key: HARMONY-383
> URL: http://issues.apache.org/jira/browse/HARMONY-383
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Priority: Minor
> Attachments: StringBuffer_Appendable_patch.txt, StringBuilder_Appendable_patch.txt
>
> java.lang.StringBuilder should implement Appendable, but not implemented in Harmony(project luni).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-383) java.lang.StringBuilder should
implement Appendable
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-383?page=all ]
Stepan Mishura resolved HARMONY-383:
------------------------------------
Resolution: Fixed
Thanks Nathan, Paulex.
Patch was applied to LUNI module at repo revision 396494.
Please check that the patch was applied as you expected.
Note: I found that the spec. for these classes is confusing a little bit, for example for StringBuffer class it says:
" All Implemented Interfaces: Serializable, Appendable, CharSequence "
and the spec. adds:
" public final class StringBuffer extends Object implements Serializable, CharSequence"
> java.lang.StringBuilder should implement Appendable
> ---------------------------------------------------
>
> Key: HARMONY-383
> URL: http://issues.apache.org/jira/browse/HARMONY-383
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: StringBuffer_Appendable_patch.txt, StringBuilder_Appendable_patch.txt
>
> java.lang.StringBuilder should implement Appendable, but not implemented in Harmony(project luni).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-383) java.lang.StringBuilder should
implement Appendable
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-383?page=comments#action_12376158 ]
Paulex Yang commented on HARMONY-383:
-------------------------------------
Looks good, thank you, Stepan.
I agree with Nathan that the issue Stepan mentioned dues to JavaDoc's limitation. The following short test shows that StringBuilder does implement Appendable.
public static void main(String[] args) throws IOException {
StringBuilder builder = new StringBuilder();
Appendable a = (Appendable)builder;
a.append("test");
System.out.println(a.toString());
}
> java.lang.StringBuilder should implement Appendable
> ---------------------------------------------------
>
> Key: HARMONY-383
> URL: http://issues.apache.org/jira/browse/HARMONY-383
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: StringBuffer_Appendable_patch.txt, StringBuilder_Appendable_patch.txt
>
> java.lang.StringBuilder should implement Appendable, but not implemented in Harmony(project luni).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-383) java.lang.StringBuilder should
implement Appendable
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-383?page=comments#action_12376141 ]
Nathan Beyer commented on HARMONY-383:
--------------------------------------
The patches look good.
Regarding the spec documentation, I think that might be a bug/quirk of the Javadoc tool. If you look at the 'Serialized Form' of StringBuilder and StringBuffer, you can see it gives away an implementation detail, which is that they both derive from a 'java.lang.AbstractStringBuilder'. My guess is that it's really this AbstractStringBuilder that actually implements Appendable. That's just a guess though.
> java.lang.StringBuilder should implement Appendable
> ---------------------------------------------------
>
> Key: HARMONY-383
> URL: http://issues.apache.org/jira/browse/HARMONY-383
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: StringBuffer_Appendable_patch.txt, StringBuilder_Appendable_patch.txt
>
> java.lang.StringBuilder should implement Appendable, but not implemented in Harmony(project luni).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-383) java.lang.StringBuilder should
implement Appendable
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-383?page=comments#action_12375654 ]
Nathan Beyer commented on HARMONY-383:
--------------------------------------
The patch is fairly trivial; adds Appendable and cleans up comment.
> java.lang.StringBuilder should implement Appendable
> ---------------------------------------------------
>
> Key: HARMONY-383
> URL: http://issues.apache.org/jira/browse/HARMONY-383
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Priority: Minor
> Attachments: StringBuilder_Appendable_patch.txt
>
> java.lang.StringBuilder should implement Appendable, but not implemented in Harmony(project luni).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-383) java.lang.StringBuilder should
implement Appendable
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-383?page=all ]
Stepan Mishura reassigned HARMONY-383:
--------------------------------------
Assign To: Stepan Mishura
> java.lang.StringBuilder should implement Appendable
> ---------------------------------------------------
>
> Key: HARMONY-383
> URL: http://issues.apache.org/jira/browse/HARMONY-383
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: StringBuffer_Appendable_patch.txt, StringBuilder_Appendable_patch.txt
>
> java.lang.StringBuilder should implement Appendable, but not implemented in Harmony(project luni).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-383) java.lang.StringBuilder should
implement Appendable
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-383?page=all ]
Nathan Beyer updated HARMONY-383:
---------------------------------
Attachment: StringBuilder_Appendable_patch.txt
> java.lang.StringBuilder should implement Appendable
> ---------------------------------------------------
>
> Key: HARMONY-383
> URL: http://issues.apache.org/jira/browse/HARMONY-383
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Priority: Minor
> Attachments: StringBuilder_Appendable_patch.txt
>
> java.lang.StringBuilder should implement Appendable, but not implemented in Harmony(project luni).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira