Re: [PR] chore(deps): upgrade React 18 to 19 [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on code in PR #42112:
URL: https://github.com/apache/superset/pull/42112#discussion_r4162934294


##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Contour/Contour.tsx:
##########
@@ -167,7 +167,7 @@ export const getLayer: GetLayerType<ContourLayer> = function ({
     cellSize: safeCellSize,
     aggregation: aggregation.toUpperCase(),
     getPosition: (d: { position: number[]; weight: number }) =>
-      d.position as Position,
+      d.position as unknown as Position,
     getWeight: (d: { weight: number }) => d.weight || 0,

Review Comment:
   This is already done in the current diff, `position` is typed as `Position` directly and the cast is gone. Resolving.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org