You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2019/04/05 00:37:29 UTC

[GitHub] [geode] kirklund opened pull request #3413: GEODE-6603: Make StoppableCountDownLatch extend CountDownLatch

* Create StoppableCountDownLatchTest and fixup any issues uncovered by
testing.
* Make StoppableCountDownLatch extend CountDownLatch.
* Remove unused class StoppableCountDownOrUpLatch.
* Improve ExecutorServiceRule for StoppableCountDownLatchTest.

While trying to refactor region initialization level in LocalRegion, I found out that StoppableCountDownLatch did not extend CountDownLatch which was making a change difficult for me.

[ Full content available at: https://github.com/apache/geode/pull/3413 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] moleske commented on pull request #3413: GEODE-6603: Make StoppableCountDownLatch extend CountDownLatch

Posted by "moleske (GitHub)" <gi...@apache.org>.
same dealio as above

[ Full content available at: https://github.com/apache/geode/pull/3413 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] moleske commented on pull request #3413: GEODE-6603: Make StoppableCountDownLatch extend CountDownLatch

Posted by "moleske (GitHub)" <gi...@apache.org>.
probably not super informative

[ Full content available at: https://github.com/apache/geode/pull/3413 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #3413: GEODE-6603: Create StoppableCountDownLatch unit tests

Posted by "kirklund (GitHub)" <gi...@apache.org>.
[ pull request closed by kirklund ]

[ Full content available at: https://github.com/apache/geode/pull/3413 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #3413: GEODE-6603: Make StoppableCountDownLatch extend CountDownLatch

Posted by "kirklund (GitHub)" <gi...@apache.org>.
@upthewaterspout We changed StoppableCountDownLatch to delegate to CountDownLatch instead of extending it and changed the ticket to "StoppableCountDownLatch should have unit tests"

[ Full content available at: https://github.com/apache/geode/pull/3413 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org