You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/04 22:30:37 UTC

[GitHub] [beam] rohdesamuel commented on a change in pull request #10994: [BEAM-8335] TeststreamService integration with DirectRunner

rohdesamuel commented on a change in pull request #10994: [BEAM-8335] TeststreamService integration with DirectRunner
URL: https://github.com/apache/beam/pull/10994#discussion_r387973912
 
 

 ##########
 File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
 ##########
 @@ -527,9 +548,21 @@ def process_element(self, element):
       for event in self.test_stream._set_up(self.test_stream.output_tags):
         events.append(event)
 
-    events += [e for e in self.test_stream.events(self.current_index)]
+    # Index into the global state of all the different TestStream event streams.
+    # Retrieve this TestStream's event stream and read from it.
+    try:
+      events = [next(self.test_stream_events[self.event_index])]
 
 Review comment:
   This should be `events +=` instead of `events =`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services