You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/10/21 03:04:46 UTC

Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Kapil Arya, Niklas Nielsen, and Timothy Chen.


Repository: mesos


Description
-------

Added in reviews:

* https://reviews.apache.org/r/37196/
* https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
* https://reviews.apache.org/r/38253/
* https://reviews.apache.org/r/38367/
* https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1


Diffs
-----

  include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 

Diff: https://reviews.apache.org/r/39502/diff/


Testing
-------

None yet.

For now, this review is meant for checking which of these differences are intentional.


Thanks,

Joseph Wu

Re: Review Request 39502: [DO NOT COMMIT] Sync v1/mesos.proto with docker, QoS, and AppC changes.

Posted by Joseph Wu <jo...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/
-----------------------------------------------------------

(Updated Oct. 26, 2015, 2:27 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Kapil Arya, Niklas Nielsen, and Timothy Chen.


Changes
-------

Changing title, since not all changes have been confirmed yet.


Summary (updated)
-----------------

[DO NOT COMMIT] Sync v1/mesos.proto with docker, QoS, and AppC changes.


Repository: mesos


Description
-------

Added in reviews:

* https://reviews.apache.org/r/37196/
* https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
* https://reviews.apache.org/r/38253/
* https://reviews.apache.org/r/38367/
** NetworkInfo moved up the review chain.
* https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1


Diffs
-----

  include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 

Diff: https://reviews.apache.org/r/39502/diff/


Testing
-------

`make`

For now, this review is meant for checking which of these differences are intentional.


Thanks,

Joseph Wu

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/#review103644
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39531, 39502]

All tests passed.

- Mesos ReviewBot


On Oct. 22, 2015, 5:48 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39502/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 5:48 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Kapil Arya, Niklas Nielsen, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added in reviews:
> 
> * https://reviews.apache.org/r/37196/
> * https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
> * https://reviews.apache.org/r/38253/
> * https://reviews.apache.org/r/38367/
> ** NetworkInfo moved up the review chain.
> * https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 
> 
> Diff: https://reviews.apache.org/r/39502/diff/
> 
> 
> Testing
> -------
> 
> `make`
> 
> For now, this review is meant for checking which of these differences are intentional.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

Posted by Joseph Wu <jo...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/
-----------------------------------------------------------

(Updated Oct. 22, 2015, 10:48 a.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Kapil Arya, Niklas Nielsen, and Timothy Chen.


Changes
-------

Remove NetworkInfo.  It is being added in a separate review.


Repository: mesos


Description (updated)
-------

Added in reviews:

* https://reviews.apache.org/r/37196/
* https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
* https://reviews.apache.org/r/38253/
* https://reviews.apache.org/r/38367/
** NetworkInfo moved up the review chain.
* https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1


Diffs (updated)
-----

  include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 

Diff: https://reviews.apache.org/r/39502/diff/


Testing (updated)
-------

`make`

For now, this review is meant for checking which of these differences are intentional.


Thanks,

Joseph Wu

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

Posted by Guangya Liu <gy...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/#review103334
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On 十月 21, 2015, 1:04 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39502/
> -----------------------------------------------------------
> 
> (Updated 十月 21, 2015, 1:04 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Kapil Arya, Niklas Nielsen, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added in reviews:
> 
> * https://reviews.apache.org/r/37196/
> * https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
> * https://reviews.apache.org/r/38253/
> * https://reviews.apache.org/r/38367/
> * https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 
> 
> Diff: https://reviews.apache.org/r/39502/diff/
> 
> 
> Testing
> -------
> 
> None yet.
> 
> For now, this review is meant for checking which of these differences are intentional.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/#review103362
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39502]

All tests passed.

- Mesos ReviewBot


On Oct. 21, 2015, 1:04 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39502/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 1:04 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Kapil Arya, Niklas Nielsen, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added in reviews:
> 
> * https://reviews.apache.org/r/37196/
> * https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
> * https://reviews.apache.org/r/38253/
> * https://reviews.apache.org/r/38367/
> * https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 
> 
> Diff: https://reviews.apache.org/r/39502/diff/
> 
> 
> Testing
> -------
> 
> None yet.
> 
> For now, this review is meant for checking which of these differences are intentional.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

Posted by Joseph Wu <jo...@mesosphere.io>.


> On Oct. 21, 2015, 12:31 p.m., Kapil Arya wrote:
> > Ship It!

Just to confirm, https://reviews.apache.org/r/38367/diff/4#0 was omitted from V1 unintentionally?


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/#review103456
-----------------------------------------------------------


On Oct. 20, 2015, 6:04 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39502/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 6:04 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Kapil Arya, Niklas Nielsen, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added in reviews:
> 
> * https://reviews.apache.org/r/37196/
> * https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
> * https://reviews.apache.org/r/38253/
> * https://reviews.apache.org/r/38367/
> * https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 
> 
> Diff: https://reviews.apache.org/r/39502/diff/
> 
> 
> Testing
> -------
> 
> None yet.
> 
> For now, this review is meant for checking which of these differences are intentional.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39502: [DO NOT COMMIT] Sync v1/mesos.proto with docker, QoS, and AppC changes.

Posted by Kapil Arya <ka...@mesosphere.io>.


> On Oct. 21, 2015, 3:31 p.m., Kapil Arya wrote:
> > Ship It!
> 
> Joseph Wu wrote:
>     Just to confirm, https://reviews.apache.org/r/38367/diff/4#0 was omitted from V1 unintentionally?

Yes, that was an oversight on my end. Thanks for fixing this, Joseph!!


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/#review103456
-----------------------------------------------------------


On Oct. 26, 2015, 5:27 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39502/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 5:27 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Kapil Arya, Niklas Nielsen, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added in reviews:
> 
> * https://reviews.apache.org/r/37196/
> * https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
> * https://reviews.apache.org/r/38253/
> * https://reviews.apache.org/r/38367/
> ** NetworkInfo moved up the review chain.
> * https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 
> 
> Diff: https://reviews.apache.org/r/39502/diff/
> 
> 
> Testing
> -------
> 
> `make`
> 
> For now, this review is meant for checking which of these differences are intentional.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/#review103456
-----------------------------------------------------------

Ship it!


Ship It!

- Kapil Arya


On Oct. 20, 2015, 9:04 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39502/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 9:04 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Kapil Arya, Niklas Nielsen, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added in reviews:
> 
> * https://reviews.apache.org/r/37196/
> * https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
> * https://reviews.apache.org/r/38253/
> * https://reviews.apache.org/r/38367/
> * https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 
> 
> Diff: https://reviews.apache.org/r/39502/diff/
> 
> 
> Testing
> -------
> 
> None yet.
> 
> For now, this review is meant for checking which of these differences are intentional.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>