You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/24 19:11:20 UTC
[GitHub] [superset] maleksan opened a new pull request, #22220: feat(chart): Added Latvia to countries map
maleksan opened a new pull request, #22220:
URL: https://github.com/apache/superset/pull/22220
### SUMMARY
Added Latvia to countries map
### TESTING INSTRUCTIONS
Clone the repo and go to its root directory. Run the following shell commands:
cd superset-frontend && npm install
npm run plugins:storybook
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #22220: feat(chart): Added Latvia to countries map
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #22220:
URL: https://github.com/apache/superset/pull/22220#issuecomment-1327354934
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22220: feat(chart): Added Latvia to countries map
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22220:
URL: https://github.com/apache/superset/pull/22220#issuecomment-1326953245
# [Codecov](https://codecov.io/gh/apache/superset/pull/22220?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22220](https://codecov.io/gh/apache/superset/pull/22220?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (892ce04) into [master](https://codecov.io/gh/apache/superset/commit/1831e8c9273275f45ac174a301f21d3c2b11cc16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1831e8c) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #22220 +/- ##
=======================================
Coverage 66.90% 66.90%
=======================================
Files 1835 1835
Lines 69988 69988
Branches 7612 7612
=======================================
Hits 46825 46825
Misses 21197 21197
Partials 1966 1966
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.75% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...s/legacy-plugin-chart-country-map/src/countries.ts](https://codecov.io/gh/apache/superset/pull/22220/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9jb3VudHJpZXMudHM=) | `100.00% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22220: feat(chart): Added Latvia to countries map
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22220:
URL: https://github.com/apache/superset/pull/22220#issuecomment-1327368303
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #22220: feat(chart): Added Latvia to countries map
Posted by GitBox <gi...@apache.org>.
villebro merged PR #22220:
URL: https://github.com/apache/superset/pull/22220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #22220: feat(chart): Added Latvia to countries map
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #22220:
URL: https://github.com/apache/superset/pull/22220#issuecomment-1327207279
Thanks for this @maleksan ! Could you add a screenshot to the description showing the map in action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] maleksan commented on pull request #22220: feat(chart): Added Latvia to countries map
Posted by GitBox <gi...@apache.org>.
maleksan commented on PR #22220:
URL: https://github.com/apache/superset/pull/22220#issuecomment-1327228170
> Thanks for this @maleksan ! Could you add a screenshot to the description showing the map in action?
Added. Please add this new LV map into the next release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #22220: feat(chart): Added Latvia to countries map
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #22220:
URL: https://github.com/apache/superset/pull/22220#issuecomment-1327367679
> * Sorry, there will be no opportunity to make a build to demonstrate this to you in the near future.
> * Notebook changes added.
@maleksan I spun up test env and verified that the chart works as expected and added a screenshot to the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22220: feat(chart): Added Latvia to countries map
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22220:
URL: https://github.com/apache/superset/pull/22220#issuecomment-1327356576
@villebro Ephemeral environment spinning up at http://54.203.72.96:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] maleksan commented on pull request #22220: feat(chart): Added Latvia to countries map
Posted by GitBox <gi...@apache.org>.
maleksan commented on PR #22220:
URL: https://github.com/apache/superset/pull/22220#issuecomment-1327281523
> > > Thanks for this @maleksan ! Could you add a screenshot to the description showing the map in action?
> >
> >
> > Added. Please add this new LV map into the next release.
>
> Hi, I mostly meant showing a screenshot of the new map in Superset, not the notebook. Also, if you don't mind, please add the notebook changes to this PR so it's up to date.
- Sorry, there will be no opportunity to make a build to demonstrate this to you in the near future.
- Notebook changes added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #22220: feat(chart): Added Latvia to countries map
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #22220:
URL: https://github.com/apache/superset/pull/22220#issuecomment-1327233038
> > Thanks for this @maleksan ! Could you add a screenshot to the description showing the map in action?
>
> Added. Please add this new LV map into the next release.
Hi, I mostly meant showing a screenshot of the new map in Superset, not the notebook. Also, if you don't mind, please add the notebook changes to this PR so it's up to date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] maleksan commented on pull request #22220: feat(chart): Added Latvia to countries map
Posted by "maleksan (via GitHub)" <gi...@apache.org>.
maleksan commented on PR #22220:
URL: https://github.com/apache/superset/pull/22220#issuecomment-1441468833
@villebro,
is it possible to add this feature into the nearest Superset release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #22220: feat(chart): Added Latvia to countries map
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #22220:
URL: https://github.com/apache/superset/pull/22220#issuecomment-1441488370
@maleksan I believe this is included in the current 2.1.0 release candidate that's up for vote
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org