You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "adamdebreceni (via GitHub)" <gi...@apache.org> on 2023/08/02 11:15:34 UTC

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1623: MINIFICPP-2116 - Support GCC13

adamdebreceni commented on code in PR #1623:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1623#discussion_r1281761250


##########
extensions/sftp/processors/ListSFTP.cpp:
##########
@@ -535,9 +535,9 @@ void ListSFTP::listByTrackingTimestamps(
       /* Determine the minimum reliable timestamp based on precision */
       auto minimum_reliable_timestamp = now - listing_lag;
       if (remote_system_timestamp_precision == TARGET_SYSTEM_TIMESTAMP_PRECISION_SECONDS) {
-        std::chrono::floor<std::chrono::seconds>(minimum_reliable_timestamp);
+        minimum_reliable_timestamp = std::chrono::floor<std::chrono::seconds>(minimum_reliable_timestamp);

Review Comment:
   create a jira for it: https://issues.apache.org/jira/browse/MINIFICPP-2176



##########
extensions/sftp/processors/ListSFTP.cpp:
##########
@@ -535,9 +535,9 @@ void ListSFTP::listByTrackingTimestamps(
       /* Determine the minimum reliable timestamp based on precision */
       auto minimum_reliable_timestamp = now - listing_lag;
       if (remote_system_timestamp_precision == TARGET_SYSTEM_TIMESTAMP_PRECISION_SECONDS) {
-        std::chrono::floor<std::chrono::seconds>(minimum_reliable_timestamp);
+        minimum_reliable_timestamp = std::chrono::floor<std::chrono::seconds>(minimum_reliable_timestamp);

Review Comment:
   created a jira for it: https://issues.apache.org/jira/browse/MINIFICPP-2176



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org