You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/09/11 21:26:40 UTC
[GitHub] [tinkerpop] spmallette opened a new pull request #1328: TINKERPOP-2054 Added traversalstrategy support to Javascript
spmallette opened a new pull request #1328:
URL: https://github.com/apache/tinkerpop/pull/1328
https://issues.apache.org/jira/browse/TINKERPOP-2054
This was much easier to do than I thought. A shame it wasn't done earlier actually. The serialization was already done to support `withComputer()` so all I needed to do was add the strategy classes. Javascript users will be happy to get this - it's come up over and over again.
Builds with `mvn clean install -pl gremlin-javascript`:
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] krlawrence commented on pull request #1328: TINKERPOP-2054 Added traversalstrategy support to Javascript
Posted by GitBox <gi...@apache.org>.
krlawrence commented on pull request #1328:
URL: https://github.com/apache/tinkerpop/pull/1328#issuecomment-692061859
This is something I also get asked about a lot by Javascript Gremlin users.
I looked over the changes and LGTM
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1328: TINKERPOP-2054 Added traversalstrategy support to Javascript
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1328:
URL: https://github.com/apache/tinkerpop/pull/1328#issuecomment-695120686
Seeing a problem with the work I did here while doing TINKERPOP-2421 - I will fix it on that PR. The `TraversalStrategy` tests weren't doing what i thought they were. Sorry!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #1328: TINKERPOP-2054 Added traversalstrategy support to Javascript
Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1328:
URL: https://github.com/apache/tinkerpop/pull/1328
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org