You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "dhruba borthakur (Created) (JIRA)" <ji...@apache.org> on 2012/02/24 23:55:48 UTC

[jira] [Created] (HBASE-5473) Metrics does not push pread time

Metrics does not push pread time
--------------------------------

                 Key: HBASE-5473
                 URL: https://issues.apache.org/jira/browse/HBASE-5473
             Project: HBase
          Issue Type: Bug
          Components: metrics
            Reporter: dhruba borthakur
            Priority: Minor


The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5473) Metrics does not push pread time

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HBASE-5473:
-------------------------------

    Attachment: D1947.1.patch

dhruba requested code review of "[jira] [HBASE-5473] Metrics does not push pread time".
Reviewers: sc, tedyu

  Metrics does not push pread time.

TEST PLAN
  All unit tests pass. Also deployed on my local test cluster.

REVISION DETAIL
  https://reviews.facebook.net/D1947

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/4119/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "dhruba borthakur (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222094#comment-13222094 ] 

dhruba borthakur commented on HBASE-5473:
-----------------------------------------

This is committed to trunk. can this be closed?
                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (HBASE-5473) Metrics does not push pread time

Posted by "Zhihong Yu (Reopened) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu reopened HBASE-5473:
-------------------------------


0.92 build #305 failed due to compilation error:
{code}
[ERROR] <https://builds.apache.org/job/HBase-0.92/ws/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java>:[313,10] cannot find symbol
[ERROR] symbol  : variable fsPreadLatency
[ERROR] location: class org.apache.hadoop.hbase.regionserver.metrics.RegionServerMetrics
{code}
                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.92.1, 0.94.0
>
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5473) Metrics does not push pread time

Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-5473:
-------------------------

       Resolution: Fixed
    Fix Version/s: 0.94.0
                   0.92.1
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Committed to 0.92 branch and to trunk. Thanks for the patch Dhruba.  One line change in metrics can't be responsible for test failures.
                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.92.1, 0.94.0
>
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216344#comment-13216344 ] 

Hudson commented on HBASE-5473:
-------------------------------

Integrated in HBase-TRUNK #2669 (See [https://builds.apache.org/job/HBase-TRUNK/2669/])
    HBASE-5473 Metrics does not push pread time (Revision 1293532)

     Result = SUCCESS
stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.92.1, 0.94.0
>
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216156#comment-13216156 ] 

Hadoop QA commented on HBASE-5473:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12515992/D1947.1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -133 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestRegionRebalancing
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1049//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1049//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1049//console

This message is automatically generated.
                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216087#comment-13216087 ] 

Phabricator commented on HBASE-5473:
------------------------------------

stack has accepted the revision "[jira] [HBASE-5473] Metrics does not push pread time".

  +1

REVISION DETAIL
  https://reviews.facebook.net/D1947

BRANCH
  svn

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HBASE-5473) Metrics does not push pread time

Posted by "stack (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-5473.
--------------------------

    Resolution: Fixed

Committed to trunk a while back.
                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222124#comment-13222124 ] 

Hudson commented on HBASE-5473:
-------------------------------

Integrated in HBase-0.92-security #96 (See [https://builds.apache.org/job/HBase-0.92-security/96/])
    HBASE-5473 Metrics does not push pread time; REVERT -- DOESN'T BELONG ON THIS BRANCH (Revision 1294197)
HBASE-5473 Metrics does not push pread time (Revision 1293531)

     Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Phabricator (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272577#comment-13272577 ] 

Phabricator commented on HBASE-5473:
------------------------------------

dhruba has closed the revision "[jira] [HBASE-5473] Metrics does not push pread time".

REVISION DETAIL
  https://reviews.facebook.net/D1947

To: sc, tedyu, stack, dhruba
Cc: JIRA

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5473) Metrics does not push pread time

Posted by "dhruba borthakur (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated HBASE-5473:
------------------------------------

    Assignee: dhruba borthakur
      Status: Patch Available  (was: Open)
    
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5473) Metrics does not push pread time

Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-5473:
-------------------------

    Status: Open  (was: Patch Available)
    
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5473) Metrics does not push pread time

Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-5473:
-------------------------

    Attachment: D1947.patch

Retrying patch
                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217345#comment-13217345 ] 

Hudson commented on HBASE-5473:
-------------------------------

Integrated in HBase-0.92 #306 (See [https://builds.apache.org/job/HBase-0.92/306/])
    HBASE-5473 Metrics does not push pread time; REVERT -- DOESN'T BELONG ON THIS BRANCH (Revision 1294197)

     Result = SUCCESS
stack : 
Files : 
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216077#comment-13216077 ] 

Phabricator commented on HBASE-5473:
------------------------------------

sc has commented on the revision "[jira] [HBASE-5473] Metrics does not push pread time".

  looks good to me

REVISION DETAIL
  https://reviews.facebook.net/D1947

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216084#comment-13216084 ] 

Phabricator commented on HBASE-5473:
------------------------------------

stack has accepted the revision "[jira] [HBASE-5473] Metrics does not push pread time".

  +1

REVISION DETAIL
  https://reviews.facebook.net/D1947

BRANCH
  svn

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216076#comment-13216076 ] 

Phabricator commented on HBASE-5473:
------------------------------------

sc has commented on the revision "[jira] [HBASE-5473] Metrics does not push pread time".

  looks good to me

REVISION DETAIL
  https://reviews.facebook.net/D1947

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216075#comment-13216075 ] 

Phabricator commented on HBASE-5473:
------------------------------------

sc has commented on the revision "[jira] [HBASE-5473] Metrics does not push pread time".

  looks good to me

REVISION DETAIL
  https://reviews.facebook.net/D1947

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5473) Metrics does not push pread time

Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-5473:
-------------------------

    Status: Patch Available  (was: Open)
    
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216231#comment-13216231 ] 

Hadoop QA commented on HBASE-5473:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12516006/D1947.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -131 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
                  org.apache.hadoop.hbase.io.hfile.TestLruBlockCache
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.client.TestFromClientSide
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1050//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1050//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1050//console

This message is automatically generated.
                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216315#comment-13216315 ] 

Hudson commented on HBASE-5473:
-------------------------------

Integrated in HBase-0.92 #305 (See [https://builds.apache.org/job/HBase-0.92/305/])
    HBASE-5473 Metrics does not push pread time (Revision 1293531)

     Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.92.1, 0.94.0
>
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5473) Metrics does not push pread time

Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-5473:
-------------------------

    Fix Version/s:     (was: 0.92.1)

Reverted from branch.  It doesn't belong there (broke build).  Left it on trunk.
                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216086#comment-13216086 ] 

Phabricator commented on HBASE-5473:
------------------------------------

stack has accepted the revision "[jira] [HBASE-5473] Metrics does not push pread time".

  +1

REVISION DETAIL
  https://reviews.facebook.net/D1947

BRANCH
  svn

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "dhruba borthakur (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216329#comment-13216329 ] 

dhruba borthakur commented on HBASE-5473:
-----------------------------------------

I can compile and run unit tests on trunk just fine. I think HadoopQA ran into trouble while merging the patch. Bur svn trunk looks fine.
                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.92.1, 0.94.0
>
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216327#comment-13216327 ] 

Hudson commented on HBASE-5473:
-------------------------------

Integrated in HBase-TRUNK-security #122 (See [https://builds.apache.org/job/HBase-TRUNK-security/122/])
    HBASE-5473 Metrics does not push pread time (Revision 1293532)

     Result = FAILURE
stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.92.1, 0.94.0
>
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch, D1947.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5473) Metrics does not push pread time

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216085#comment-13216085 ] 

Phabricator commented on HBASE-5473:
------------------------------------

stack has accepted the revision "[jira] [HBASE-5473] Metrics does not push pread time".

  +1

REVISION DETAIL
  https://reviews.facebook.net/D1947

BRANCH
  svn

                
> Metrics does not push pread time
> --------------------------------
>
>                 Key: HBASE-5473
>                 URL: https://issues.apache.org/jira/browse/HBASE-5473
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: D1947.1.patch, D1947.1.patch, D1947.1.patch
>
>
> The RegionServerMetrics is not pushing the pread times to the MetricsRecord

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira