You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/15 13:08:22 UTC
[GitHub] [spark] LuciferYang opened a new pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
LuciferYang opened a new pull request #29760:
URL: https://github.com/apache/spark/pull/29760
### What changes were proposed in this pull request?
This pr fix failed cases in sql hive module in Scala 2.13 as follow:
- HiveSchemaInferenceSuite (1 FAILED -> PASS)
- HiveSparkSubmitSuite (1 FAILED-> PASS)
- StatisticsSuite (1 FAILED-> PASS)
- HiveDDLSuite (1 FAILED-> PASS)
After this patch all test passed in sql hive module in Scala 2.13.
### Why are the changes needed?
We need to support a Scala 2.13 build.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
- Scala 2.12: Pass the Jenkins or GitHub Action
- Scala 2.13: All tests passed.
Do the following:
```
dev/change-scala-version.sh 2.13
mvn clean install -DskipTests -pl sql/hive -am -Pscala-2.13 -Phive
mvn clean test -pl sql/hive -Pscala-2.13 -Phive
```
**Before**
```
Tests: succeeded 3662, failed 4, canceled 0, ignored 601, pending 0
*** 4 TESTS FAILED ***
```
**After**
```
Tests: succeeded 3666, failed 0, canceled 0, ignored 601, pending 0
All tests passed.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-693129232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692705981
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #29760:
URL: https://github.com/apache/spark/pull/29760#discussion_r488681106
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSchemaInferenceSuite.scala
##########
@@ -129,7 +129,8 @@ class HiveSchemaInferenceSuite
// properties out).
assert(!externalCatalog.getTable(DATABASE, TEST_TABLE_NAME).schemaPreservesCase)
val rawTable = client.getTable(DATABASE, TEST_TABLE_NAME)
- assert(rawTable.properties.filterKeys(_.startsWith(DATASOURCE_SCHEMA_PREFIX)) == Map.empty)
+ assert(
Review comment:
Can we just check isEmpty?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692710009
cc @srowen , this pr fix all failed test cases in `sql/hive` module. In this patch add `test-2.13.jar` to `/Users/yangjie/SourceCode/git/spark-mine/sql/hive/src/test/resources/regression-test-SPARK-8489` path, the `test-2.13.jar` not a copy of `test-2.12.jar`, I try to generate `test-2.13` as https://github.com/apache/spark/pull/22308 but failed because there is no spark 3.1.0-SNAPSHOT in maven repository, and I generate it as follow:
1. create a `test` module in spark source
2. copy `Main.scala` and `MyCoolClass.scala` to `src/main/scala` dir of `test` module
3. create a `pom.xml` use spark base `pom.xml` as parent pom and add dependency
```
<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-sql_${scala.binary.version}</artifactId>
<version>${project.version}</version>
</dependency>
```
4. mvn build `test` module with -am and rename `original-test-2.13-3.1.0-SNAPSHOT.jar` to `test-2.13.jar`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692726424
Jenkins test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-693162213
**[Test build #128732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128732/testReport)** for PR 29760 at commit [`ce5c81b`](https://github.com/apache/spark/commit/ce5c81b29a45b4c70d20cdf8114d49754ab59506).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-693129232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-693162725
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692730860
**[Test build #128713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128713/testReport)** for PR 29760 at commit [`f0d5880`](https://github.com/apache/spark/commit/f0d5880b750669a8d293b9ad29d4b4d879041fb5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #29760:
URL: https://github.com/apache/spark/pull/29760#discussion_r489120302
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSchemaInferenceSuite.scala
##########
@@ -129,7 +129,8 @@ class HiveSchemaInferenceSuite
// properties out).
assert(!externalCatalog.getTable(DATABASE, TEST_TABLE_NAME).schemaPreservesCase)
val rawTable = client.getTable(DATABASE, TEST_TABLE_NAME)
- assert(rawTable.properties.filterKeys(_.startsWith(DATASOURCE_SCHEMA_PREFIX)) == Map.empty)
+ assert(
Review comment:
Address ce5c81b fix this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #29760:
URL: https://github.com/apache/spark/pull/29760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-693162725
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692800252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #29760:
URL: https://github.com/apache/spark/pull/29760#discussion_r489141885
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSchemaInferenceSuite.scala
##########
@@ -129,7 +129,8 @@ class HiveSchemaInferenceSuite
// properties out).
assert(!externalCatalog.getTable(DATABASE, TEST_TABLE_NAME).schemaPreservesCase)
val rawTable = client.getTable(DATABASE, TEST_TABLE_NAME)
- assert(rawTable.properties.filterKeys(_.startsWith(DATASOURCE_SCHEMA_PREFIX)) == Map.empty)
+ assert(
Review comment:
check isEmpty looks simpler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692710009
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692710009
cc @srowen , this pr fix all failed test cases in `sql/hive` module.
In this patch add `test-2.13.jar` to `sql/hive/src/test/resources/regression-test-SPARK-8489` dir, the `test-2.13.jar` not a copy of `test-2.12.jar`, I try to generate `test-2.13` as https://github.com/apache/spark/pull/22308 but failed because there is no spark 3.1.0-SNAPSHOT deploy in maven repository, and I generate it as follow:
1. create a `test` module in spark source
2. copy `Main.scala` and `MyCoolClass.scala` to `src/main/scala` dir of `test` module
3. create a `pom.xml` use spark base `pom.xml` as parent pom and add dependency
```
<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-sql_${scala.binary.version}</artifactId>
<version>${project.version}</version>
</dependency>
```
4. mvn build `test` module with -am and rename `original-test-2.13-3.1.0-SNAPSHOT.jar` to `test-2.13.jar`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692705981
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692799026
**[Test build #128712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128712/testReport)** for PR 29760 at commit [`f0d5880`](https://github.com/apache/spark/commit/f0d5880b750669a8d293b9ad29d4b4d879041fb5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692705159
**[Test build #128712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128712/testReport)** for PR 29760 at commit [`f0d5880`](https://github.com/apache/spark/commit/f0d5880b750669a8d293b9ad29d4b4d879041fb5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692814798
**[Test build #128713 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128713/testReport)** for PR 29760 at commit [`f0d5880`](https://github.com/apache/spark/commit/f0d5880b750669a8d293b9ad29d4b4d879041fb5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-693128841
**[Test build #128732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128732/testReport)** for PR 29760 at commit [`ce5c81b`](https://github.com/apache/spark/commit/ce5c81b29a45b4c70d20cdf8114d49754ab59506).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692705159
**[Test build #128712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128712/testReport)** for PR 29760 at commit [`f0d5880`](https://github.com/apache/spark/commit/f0d5880b750669a8d293b9ad29d4b4d879041fb5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692727423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-693589583
Merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692727423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692815790
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692730860
**[Test build #128713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128713/testReport)** for PR 29760 at commit [`f0d5880`](https://github.com/apache/spark/commit/f0d5880b750669a8d293b9ad29d4b4d879041fb5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692800252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-693128841
**[Test build #128732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128732/testReport)** for PR 29760 at commit [`ce5c81b`](https://github.com/apache/spark/commit/ce5c81b29a45b4c70d20cdf8114d49754ab59506).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692710009
cc @srowen , this pr fix all failed test cases in `sql/hive` module.
In this patch add `test-2.13.jar` to `/Users/yangjie/SourceCode/git/spark-mine/sql/hive/src/test/resources/regression-test-SPARK-8489` path, the `test-2.13.jar` not a copy of `test-2.12.jar`, I try to generate `test-2.13` as https://github.com/apache/spark/pull/22308 but failed because there is no spark 3.1.0-SNAPSHOT in maven repository, and I generate it as follow:
1. create a `test` module in spark source
2. copy `Main.scala` and `MyCoolClass.scala` to `src/main/scala` dir of `test` module
3. create a `pom.xml` use spark base `pom.xml` as parent pom and add dependency
```
<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-sql_${scala.binary.version}</artifactId>
<version>${project.version}</version>
</dependency>
```
4. mvn build `test` module with -am and rename `original-test-2.13-3.1.0-SNAPSHOT.jar` to `test-2.13.jar`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29760: [SPARK-32890][SQL] Pass all `sql/hive` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29760:
URL: https://github.com/apache/spark/pull/29760#issuecomment-692815790
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org