You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/01/20 07:15:53 UTC

[GitHub] peng-yongsheng opened a new pull request #2184: Fixed the inventory register lock invalid bug.

peng-yongsheng opened a new pull request #2184: Fixed the inventory register lock invalid bug.
URL: https://github.com/apache/incubator-skywalking/pull/2184
 
 
   Merge commit into master.
   
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [X] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   #2183 
   ___
   
   Although the current inventory register has a locking mechanism, but the timeout only one second. The other collector will get lock when current register execute more than one second.
   
   1. Add sequence column into register lock index.
   2. Increase the sequence value in register lock index instead of get the max id from inventory index.
   3. Reduce the number of registration updates. (Let the inventory combine method return boolean value which represent the combine method is really execute. )
   4. Extend timeout to 10 minutes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services