You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/01/28 13:41:02 UTC
Review Request 42909: LENS-920 : Fix reading and writing for json
input and output in all API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42909/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-920
https://issues.apache.org/jira/browse/LENS-920
Repository: lens
Description
-------
Changes include :
- Moving to latest jersey, grizzly and jaxb versions
- Enable Moxy json features explicitly
- Fixing a bug in LensJerseyTest for starting tests on random port
- Annotate all enum classes with @XmlEnum
- Write JAXB adapter for UUID
- In Json the name of the field as "type" is reserved. Had to change all the occurrances.
- Fix signatures wrt LensAPIResult<? extends QuerySubmitResult>
- Update all tests to run against both XML and JSON marshalling/unmarshalling
- JSON requires all JAXBElement classes to be written as GenericEntity. Fixed TestMetastoreService wrt the same.
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d
lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6
lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6
lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d
lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d
lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184
lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java 756287e
lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java 28d9710
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e
lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java d0c21a7
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java aa4dc13
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java c124a38
lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c
lens-api/src/main/resources/cube-0.1.xsd d195b08
lens-client/pom.xml 5f2f3a9
lens-client/src/main/java/org/apache/lens/client/LensConnection.java 30a7e2c
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd
lens-server/src/main/java/org/apache/lens/server/MoxyJsonConfigurationContextResolver.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/error/LensExceptionMapper.java 1bb65ca
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java fc67df1
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70323d3
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 520c698
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java fb937c6
lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 9db034a
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java bb4cfd2
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 5c247be
lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java a499968
lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java faaf172
lens-server/src/main/resources/lensserver-default.xml cac641a
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java 94dd394
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 877200f
lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 5301162
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 4b25fd0
lens-server/src/test/java/org/apache/lens/server/common/TestDataUtils.java 0400519
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 85580da
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 515ac13
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java ab42a3d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 3facded
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 30d1e34
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
pom.xml 746204e
Diff: https://reviews.apache.org/r/42909/diff/
Testing
-------
All server tests are passing.
Pending:
Client tests
Updating examples
Thanks,
Amareshwari Sriramadasu
Re: Review Request 42909: LENS-920 : Fix reading and writing for json
input and output in all API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/cube-0.1.xsd, line 692
> > <https://reviews.apache.org/r/42909/diff/1/?file=1224917#file1224917line692>
> >
> > Seems there are multiple typos.
Not a typo. Field name "type" is reserved in JSON. So, used typ. Any other suggestions?
> On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/APIResult.java, line 38
> > <https://reviews.apache.org/r/42909/diff/1/?file=1224903#file1224903line38>
> >
> > Removal necessary?
Yes. Was necessary for JSON unmarshalling.
> On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/Priority.java, line 36
> > <https://reviews.apache.org/r/42909/diff/1/?file=1224906#file1224906line36>
> >
> > Don't we require `@XmlEnumValue("HIGH")` etc on individual values?
I think not required, will remove from APIResult.Status also.
> On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java, lines 1246-1247
> > <https://reviews.apache.org/r/42909/diff/1/?file=1224926#file1224926line1246>
> >
> > Changing the API?
Yes. Could not pass XDimensionTable in multi form data through json. and MultiFormData was not required here.
> On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote:
> > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java, line 90
> > <https://reviews.apache.org/r/42909/diff/1/?file=1224933#file1224933line90>
> >
> > Has that always been a bug? :o
Yes. Not failing with earlier grizzly versions.
> On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote:
> > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java, line 257
> > <https://reviews.apache.org/r/42909/diff/1/?file=1224933#file1224933line257>
> >
> > static?
Only used in subclasses.
> On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote:
> > pom.xml, lines 966-968
> > <https://reviews.apache.org/r/42909/diff/1/?file=1224949#file1224949line966>
> >
> > could probably look for other possible exclusins
All dependencies checked.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42909/#review116766
-----------------------------------------------------------
On Jan. 28, 2016, 12:40 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42909/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 12:40 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-920
> https://issues.apache.org/jira/browse/LENS-920
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Moving to latest jersey, grizzly and jaxb versions
> - Enable Moxy json features explicitly
> - Fixing a bug in LensJerseyTest for starting tests on random port
> - Annotate all enum classes with @XmlEnum
> - Write JAXB adapter for UUID
> - In Json the name of the field as "type" is reserved. Had to change all the occurrances.
> - Fix signatures wrt LensAPIResult<? extends QuerySubmitResult>
> - Update all tests to run against both XML and JSON marshalling/unmarshalling
> - JSON requires all JAXBElement classes to be written as GenericEntity. Fixed TestMetastoreService wrt the same.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d
> lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6
> lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6
> lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d
> lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d
> lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184
> lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java 756287e
> lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java 28d9710
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e
> lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java d0c21a7
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java aa4dc13
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java c124a38
> lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c
> lens-api/src/main/resources/cube-0.1.xsd d195b08
> lens-client/pom.xml 5f2f3a9
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java 30a7e2c
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd
> lens-server/src/main/java/org/apache/lens/server/MoxyJsonConfigurationContextResolver.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/error/LensExceptionMapper.java 1bb65ca
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java fc67df1
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70323d3
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 520c698
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java fb937c6
> lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 9db034a
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java bb4cfd2
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 5c247be
> lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java a499968
> lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java faaf172
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
> lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java 94dd394
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 877200f
> lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 5301162
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 4b25fd0
> lens-server/src/test/java/org/apache/lens/server/common/TestDataUtils.java 0400519
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 85580da
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 515ac13
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java ab42a3d
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 3facded
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 30d1e34
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> pom.xml 746204e
>
> Diff: https://reviews.apache.org/r/42909/diff/
>
>
> Testing
> -------
>
> All server tests are passing.
> Pending:
> Client tests
> Updating examples
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 42909: LENS-920 : Fix reading and writing for json
input and output in all API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java, line 70
> > <https://reviews.apache.org/r/42909/diff/1/?file=1224909#file1224909line70>
> >
> > Isn't there a way to specify the adapter once, instead of in every class?
> >
> > Something like http://stackoverflow.com/questions/6857166/jaxb-isnt-it-possible-to-use-an-xmladapter-without-xmljavatypeadapter
Not doing this as of now.
> On Jan. 28, 2016, 1:20 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/cube-0.1.xsd, line 692
> > <https://reviews.apache.org/r/42909/diff/1/?file=1224917#file1224917line692>
> >
> > Seems there are multiple typos.
>
> Amareshwari Sriramadasu wrote:
> Not a typo. Field name "type" is reserved in JSON. So, used typ. Any other suggestions?
>
> Rajat Khandelwal wrote:
> column_type here and corresponding `*_type` in other places?
Changed it to _type
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42909/#review116766
-----------------------------------------------------------
On Feb. 2, 2016, 7:08 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42909/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 7:08 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-920
> https://issues.apache.org/jira/browse/LENS-920
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Moving to latest jersey, grizzly and jaxb versions
> - Enable Moxy json features explicitly
> - Fixing a bug in LensJerseyTest for starting tests on random port
> - Annotate all enum classes with @XmlEnum
> - Write JAXB adapter for UUID
> - In Json the name of the field as "type" is reserved. Had to change all the occurrances. Changed the type in xsd to be "_type".
> - Fix signatures wrt LensAPIResult<? extends QuerySubmitResult>
> - Update all tests to run against both XML and JSON marshalling/unmarshalling
> - JSON requires all JAXBElement classes to be written as GenericEntity. Fixed TestMetastoreService wrt the same.
>
>
> Diffs
> -----
>
> lens-api/pom.xml 8aa2f67
> lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d
> lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6
> lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6
> lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d
> lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d
> lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184
> lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java 756287e
> lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java 28d9710
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e
> lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java d0c21a7
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java aa4dc13
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java c124a38
> lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c
> lens-api/src/main/java/org/apache/lens/api/util/MoxyJsonConfigurationContextResolver.java PRE-CREATION
> lens-api/src/main/resources/cube-0.1.xsd d195b08
> lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java 8647ac3
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/resources/cube_with_no_weight_facts.xml 13736b2
> lens-cli/src/test/resources/dim-local-storage-element.xml 6503261
> lens-cli/src/test/resources/dim_table.xml 3bc9600
> lens-cli/src/test/resources/dim_table2.xml 4c3f7d9
> lens-cli/src/test/resources/fact-local-storage-element.xml 6f30a1c
> lens-cli/src/test/resources/fact1.xml f6d1f9c
> lens-cli/src/test/resources/fact_without_weight.xml 8371b0b
> lens-cli/src/test/resources/lens-client-site.xml e500bda
> lens-cli/src/test/resources/logback.xml PRE-CREATION
> lens-cli/src/test/resources/sample-cube.xml e3b3284
> lens-cli/src/test/resources/test-detail.xml bb54354
> lens-cli/src/test/resources/test-dimension.xml 2fa47f1
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java 30a7e2c
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 4dec1a2
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 8de7708
> lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 1fbd358
> lens-examples/src/main/resources/city.xml 1a89a2a
> lens-examples/src/main/resources/city_subset.xml 18c7847
> lens-examples/src/main/resources/city_table.xml 27be305
> lens-examples/src/main/resources/customer.xml c6182a2
> lens-examples/src/main/resources/customer_table.xml af308c2
> lens-examples/src/main/resources/dim_table.xml 10c9ac0
> lens-examples/src/main/resources/dim_table2.xml e72f9c5
> lens-examples/src/main/resources/dim_table3.xml 7955426
> lens-examples/src/main/resources/dim_table4.xml 9de1cd7
> lens-examples/src/main/resources/fact1.xml c934a64
> lens-examples/src/main/resources/fact2.xml 3298fc1
> lens-examples/src/main/resources/product.xml bb91997
> lens-examples/src/main/resources/product_db_table.xml 867d37b
> lens-examples/src/main/resources/product_table.xml 303f3ad
> lens-examples/src/main/resources/rawfact.xml 8191eb2
> lens-examples/src/main/resources/sales-aggr-continuous-fact.xml 781a615
> lens-examples/src/main/resources/sales-aggr-fact1.xml 728c775
> lens-examples/src/main/resources/sales-aggr-fact2.xml 61edf64
> lens-examples/src/main/resources/sales-cube.xml e9e48ce
> lens-examples/src/main/resources/sales-raw-fact.xml 4c2d571
> lens-examples/src/main/resources/sample-cube.xml 3b5abea
> lens-examples/src/main/resources/sample-db-only-dimension.xml 2e8aa64
> lens-examples/src/main/resources/sample-dimension.xml 3c2589c
> lens-examples/src/main/resources/sample-dimension2.xml 9740507
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLApp.java e6e3c02
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java ef3d53e
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f6434da
> lens-server/pom.xml ba91e76
> lens-server/src/main/java/org/apache/lens/server/BaseApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 61eb37f
> lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 630b95e
> lens-server/src/main/java/org/apache/lens/server/error/LensExceptionMapper.java 1bb65ca
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java fc67df1
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70323d3
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 520c698
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java fb937c6
> lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 9db034a
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java bb4cfd2
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java e55ed13
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 5c247be
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java 0ea8544
> lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java a499968
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java c22a1aa
> lens-server/src/main/resources/lensserver-default.xml 881c159
> lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java 56a3b75
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
> lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java 94dd394
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4f9f4d2
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 877200f
> lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 5301162
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 4b25fd0
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java 8e22c7a
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 85580da
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 515ac13
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java ab42a3d
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 5d949d2
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 30d1e34
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java 7c6ce49
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> pom.xml 746204e
> src/site/apt/admin/config.apt 703abb3
>
> Diff: https://reviews.apache.org/r/42909/diff/
>
>
> Testing
> -------
>
> All tests passing.
> All examples passing.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 42909: LENS-920 : Fix reading and writing for json
input and output in all API
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Jan. 28, 2016, 6:50 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/cube-0.1.xsd, line 692
> > <https://reviews.apache.org/r/42909/diff/1/?file=1224917#file1224917line692>
> >
> > Seems there are multiple typos.
>
> Amareshwari Sriramadasu wrote:
> Not a typo. Field name "type" is reserved in JSON. So, used typ. Any other suggestions?
column_type here and corresponding `*_type` in other places?
> On Jan. 28, 2016, 6:50 p.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java, lines 1246-1247
> > <https://reviews.apache.org/r/42909/diff/1/?file=1224926#file1224926line1246>
> >
> > Changing the API?
>
> Amareshwari Sriramadasu wrote:
> Yes. Could not pass XDimensionTable in multi form data through json. and MultiFormData was not required here.
okay, let's change corresponding code in LensClient/LensMetadataClient too. And mark this incompatible.
> On Jan. 28, 2016, 6:50 p.m., Rajat Khandelwal wrote:
> > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java, line 257
> > <https://reviews.apache.org/r/42909/diff/1/?file=1224933#file1224933line257>
> >
> > static?
>
> Amareshwari Sriramadasu wrote:
> Only used in subclasses.
Yeah, but still it's not using any members/methods of LensJerseyTest. It's operating completely on the given arguments without any help from the enclosing class.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42909/#review116766
-----------------------------------------------------------
On Jan. 28, 2016, 6:10 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42909/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 6:10 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-920
> https://issues.apache.org/jira/browse/LENS-920
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Moving to latest jersey, grizzly and jaxb versions
> - Enable Moxy json features explicitly
> - Fixing a bug in LensJerseyTest for starting tests on random port
> - Annotate all enum classes with @XmlEnum
> - Write JAXB adapter for UUID
> - In Json the name of the field as "type" is reserved. Had to change all the occurrances.
> - Fix signatures wrt LensAPIResult<? extends QuerySubmitResult>
> - Update all tests to run against both XML and JSON marshalling/unmarshalling
> - JSON requires all JAXBElement classes to be written as GenericEntity. Fixed TestMetastoreService wrt the same.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d
> lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6
> lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6
> lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d
> lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d
> lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184
> lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java 756287e
> lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java 28d9710
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e
> lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java d0c21a7
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java aa4dc13
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java c124a38
> lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c
> lens-api/src/main/resources/cube-0.1.xsd d195b08
> lens-client/pom.xml 5f2f3a9
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java 30a7e2c
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd
> lens-server/src/main/java/org/apache/lens/server/MoxyJsonConfigurationContextResolver.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/error/LensExceptionMapper.java 1bb65ca
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java fc67df1
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70323d3
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 520c698
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java fb937c6
> lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 9db034a
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java bb4cfd2
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 5c247be
> lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java a499968
> lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java faaf172
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
> lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java 94dd394
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 877200f
> lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 5301162
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 4b25fd0
> lens-server/src/test/java/org/apache/lens/server/common/TestDataUtils.java 0400519
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 85580da
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 515ac13
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java ab42a3d
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 3facded
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 30d1e34
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> pom.xml 746204e
>
> Diff: https://reviews.apache.org/r/42909/diff/
>
>
> Testing
> -------
>
> All server tests are passing.
> Pending:
> Client tests
> Updating examples
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 42909: LENS-920 : Fix reading and writing for json
input and output in all API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42909/#review116766
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/APIResult.java (line 38)
<https://reviews.apache.org/r/42909/#comment177847>
Removal necessary?
lens-api/src/main/java/org/apache/lens/api/Priority.java (line 36)
<https://reviews.apache.org/r/42909/#comment177848>
Don't we require `@XmlEnumValue("HIGH")` etc on individual values?
lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java (line 30)
<https://reviews.apache.org/r/42909/#comment177849>
Same question as Priorities
lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java (line 70)
<https://reviews.apache.org/r/42909/#comment177850>
Isn't there a way to specify the adapter once, instead of in every class?
Something like http://stackoverflow.com/questions/6857166/jaxb-isnt-it-possible-to-use-an-xmladapter-without-xmljavatypeadapter
lens-api/src/main/resources/cube-0.1.xsd (line 228)
<https://reviews.apache.org/r/42909/#comment177851>
seems a typo.
lens-api/src/main/resources/cube-0.1.xsd (line 692)
<https://reviews.apache.org/r/42909/#comment177852>
Seems there are multiple typos.
lens-server/src/main/java/org/apache/lens/server/error/LensExceptionMapper.java (lines 35 - 37)
<https://reviews.apache.org/r/42909/#comment177853>
Shouldn't happen. Is it happening in any test case?
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (lines 755 - 764)
<https://reviews.apache.org/r/42909/#comment177854>
+1
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (lines 261 - 280)
<https://reviews.apache.org/r/42909/#comment177855>
Typos here too?
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (lines 795 - 810)
<https://reviews.apache.org/r/42909/#comment177856>
+1
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (lines 1242 - 1243)
<https://reviews.apache.org/r/42909/#comment177857>
Changing the API?
lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java (lines 49 - 50)
<https://reviews.apache.org/r/42909/#comment177858>
We should probably create a Base class of all `App` classes and add common classes there.
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java (line 90)
<https://reviews.apache.org/r/42909/#comment177860>
Has that always been a bug? :o
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java (line 257)
<https://reviews.apache.org/r/42909/#comment177861>
static?
pom.xml (lines 74 - 75)
<https://reviews.apache.org/r/42909/#comment177845>
+1
pom.xml (lines 966 - 968)
<https://reviews.apache.org/r/42909/#comment177846>
could probably look for other possible exclusins
- Rajat Khandelwal
On Jan. 28, 2016, 6:10 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42909/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 6:10 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-920
> https://issues.apache.org/jira/browse/LENS-920
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Moving to latest jersey, grizzly and jaxb versions
> - Enable Moxy json features explicitly
> - Fixing a bug in LensJerseyTest for starting tests on random port
> - Annotate all enum classes with @XmlEnum
> - Write JAXB adapter for UUID
> - In Json the name of the field as "type" is reserved. Had to change all the occurrances.
> - Fix signatures wrt LensAPIResult<? extends QuerySubmitResult>
> - Update all tests to run against both XML and JSON marshalling/unmarshalling
> - JSON requires all JAXBElement classes to be written as GenericEntity. Fixed TestMetastoreService wrt the same.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d
> lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6
> lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6
> lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d
> lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d
> lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184
> lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java 756287e
> lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java 28d9710
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e
> lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java d0c21a7
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java aa4dc13
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java c124a38
> lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c
> lens-api/src/main/resources/cube-0.1.xsd d195b08
> lens-client/pom.xml 5f2f3a9
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java 30a7e2c
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd
> lens-server/src/main/java/org/apache/lens/server/MoxyJsonConfigurationContextResolver.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/error/LensExceptionMapper.java 1bb65ca
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java fc67df1
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70323d3
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 520c698
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java fb937c6
> lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 9db034a
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java bb4cfd2
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 5c247be
> lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java a499968
> lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java faaf172
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
> lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java 94dd394
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 877200f
> lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 5301162
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 4b25fd0
> lens-server/src/test/java/org/apache/lens/server/common/TestDataUtils.java 0400519
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 85580da
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 515ac13
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java ab42a3d
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 3facded
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 30d1e34
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> pom.xml 746204e
>
> Diff: https://reviews.apache.org/r/42909/diff/
>
>
> Testing
> -------
>
> All server tests are passing.
> Pending:
> Client tests
> Updating examples
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 42909: LENS-920 : Fix reading and writing for json
input and output in all API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42909/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 12:08 p.m.)
Review request for lens.
Bugs: LENS-920
https://issues.apache.org/jira/browse/LENS-920
Repository: lens
Description
-------
Changes include :
- Moving to latest jersey, grizzly and jaxb versions
- Enable Moxy json features explicitly
- Fixing a bug in LensJerseyTest for starting tests on random port
- Annotate all enum classes with @XmlEnum
- Write JAXB adapter for UUID
- In Json the name of the field as "type" is reserved. Had to change all the occurrances. Changed the type in xsd to be "_type".
- Fix signatures wrt LensAPIResult<? extends QuerySubmitResult>
- Update all tests to run against both XML and JSON marshalling/unmarshalling
- JSON requires all JAXBElement classes to be written as GenericEntity. Fixed TestMetastoreService wrt the same.
Diffs (updated)
-----
lens-api/pom.xml 8aa2f67
lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d
lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6
lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6
lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d
lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d
lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184
lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java 756287e
lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java 28d9710
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e
lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java d0c21a7
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java aa4dc13
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java c124a38
lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c
lens-api/src/main/java/org/apache/lens/api/util/MoxyJsonConfigurationContextResolver.java PRE-CREATION
lens-api/src/main/resources/cube-0.1.xsd d195b08
lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java 8647ac3
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
lens-cli/src/test/resources/cube_with_no_weight_facts.xml 13736b2
lens-cli/src/test/resources/dim-local-storage-element.xml 6503261
lens-cli/src/test/resources/dim_table.xml 3bc9600
lens-cli/src/test/resources/dim_table2.xml 4c3f7d9
lens-cli/src/test/resources/fact-local-storage-element.xml 6f30a1c
lens-cli/src/test/resources/fact1.xml f6d1f9c
lens-cli/src/test/resources/fact_without_weight.xml 8371b0b
lens-cli/src/test/resources/lens-client-site.xml e500bda
lens-cli/src/test/resources/logback.xml PRE-CREATION
lens-cli/src/test/resources/sample-cube.xml e3b3284
lens-cli/src/test/resources/test-detail.xml bb54354
lens-cli/src/test/resources/test-dimension.xml 2fa47f1
lens-client/src/main/java/org/apache/lens/client/LensConnection.java 30a7e2c
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 4dec1a2
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 8de7708
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 1fbd358
lens-examples/src/main/resources/city.xml 1a89a2a
lens-examples/src/main/resources/city_subset.xml 18c7847
lens-examples/src/main/resources/city_table.xml 27be305
lens-examples/src/main/resources/customer.xml c6182a2
lens-examples/src/main/resources/customer_table.xml af308c2
lens-examples/src/main/resources/dim_table.xml 10c9ac0
lens-examples/src/main/resources/dim_table2.xml e72f9c5
lens-examples/src/main/resources/dim_table3.xml 7955426
lens-examples/src/main/resources/dim_table4.xml 9de1cd7
lens-examples/src/main/resources/fact1.xml c934a64
lens-examples/src/main/resources/fact2.xml 3298fc1
lens-examples/src/main/resources/product.xml bb91997
lens-examples/src/main/resources/product_db_table.xml 867d37b
lens-examples/src/main/resources/product_table.xml 303f3ad
lens-examples/src/main/resources/rawfact.xml 8191eb2
lens-examples/src/main/resources/sales-aggr-continuous-fact.xml 781a615
lens-examples/src/main/resources/sales-aggr-fact1.xml 728c775
lens-examples/src/main/resources/sales-aggr-fact2.xml 61edf64
lens-examples/src/main/resources/sales-cube.xml e9e48ce
lens-examples/src/main/resources/sales-raw-fact.xml 4c2d571
lens-examples/src/main/resources/sample-cube.xml 3b5abea
lens-examples/src/main/resources/sample-db-only-dimension.xml 2e8aa64
lens-examples/src/main/resources/sample-dimension.xml 3c2589c
lens-examples/src/main/resources/sample-dimension2.xml 9740507
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLApp.java e6e3c02
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java ef3d53e
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f6434da
lens-server/pom.xml ba91e76
lens-server/src/main/java/org/apache/lens/server/BaseApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensServer.java 61eb37f
lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 630b95e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java fc67df1
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70323d3
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 520c698
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java fb937c6
lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 9db034a
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java bb4cfd2
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java e55ed13
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 5c247be
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java 0ea8544
lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java a499968
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java c22a1aa
lens-server/src/main/resources/lensserver-default.xml 881c159
lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java 56a3b75
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java 94dd394
lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4f9f4d2
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 877200f
lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 5301162
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 4b25fd0
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java 8e22c7a
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 85580da
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 515ac13
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java ab42a3d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java ef8c1aa
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 30d1e34
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java 7c6ce49
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
pom.xml 746204e
src/site/apt/admin/config.apt 703abb3
Diff: https://reviews.apache.org/r/42909/diff/
Testing
-------
---------------------
Successful queries 148 out of 148queries
Total time for running examples(in millis) :1421837
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.898s]
[INFO] Lens .............................................. SUCCESS [3.422s]
[INFO] Lens API .......................................... SUCCESS [28.191s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.373s]
[INFO] Lens Cube ......................................... SUCCESS [12:20.941s]
[INFO] Lens DB storage ................................... SUCCESS [22.056s]
[INFO] Lens Query Library ................................ SUCCESS [17.141s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:02.736s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [38.390s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.920s]
[INFO] Lens Server ....................................... SUCCESS [16:07.548s]
[INFO] Lens client ....................................... SUCCESS [40.876s]
[INFO] Lens CLI .......................................... SUCCESS [57.086s]
[INFO] Lens Examples ..................................... SUCCESS [10.229s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.752s]
[INFO] Lens Distribution ................................. SUCCESS [11.114s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:26.445s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
[INFO] Lens Regression ................................... SUCCESS [14.655s]
[INFO] Lens UI ........................................... SUCCESS [31.657s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:18.455s
[INFO] Finished at: Tue Feb 02 09:07:35 UTC 2016
[INFO] Final Memory: 178M/958M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 42909: LENS-920 : Fix reading and writing for json
input and output in all API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Feb. 2, 2016, 10 a.m., Rajat Khandelwal wrote:
> > lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLApp.java, line 34
> > <https://reviews.apache.org/r/42909/diff/5/?file=1229311#file1229311line34>
> >
> > not extending from BaseApp?
ml-lib does not have compile time dependency on lens-server
> On Feb. 2, 2016, 10 a.m., Rajat Khandelwal wrote:
> > lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java, line 75
> > <https://reviews.apache.org/r/42909/diff/5/?file=1229337#file1229337line75>
> >
> > Did you mean
> > ```
> > return new FormDataBodyPart(FormDataContentDisposition.name("username").build(), value,
> > mt)
> >
> > ``` ?
> >
> > Seems mt is ignored.
> >
> >
> > And if it's supposed to be used, `getFormDataBodyPart` can be easily used.
For String fields, mt is not required.
> On Feb. 2, 2016, 10 a.m., Rajat Khandelwal wrote:
> > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java, line 212
> > <https://reviews.apache.org/r/42909/diff/5/?file=1229347#file1229347line212>
> >
> > Suggestion: I see a way to minimize changes scattering over files.
> >
> > static functions like `dropTable` now have one extra argument, so all the classes that use this are passing `defaultMT`, scattering the changes.
> >
> > `LensServerTestUtil` can have one more `dropTable` method with old signature where `defaultMT` is automatically passed. This will minimize number of files affected by the change.
> >
> > by using `defaultMT` everywhere we're violating separation of concerns.
All the utils methods are updated to take MediaType as the argument. But for tests that do not require testing with both types, we are passing defaultMT.
> On Feb. 2, 2016, 10 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java, line 73
> > <https://reviews.apache.org/r/42909/diff/5/?file=1229266#file1229266line73>
> >
> > I believe we can keep this as `type` and add an annotation `@XmlAttribute(name = "_type", required = true)`
This field is not used much, doing it as explicit costType should be fine.
> On Feb. 2, 2016, 10 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, line 759
> > <https://reviews.apache.org/r/42909/diff/5/?file=1229318#file1229318line759>
> >
> > shall we rename this to `checkDimTableStorage`?
Updated
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42909/#review117385
-----------------------------------------------------------
On Feb. 2, 2016, 9:10 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42909/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 9:10 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-920
> https://issues.apache.org/jira/browse/LENS-920
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Moving to latest jersey, grizzly and jaxb versions
> - Enable Moxy json features explicitly
> - Fixing a bug in LensJerseyTest for starting tests on random port
> - Annotate all enum classes with @XmlEnum
> - Write JAXB adapter for UUID
> - In Json the name of the field as "type" is reserved. Had to change all the occurrances. Changed the type in xsd to be "_type".
> - Fix signatures wrt LensAPIResult<? extends QuerySubmitResult>
> - Update all tests to run against both XML and JSON marshalling/unmarshalling
> - JSON requires all JAXBElement classes to be written as GenericEntity. Fixed TestMetastoreService wrt the same.
>
>
> Diffs
> -----
>
> lens-api/pom.xml 8aa2f67
> lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d
> lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6
> lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6
> lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d
> lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d
> lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184
> lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java 756287e
> lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java 28d9710
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e
> lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java d0c21a7
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java aa4dc13
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java c124a38
> lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c
> lens-api/src/main/java/org/apache/lens/api/util/MoxyJsonConfigurationContextResolver.java PRE-CREATION
> lens-api/src/main/resources/cube-0.1.xsd d195b08
> lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java 8647ac3
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/resources/cube_with_no_weight_facts.xml 13736b2
> lens-cli/src/test/resources/dim-local-storage-element.xml 6503261
> lens-cli/src/test/resources/dim_table.xml 3bc9600
> lens-cli/src/test/resources/dim_table2.xml 4c3f7d9
> lens-cli/src/test/resources/fact-local-storage-element.xml 6f30a1c
> lens-cli/src/test/resources/fact1.xml f6d1f9c
> lens-cli/src/test/resources/fact_without_weight.xml 8371b0b
> lens-cli/src/test/resources/lens-client-site.xml e500bda
> lens-cli/src/test/resources/logback.xml PRE-CREATION
> lens-cli/src/test/resources/sample-cube.xml e3b3284
> lens-cli/src/test/resources/test-detail.xml bb54354
> lens-cli/src/test/resources/test-dimension.xml 2fa47f1
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java 30a7e2c
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 4dec1a2
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 8de7708
> lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 1fbd358
> lens-examples/src/main/resources/city.xml 1a89a2a
> lens-examples/src/main/resources/city_subset.xml 18c7847
> lens-examples/src/main/resources/city_table.xml 27be305
> lens-examples/src/main/resources/customer.xml c6182a2
> lens-examples/src/main/resources/customer_table.xml af308c2
> lens-examples/src/main/resources/dim_table.xml 10c9ac0
> lens-examples/src/main/resources/dim_table2.xml e72f9c5
> lens-examples/src/main/resources/dim_table3.xml 7955426
> lens-examples/src/main/resources/dim_table4.xml 9de1cd7
> lens-examples/src/main/resources/fact1.xml c934a64
> lens-examples/src/main/resources/fact2.xml 3298fc1
> lens-examples/src/main/resources/product.xml bb91997
> lens-examples/src/main/resources/product_db_table.xml 867d37b
> lens-examples/src/main/resources/product_table.xml 303f3ad
> lens-examples/src/main/resources/rawfact.xml 8191eb2
> lens-examples/src/main/resources/sales-aggr-continuous-fact.xml 781a615
> lens-examples/src/main/resources/sales-aggr-fact1.xml 728c775
> lens-examples/src/main/resources/sales-aggr-fact2.xml 61edf64
> lens-examples/src/main/resources/sales-cube.xml e9e48ce
> lens-examples/src/main/resources/sales-raw-fact.xml 4c2d571
> lens-examples/src/main/resources/sample-cube.xml 3b5abea
> lens-examples/src/main/resources/sample-db-only-dimension.xml 2e8aa64
> lens-examples/src/main/resources/sample-dimension.xml 3c2589c
> lens-examples/src/main/resources/sample-dimension2.xml 9740507
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLApp.java e6e3c02
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java ef3d53e
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f6434da
> lens-server/pom.xml ba91e76
> lens-server/src/main/java/org/apache/lens/server/BaseApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 61eb37f
> lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 630b95e
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java fc67df1
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70323d3
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 520c698
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java fb937c6
> lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 9db034a
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java bb4cfd2
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java e55ed13
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 5c247be
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java 0ea8544
> lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java a499968
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java c22a1aa
> lens-server/src/main/resources/lensserver-default.xml 881c159
> lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java 56a3b75
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
> lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java 94dd394
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4f9f4d2
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 877200f
> lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 5301162
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 4b25fd0
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java 8e22c7a
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 85580da
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 515ac13
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java ab42a3d
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 5d949d2
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 30d1e34
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java 7c6ce49
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> pom.xml 746204e
> src/site/apt/admin/config.apt 703abb3
>
> Diff: https://reviews.apache.org/r/42909/diff/
>
>
> Testing
> -------
>
> ---------------------
> Successful queries 148 out of 148queries
> Total time for running examples(in millis) :1421837
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.898s]
> [INFO] Lens .............................................. SUCCESS [3.422s]
> [INFO] Lens API .......................................... SUCCESS [28.191s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.373s]
> [INFO] Lens Cube ......................................... SUCCESS [12:20.941s]
> [INFO] Lens DB storage ................................... SUCCESS [22.056s]
> [INFO] Lens Query Library ................................ SUCCESS [17.141s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:02.736s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.390s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.920s]
> [INFO] Lens Server ....................................... SUCCESS [16:07.548s]
> [INFO] Lens client ....................................... SUCCESS [40.876s]
> [INFO] Lens CLI .......................................... SUCCESS [57.086s]
> [INFO] Lens Examples ..................................... SUCCESS [10.229s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.752s]
> [INFO] Lens Distribution ................................. SUCCESS [11.114s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:26.445s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
> [INFO] Lens Regression ................................... SUCCESS [14.655s]
> [INFO] Lens UI ........................................... SUCCESS [31.657s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:18.455s
> [INFO] Finished at: Tue Feb 02 09:07:35 UTC 2016
> [INFO] Final Memory: 178M/958M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 42909: LENS-920 : Fix reading and writing for json
input and output in all API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42909/#review117385
-----------------------------------------------------------
Fix it, then Ship it!
lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java (lines 29 - 31)
<https://reviews.apache.org/r/42909/#comment178540>
I see that Querystatus.Status has two annotations: XmlType and XmlEnum. This one has XmlRootElement and XmlEnum.
Confused as to why the difference is there.
lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java (line 73)
<https://reviews.apache.org/r/42909/#comment178541>
I believe we can keep this as `type` and add an annotation `@XmlAttribute(name = "_type", required = true)`
lens-cli/src/test/resources/lens-client-site.xml (lines 1 - 21)
<https://reviews.apache.org/r/42909/#comment178542>
+1
lens-client/src/main/java/org/apache/lens/client/LensStatement.java (line 192)
<https://reviews.apache.org/r/42909/#comment178543>
+1
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLApp.java (line 34)
<https://reviews.apache.org/r/42909/#comment178545>
not extending from BaseApp?
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 759)
<https://reviews.apache.org/r/42909/#comment178546>
shall we rename this to `checkDimTableStorage`?
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (line 853)
<https://reviews.apache.org/r/42909/#comment178549>
+1, verified metadata client for corresponding changes.
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (line 1242)
<https://reviews.apache.org/r/42909/#comment178548>
+1, since all other create methods are expecting a query param.
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java (line 258)
<https://reviews.apache.org/r/42909/#comment178550>
can be static, but since all the users are sub-classes, it's okay I guess.
lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java (line 71)
<https://reviews.apache.org/r/42909/#comment178551>
Did you mean
```
return new FormDataBodyPart(FormDataContentDisposition.name("username").build(), value,
mt)
``` ?
Seems mt is ignored.
And if it's supposed to be used, `getFormDataBodyPart` can be easily used.
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java (line 121)
<https://reviews.apache.org/r/42909/#comment178552>
I think all the methods have added `MediaType` as last argument, `getEntityForString` should also follow the same for consistency/readability.
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java
<https://reviews.apache.org/r/42909/#comment178553>
+1
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 193)
<https://reviews.apache.org/r/42909/#comment178554>
Suggestion: I see a way to minimize changes scattering over files.
static functions like `dropTable` now have one extra argument, so all the classes that use this are passing `defaultMT`, scattering the changes.
`LensServerTestUtil` can have one more `dropTable` method with old signature where `defaultMT` is automatically passed. This will minimize number of files affected by the change.
by using `defaultMT` everywhere we're violating separation of concerns.
- Rajat Khandelwal
On Feb. 2, 2016, 2:40 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42909/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 2:40 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-920
> https://issues.apache.org/jira/browse/LENS-920
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Moving to latest jersey, grizzly and jaxb versions
> - Enable Moxy json features explicitly
> - Fixing a bug in LensJerseyTest for starting tests on random port
> - Annotate all enum classes with @XmlEnum
> - Write JAXB adapter for UUID
> - In Json the name of the field as "type" is reserved. Had to change all the occurrances. Changed the type in xsd to be "_type".
> - Fix signatures wrt LensAPIResult<? extends QuerySubmitResult>
> - Update all tests to run against both XML and JSON marshalling/unmarshalling
> - JSON requires all JAXBElement classes to be written as GenericEntity. Fixed TestMetastoreService wrt the same.
>
>
> Diffs
> -----
>
> lens-api/pom.xml 8aa2f67
> lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d
> lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6
> lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6
> lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d
> lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d
> lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184
> lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java 756287e
> lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java 28d9710
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e
> lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java d0c21a7
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java aa4dc13
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java c124a38
> lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c
> lens-api/src/main/java/org/apache/lens/api/util/MoxyJsonConfigurationContextResolver.java PRE-CREATION
> lens-api/src/main/resources/cube-0.1.xsd d195b08
> lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java 8647ac3
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
> lens-cli/src/test/resources/cube_with_no_weight_facts.xml 13736b2
> lens-cli/src/test/resources/dim-local-storage-element.xml 6503261
> lens-cli/src/test/resources/dim_table.xml 3bc9600
> lens-cli/src/test/resources/dim_table2.xml 4c3f7d9
> lens-cli/src/test/resources/fact-local-storage-element.xml 6f30a1c
> lens-cli/src/test/resources/fact1.xml f6d1f9c
> lens-cli/src/test/resources/fact_without_weight.xml 8371b0b
> lens-cli/src/test/resources/lens-client-site.xml e500bda
> lens-cli/src/test/resources/logback.xml PRE-CREATION
> lens-cli/src/test/resources/sample-cube.xml e3b3284
> lens-cli/src/test/resources/test-detail.xml bb54354
> lens-cli/src/test/resources/test-dimension.xml 2fa47f1
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java 30a7e2c
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 4dec1a2
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 8de7708
> lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 1fbd358
> lens-examples/src/main/resources/city.xml 1a89a2a
> lens-examples/src/main/resources/city_subset.xml 18c7847
> lens-examples/src/main/resources/city_table.xml 27be305
> lens-examples/src/main/resources/customer.xml c6182a2
> lens-examples/src/main/resources/customer_table.xml af308c2
> lens-examples/src/main/resources/dim_table.xml 10c9ac0
> lens-examples/src/main/resources/dim_table2.xml e72f9c5
> lens-examples/src/main/resources/dim_table3.xml 7955426
> lens-examples/src/main/resources/dim_table4.xml 9de1cd7
> lens-examples/src/main/resources/fact1.xml c934a64
> lens-examples/src/main/resources/fact2.xml 3298fc1
> lens-examples/src/main/resources/product.xml bb91997
> lens-examples/src/main/resources/product_db_table.xml 867d37b
> lens-examples/src/main/resources/product_table.xml 303f3ad
> lens-examples/src/main/resources/rawfact.xml 8191eb2
> lens-examples/src/main/resources/sales-aggr-continuous-fact.xml 781a615
> lens-examples/src/main/resources/sales-aggr-fact1.xml 728c775
> lens-examples/src/main/resources/sales-aggr-fact2.xml 61edf64
> lens-examples/src/main/resources/sales-cube.xml e9e48ce
> lens-examples/src/main/resources/sales-raw-fact.xml 4c2d571
> lens-examples/src/main/resources/sample-cube.xml 3b5abea
> lens-examples/src/main/resources/sample-db-only-dimension.xml 2e8aa64
> lens-examples/src/main/resources/sample-dimension.xml 3c2589c
> lens-examples/src/main/resources/sample-dimension2.xml 9740507
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLApp.java e6e3c02
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java ef3d53e
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f6434da
> lens-server/pom.xml ba91e76
> lens-server/src/main/java/org/apache/lens/server/BaseApp.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 61eb37f
> lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 630b95e
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java fc67df1
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70323d3
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 520c698
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java fb937c6
> lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 9db034a
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java bb4cfd2
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java e55ed13
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 5c247be
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java 0ea8544
> lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java a499968
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
> lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java c22a1aa
> lens-server/src/main/resources/lensserver-default.xml 881c159
> lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java 56a3b75
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
> lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java 94dd394
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4f9f4d2
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 877200f
> lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 5301162
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 4b25fd0
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java 8e22c7a
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 85580da
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 515ac13
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java ab42a3d
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 5d949d2
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 30d1e34
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java 7c6ce49
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
> pom.xml 746204e
> src/site/apt/admin/config.apt 703abb3
>
> Diff: https://reviews.apache.org/r/42909/diff/
>
>
> Testing
> -------
>
> ---------------------
> Successful queries 148 out of 148queries
> Total time for running examples(in millis) :1421837
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.898s]
> [INFO] Lens .............................................. SUCCESS [3.422s]
> [INFO] Lens API .......................................... SUCCESS [28.191s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.373s]
> [INFO] Lens Cube ......................................... SUCCESS [12:20.941s]
> [INFO] Lens DB storage ................................... SUCCESS [22.056s]
> [INFO] Lens Query Library ................................ SUCCESS [17.141s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:02.736s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.390s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.920s]
> [INFO] Lens Server ....................................... SUCCESS [16:07.548s]
> [INFO] Lens client ....................................... SUCCESS [40.876s]
> [INFO] Lens CLI .......................................... SUCCESS [57.086s]
> [INFO] Lens Examples ..................................... SUCCESS [10.229s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.752s]
> [INFO] Lens Distribution ................................. SUCCESS [11.114s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:26.445s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
> [INFO] Lens Regression ................................... SUCCESS [14.655s]
> [INFO] Lens UI ........................................... SUCCESS [31.657s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:18.455s
> [INFO] Finished at: Tue Feb 02 09:07:35 UTC 2016
> [INFO] Final Memory: 178M/958M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 42909: LENS-920 : Fix reading and writing for json
input and output in all API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42909/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 9:10 a.m.)
Review request for lens.
Changes
-------
Removed duplicate/commented test code after self review
Bugs: LENS-920
https://issues.apache.org/jira/browse/LENS-920
Repository: lens
Description
-------
Changes include :
- Moving to latest jersey, grizzly and jaxb versions
- Enable Moxy json features explicitly
- Fixing a bug in LensJerseyTest for starting tests on random port
- Annotate all enum classes with @XmlEnum
- Write JAXB adapter for UUID
- In Json the name of the field as "type" is reserved. Had to change all the occurrances. Changed the type in xsd to be "_type".
- Fix signatures wrt LensAPIResult<? extends QuerySubmitResult>
- Update all tests to run against both XML and JSON marshalling/unmarshalling
- JSON requires all JAXBElement classes to be written as GenericEntity. Fixed TestMetastoreService wrt the same.
Diffs (updated)
-----
lens-api/pom.xml 8aa2f67
lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d
lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6
lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6
lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d
lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d
lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184
lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java 756287e
lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java 28d9710
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e
lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java d0c21a7
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java aa4dc13
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java c124a38
lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c
lens-api/src/main/java/org/apache/lens/api/util/MoxyJsonConfigurationContextResolver.java PRE-CREATION
lens-api/src/main/resources/cube-0.1.xsd d195b08
lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java 8647ac3
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
lens-cli/src/test/resources/cube_with_no_weight_facts.xml 13736b2
lens-cli/src/test/resources/dim-local-storage-element.xml 6503261
lens-cli/src/test/resources/dim_table.xml 3bc9600
lens-cli/src/test/resources/dim_table2.xml 4c3f7d9
lens-cli/src/test/resources/fact-local-storage-element.xml 6f30a1c
lens-cli/src/test/resources/fact1.xml f6d1f9c
lens-cli/src/test/resources/fact_without_weight.xml 8371b0b
lens-cli/src/test/resources/lens-client-site.xml e500bda
lens-cli/src/test/resources/logback.xml PRE-CREATION
lens-cli/src/test/resources/sample-cube.xml e3b3284
lens-cli/src/test/resources/test-detail.xml bb54354
lens-cli/src/test/resources/test-dimension.xml 2fa47f1
lens-client/src/main/java/org/apache/lens/client/LensConnection.java 30a7e2c
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 4dec1a2
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 8de7708
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 1fbd358
lens-examples/src/main/resources/city.xml 1a89a2a
lens-examples/src/main/resources/city_subset.xml 18c7847
lens-examples/src/main/resources/city_table.xml 27be305
lens-examples/src/main/resources/customer.xml c6182a2
lens-examples/src/main/resources/customer_table.xml af308c2
lens-examples/src/main/resources/dim_table.xml 10c9ac0
lens-examples/src/main/resources/dim_table2.xml e72f9c5
lens-examples/src/main/resources/dim_table3.xml 7955426
lens-examples/src/main/resources/dim_table4.xml 9de1cd7
lens-examples/src/main/resources/fact1.xml c934a64
lens-examples/src/main/resources/fact2.xml 3298fc1
lens-examples/src/main/resources/product.xml bb91997
lens-examples/src/main/resources/product_db_table.xml 867d37b
lens-examples/src/main/resources/product_table.xml 303f3ad
lens-examples/src/main/resources/rawfact.xml 8191eb2
lens-examples/src/main/resources/sales-aggr-continuous-fact.xml 781a615
lens-examples/src/main/resources/sales-aggr-fact1.xml 728c775
lens-examples/src/main/resources/sales-aggr-fact2.xml 61edf64
lens-examples/src/main/resources/sales-cube.xml e9e48ce
lens-examples/src/main/resources/sales-raw-fact.xml 4c2d571
lens-examples/src/main/resources/sample-cube.xml 3b5abea
lens-examples/src/main/resources/sample-db-only-dimension.xml 2e8aa64
lens-examples/src/main/resources/sample-dimension.xml 3c2589c
lens-examples/src/main/resources/sample-dimension2.xml 9740507
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLApp.java e6e3c02
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java ef3d53e
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f6434da
lens-server/pom.xml ba91e76
lens-server/src/main/java/org/apache/lens/server/BaseApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensServer.java 61eb37f
lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 630b95e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java fc67df1
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70323d3
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 520c698
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java fb937c6
lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 9db034a
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java bb4cfd2
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java e55ed13
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 5c247be
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java 0ea8544
lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java a499968
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java c22a1aa
lens-server/src/main/resources/lensserver-default.xml 881c159
lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java 56a3b75
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java 94dd394
lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4f9f4d2
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 877200f
lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 5301162
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 4b25fd0
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java 8e22c7a
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 85580da
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 515ac13
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java ab42a3d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 5d949d2
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 30d1e34
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java 7c6ce49
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
pom.xml 746204e
src/site/apt/admin/config.apt 703abb3
Diff: https://reviews.apache.org/r/42909/diff/
Testing (updated)
-------
---------------------
Successful queries 148 out of 148queries
Total time for running examples(in millis) :1421837
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.898s]
[INFO] Lens .............................................. SUCCESS [3.422s]
[INFO] Lens API .......................................... SUCCESS [28.191s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.373s]
[INFO] Lens Cube ......................................... SUCCESS [12:20.941s]
[INFO] Lens DB storage ................................... SUCCESS [22.056s]
[INFO] Lens Query Library ................................ SUCCESS [17.141s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:02.736s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [38.390s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.920s]
[INFO] Lens Server ....................................... SUCCESS [16:07.548s]
[INFO] Lens client ....................................... SUCCESS [40.876s]
[INFO] Lens CLI .......................................... SUCCESS [57.086s]
[INFO] Lens Examples ..................................... SUCCESS [10.229s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.752s]
[INFO] Lens Distribution ................................. SUCCESS [11.114s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:26.445s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
[INFO] Lens Regression ................................... SUCCESS [14.655s]
[INFO] Lens UI ........................................... SUCCESS [31.657s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:18.455s
[INFO] Finished at: Tue Feb 02 09:07:35 UTC 2016
[INFO] Final Memory: 178M/958M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 42909: LENS-920 : Fix reading and writing for json
input and output in all API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42909/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 8:31 a.m.)
Review request for lens.
Changes
-------
All review comments fixed
Bugs: LENS-920
https://issues.apache.org/jira/browse/LENS-920
Repository: lens
Description
-------
Changes include :
- Moving to latest jersey, grizzly and jaxb versions
- Enable Moxy json features explicitly
- Fixing a bug in LensJerseyTest for starting tests on random port
- Annotate all enum classes with @XmlEnum
- Write JAXB adapter for UUID
- In Json the name of the field as "type" is reserved. Had to change all the occurrances. Changed the type in xsd to be "_type".
- Fix signatures wrt LensAPIResult<? extends QuerySubmitResult>
- Update all tests to run against both XML and JSON marshalling/unmarshalling
- JSON requires all JAXBElement classes to be written as GenericEntity. Fixed TestMetastoreService wrt the same.
Diffs (updated)
-----
lens-api/pom.xml 8aa2f67
lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d
lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6
lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6
lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d
lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d
lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184
lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java 756287e
lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java 28d9710
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e
lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java d0c21a7
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java aa4dc13
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java c124a38
lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c
lens-api/src/main/java/org/apache/lens/api/util/MoxyJsonConfigurationContextResolver.java PRE-CREATION
lens-api/src/main/resources/cube-0.1.xsd d195b08
lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java 8647ac3
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
lens-cli/src/test/resources/cube_with_no_weight_facts.xml 13736b2
lens-cli/src/test/resources/dim-local-storage-element.xml 6503261
lens-cli/src/test/resources/dim_table.xml 3bc9600
lens-cli/src/test/resources/dim_table2.xml 4c3f7d9
lens-cli/src/test/resources/fact-local-storage-element.xml 6f30a1c
lens-cli/src/test/resources/fact1.xml f6d1f9c
lens-cli/src/test/resources/fact_without_weight.xml 8371b0b
lens-cli/src/test/resources/lens-client-site.xml e500bda
lens-cli/src/test/resources/logback.xml PRE-CREATION
lens-cli/src/test/resources/sample-cube.xml e3b3284
lens-cli/src/test/resources/test-detail.xml bb54354
lens-cli/src/test/resources/test-dimension.xml 2fa47f1
lens-client/src/main/java/org/apache/lens/client/LensConnection.java 30a7e2c
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 4dec1a2
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 8de7708
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 1fbd358
lens-examples/src/main/resources/city.xml 1a89a2a
lens-examples/src/main/resources/city_subset.xml 18c7847
lens-examples/src/main/resources/city_table.xml 27be305
lens-examples/src/main/resources/customer.xml c6182a2
lens-examples/src/main/resources/customer_table.xml af308c2
lens-examples/src/main/resources/dim_table.xml 10c9ac0
lens-examples/src/main/resources/dim_table2.xml e72f9c5
lens-examples/src/main/resources/dim_table3.xml 7955426
lens-examples/src/main/resources/dim_table4.xml 9de1cd7
lens-examples/src/main/resources/fact1.xml c934a64
lens-examples/src/main/resources/fact2.xml 3298fc1
lens-examples/src/main/resources/product.xml bb91997
lens-examples/src/main/resources/product_db_table.xml 867d37b
lens-examples/src/main/resources/product_table.xml 303f3ad
lens-examples/src/main/resources/rawfact.xml 8191eb2
lens-examples/src/main/resources/sales-aggr-continuous-fact.xml 781a615
lens-examples/src/main/resources/sales-aggr-fact1.xml 728c775
lens-examples/src/main/resources/sales-aggr-fact2.xml 61edf64
lens-examples/src/main/resources/sales-cube.xml e9e48ce
lens-examples/src/main/resources/sales-raw-fact.xml 4c2d571
lens-examples/src/main/resources/sample-cube.xml 3b5abea
lens-examples/src/main/resources/sample-db-only-dimension.xml 2e8aa64
lens-examples/src/main/resources/sample-dimension.xml 3c2589c
lens-examples/src/main/resources/sample-dimension2.xml 9740507
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLApp.java e6e3c02
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java ef3d53e
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f6434da
lens-server/pom.xml ba91e76
lens-server/src/main/java/org/apache/lens/server/BaseApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensServer.java 61eb37f
lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 630b95e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java fc67df1
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70323d3
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 520c698
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java fb937c6
lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 9db034a
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java bb4cfd2
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java e55ed13
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 5c247be
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java 0ea8544
lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java a499968
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java c22a1aa
lens-server/src/main/resources/lensserver-default.xml 881c159
lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java 56a3b75
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java 94dd394
lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4f9f4d2
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 877200f
lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 5301162
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 4b25fd0
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java 8e22c7a
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 85580da
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 515ac13
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java ab42a3d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 5d949d2
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 30d1e34
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java 7c6ce49
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
pom.xml 746204e
src/site/apt/admin/config.apt 703abb3
Diff: https://reviews.apache.org/r/42909/diff/
Testing (updated)
-------
--------------------
Successful queries 148 out of 148queries
Total time for running examples(in millis) :1421837
Thanks,
Amareshwari Sriramadasu
Re: Review Request 42909: LENS-920 : Fix reading and writing for json
input and output in all API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42909/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 7:08 a.m.)
Review request for lens.
Bugs: LENS-920
https://issues.apache.org/jira/browse/LENS-920
Repository: lens
Description (updated)
-------
Changes include :
- Moving to latest jersey, grizzly and jaxb versions
- Enable Moxy json features explicitly
- Fixing a bug in LensJerseyTest for starting tests on random port
- Annotate all enum classes with @XmlEnum
- Write JAXB adapter for UUID
- In Json the name of the field as "type" is reserved. Had to change all the occurrances. Changed the type in xsd to be "_type".
- Fix signatures wrt LensAPIResult<? extends QuerySubmitResult>
- Update all tests to run against both XML and JSON marshalling/unmarshalling
- JSON requires all JAXBElement classes to be written as GenericEntity. Fixed TestMetastoreService wrt the same.
Diffs (updated)
-----
lens-api/pom.xml 8aa2f67
lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d
lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6
lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6
lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d
lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d
lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184
lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java 756287e
lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java 28d9710
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e
lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java d0c21a7
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java aa4dc13
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java c124a38
lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c
lens-api/src/main/java/org/apache/lens/api/util/MoxyJsonConfigurationContextResolver.java PRE-CREATION
lens-api/src/main/resources/cube-0.1.xsd d195b08
lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java 8647ac3
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
lens-cli/src/test/resources/cube_with_no_weight_facts.xml 13736b2
lens-cli/src/test/resources/dim-local-storage-element.xml 6503261
lens-cli/src/test/resources/dim_table.xml 3bc9600
lens-cli/src/test/resources/dim_table2.xml 4c3f7d9
lens-cli/src/test/resources/fact-local-storage-element.xml 6f30a1c
lens-cli/src/test/resources/fact1.xml f6d1f9c
lens-cli/src/test/resources/fact_without_weight.xml 8371b0b
lens-cli/src/test/resources/lens-client-site.xml e500bda
lens-cli/src/test/resources/logback.xml PRE-CREATION
lens-cli/src/test/resources/sample-cube.xml e3b3284
lens-cli/src/test/resources/test-detail.xml bb54354
lens-cli/src/test/resources/test-dimension.xml 2fa47f1
lens-client/src/main/java/org/apache/lens/client/LensConnection.java 30a7e2c
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 4dec1a2
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 8de7708
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 1fbd358
lens-examples/src/main/resources/city.xml 1a89a2a
lens-examples/src/main/resources/city_subset.xml 18c7847
lens-examples/src/main/resources/city_table.xml 27be305
lens-examples/src/main/resources/customer.xml c6182a2
lens-examples/src/main/resources/customer_table.xml af308c2
lens-examples/src/main/resources/dim_table.xml 10c9ac0
lens-examples/src/main/resources/dim_table2.xml e72f9c5
lens-examples/src/main/resources/dim_table3.xml 7955426
lens-examples/src/main/resources/dim_table4.xml 9de1cd7
lens-examples/src/main/resources/fact1.xml c934a64
lens-examples/src/main/resources/fact2.xml 3298fc1
lens-examples/src/main/resources/product.xml bb91997
lens-examples/src/main/resources/product_db_table.xml 867d37b
lens-examples/src/main/resources/product_table.xml 303f3ad
lens-examples/src/main/resources/rawfact.xml 8191eb2
lens-examples/src/main/resources/sales-aggr-continuous-fact.xml 781a615
lens-examples/src/main/resources/sales-aggr-fact1.xml 728c775
lens-examples/src/main/resources/sales-aggr-fact2.xml 61edf64
lens-examples/src/main/resources/sales-cube.xml e9e48ce
lens-examples/src/main/resources/sales-raw-fact.xml 4c2d571
lens-examples/src/main/resources/sample-cube.xml 3b5abea
lens-examples/src/main/resources/sample-db-only-dimension.xml 2e8aa64
lens-examples/src/main/resources/sample-dimension.xml 3c2589c
lens-examples/src/main/resources/sample-dimension2.xml 9740507
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLApp.java e6e3c02
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java ef3d53e
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java f6434da
lens-server/pom.xml ba91e76
lens-server/src/main/java/org/apache/lens/server/BaseApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensServer.java 61eb37f
lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 630b95e
lens-server/src/main/java/org/apache/lens/server/error/LensExceptionMapper.java 1bb65ca
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java fc67df1
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70323d3
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 520c698
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java fb937c6
lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 9db034a
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java bb4cfd2
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java e55ed13
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 5c247be
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java 0ea8544
lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java a499968
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java c22a1aa
lens-server/src/main/resources/lensserver-default.xml 881c159
lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java 56a3b75
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java 94dd394
lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4f9f4d2
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 877200f
lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 5301162
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 4b25fd0
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java 8e22c7a
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 85580da
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 515ac13
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java ab42a3d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 5d949d2
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 30d1e34
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java 7c6ce49
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
pom.xml 746204e
src/site/apt/admin/config.apt 703abb3
Diff: https://reviews.apache.org/r/42909/diff/
Testing (updated)
-------
All tests passing.
All examples passing.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 42909: LENS-920 : Fix reading and writing for json
input and output in all API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42909/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 1:36 p.m.)
Review request for lens.
Bugs: LENS-920
https://issues.apache.org/jira/browse/LENS-920
Repository: lens
Description
-------
Changes include :
- Moving to latest jersey, grizzly and jaxb versions
- Enable Moxy json features explicitly
- Fixing a bug in LensJerseyTest for starting tests on random port
- Annotate all enum classes with @XmlEnum
- Write JAXB adapter for UUID
- In Json the name of the field as "type" is reserved. Had to change all the occurrances.
- Fix signatures wrt LensAPIResult<? extends QuerySubmitResult>
- Update all tests to run against both XML and JSON marshalling/unmarshalling
- JSON requires all JAXBElement classes to be written as GenericEntity. Fixed TestMetastoreService wrt the same.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/APIResult.java 0cdee0d
lens-api/src/main/java/org/apache/lens/api/LensConf.java ff965d6
lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java d4327a6
lens-api/src/main/java/org/apache/lens/api/Priority.java 0e5a65d
lens-api/src/main/java/org/apache/lens/api/UUIDAdapter.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 1485e1d
lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java 9f20184
lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java 756287e
lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java 28d9710
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 44fd97e
lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java d0c21a7
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java aa4dc13
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java c124a38
lens-api/src/main/java/org/apache/lens/api/result/QueryCostTO.java a247e3c
lens-api/src/main/resources/cube-0.1.xsd d195b08
lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java 8647ac3
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 30f4ec1
lens-cli/src/test/resources/cube_with_no_weight_facts.xml 13736b2
lens-cli/src/test/resources/dim-local-storage-element.xml 6503261
lens-cli/src/test/resources/dim_table.xml 3bc9600
lens-cli/src/test/resources/dim_table2.xml 4c3f7d9
lens-cli/src/test/resources/fact-local-storage-element.xml 6f30a1c
lens-cli/src/test/resources/fact1.xml f6d1f9c
lens-cli/src/test/resources/fact_without_weight.xml 8371b0b
lens-cli/src/test/resources/lens-client-site.xml e500bda
lens-cli/src/test/resources/logback.xml PRE-CREATION
lens-cli/src/test/resources/sample-cube.xml e3b3284
lens-cli/src/test/resources/test-detail.xml bb54354
lens-cli/src/test/resources/test-dimension.xml 2fa47f1
lens-client/pom.xml 5f2f3a9
lens-client/src/main/java/org/apache/lens/client/LensConnection.java 30a7e2c
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 4dec1a2
lens-client/src/main/java/org/apache/lens/client/MoxyJsonConfigurationContextResolver.java PRE-CREATION
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java 51344ce
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java ef3d53e
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd
lens-server/src/main/java/org/apache/lens/server/BaseApp.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/MoxyJsonConfigurationContextResolver.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/ServerModeFilter.java 630b95e
lens-server/src/main/java/org/apache/lens/server/error/LensExceptionMapper.java 1bb65ca
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java fc67df1
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70323d3
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreApp.java 520c698
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java fb937c6
lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java 9db034a
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java bb4cfd2
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java e55ed13
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 5c247be
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerApp.java 0ea8544
lens-server/src/main/java/org/apache/lens/server/session/SessionApp.java a499968
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 3ba5edd
lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java faaf172
lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java c22a1aa
lens-server/src/main/resources/lensserver-default.xml cac641a
lens-server/src/test/java/org/apache/lens/server/LensAllApplicationJerseyTest.java 56a3b75
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 8f52ddd
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java 94dd394
lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4f9f4d2
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 75f21e1
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 877200f
lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 5301162
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 4b25fd0
lens-server/src/test/java/org/apache/lens/server/common/TestDataUtils.java 0400519
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java 8e22c7a
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 925fc86
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreServiceJSON.java 85580da
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 515ac13
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 6f8886c
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 01e846a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java ab42a3d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 3facded
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 30d1e34
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java 7c6ce49
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 3055ce5
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 6f7c216
pom.xml 746204e
src/site/apt/admin/config.apt 54f827e
src/site/apt/admin/session-config.apt 05a2c2c
Diff: https://reviews.apache.org/r/42909/diff/
Testing (updated)
-------
All tests passing.
Pending:
Updating examples
Thanks,
Amareshwari Sriramadasu