[GitHub] [ant] bodewig commented on a change in pull request #164: Use inner class as static.

[GitBox <gi...@apache.org>]

bodewig commented on a change in pull request #164:
URL: https://github.com/apache/ant/pull/164#discussion_r720811236



##########
File path: src/main/org/apache/tools/ant/taskdefs/Javac.java
##########
@@ -910,7 +910,7 @@ public boolean getNowarn() {
      */
     public ImplementationSpecificArgument createCompilerArg() {
         final ImplementationSpecificArgument arg =
-            new ImplementationSpecificArgument();
+                new ImplementationSpecificArgument();

Review comment:
       please don't change whitespace in existing code.

##########
File path: src/main/org/apache/tools/ant/taskdefs/Input.java
##########
@@ -44,7 +44,7 @@
     /**
      * Represents an InputHandler.
      */
-    public class Handler extends DefBase {
+    public static class Handler extends DefBase {

Review comment:
       this change is not backwards compatible




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org