You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "craig-rueda (via GitHub)" <gi...@apache.org> on 2023/09/19 22:38:47 UTC
[GitHub] [superset] craig-rueda opened a new pull request, #25346: chore(async): Making create app configurable
craig-rueda opened a new pull request, #25346:
URL: https://github.com/apache/superset/pull/25346
### SUMMARY
First of several PRs to revive Global Async Queries.
* Makes AsyncQueryManager implementation configurable
* Adds nginx container to local docker-compose in order to deal with local websocket connections
* Dries up loading of class names to class instances
* Adds optional kwargs to `create_app()` in order to facilitate integration test configs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a diff in pull request #25346: chore(async): Making create app configurable
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on code in PR #25346:
URL: https://github.com/apache/superset/pull/25346#discussion_r1330776063
##########
superset/app.py:
##########
@@ -25,12 +26,14 @@
logger = logging.getLogger(__name__)
-def create_app() -> Flask:
+def create_app(superset_config_module: Optional[str] = None) -> Flask:
Review Comment:
Adding optional override module for test configs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #25346: chore(async): Making create app configurable
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #25346:
URL: https://github.com/apache/superset/pull/25346#discussion_r1331696535
##########
superset/async_events/async_query_manager_factory.py:
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from flask import Flask
+
+from superset.async_events.async_query_manager import AsyncQueryManager
+from superset.utils.class_utils import load_class_from_name
+
+
+class AsyncQueryManagerFactory:
+ def __init__(self) -> None:
+ self.async_query_manager: AsyncQueryManager = None # type: ignore
+
+ def init_app(self, app: Flask) -> None:
+ self.async_query_manager = load_class_from_name(
+ app.config["GLOBAL_ASYNC_QUERY_MANAGER_CLASS"]
+ )()
+ self.async_query_manager.init_app(app)
+
+ def get(self) -> AsyncQueryManager:
Review Comment:
nit: on `MachineAuthProviderFactory` we use `def instance(self) -> MachineAuthProvider:` and the property that holds the instance it self is "private"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a diff in pull request #25346: chore(async): Making create app configurable
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on code in PR #25346:
URL: https://github.com/apache/superset/pull/25346#discussion_r1330776592
##########
superset/utils/machine_auth.py:
##########
@@ -100,18 +100,9 @@ def __init__(self) -> None:
self._auth_provider = None
def init_app(self, app: Flask) -> None:
- auth_provider_fqclass = app.config["MACHINE_AUTH_PROVIDER_CLASS"]
- auth_provider_classname = auth_provider_fqclass[
- auth_provider_fqclass.rfind(".") + 1 :
- ]
- auth_provider_module_name = auth_provider_fqclass[
- 0 : auth_provider_fqclass.rfind(".")
- ]
- auth_provider_class = getattr(
- importlib.import_module(auth_provider_module_name), auth_provider_classname
- )
-
- self._auth_provider = auth_provider_class(app.config["WEBDRIVER_AUTH_FUNC"])
+ self._auth_provider = load_class_from_name(
Review Comment:
Drying up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a diff in pull request #25346: chore(async): Making create app configurable
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on code in PR #25346:
URL: https://github.com/apache/superset/pull/25346#discussion_r1330775768
##########
docker/nginx/nginx.conf:
##########
@@ -0,0 +1,127 @@
+#
Review Comment:
Added this config for local testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a diff in pull request #25346: chore(async): Making create app configurable
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on code in PR #25346:
URL: https://github.com/apache/superset/pull/25346#discussion_r1330776457
##########
superset/extensions/ssh.py:
##########
@@ -78,18 +78,9 @@ def __init__(self) -> None:
self._ssh_manager = None
def init_app(self, app: Flask) -> None:
- ssh_manager_fqclass = app.config["SSH_TUNNEL_MANAGER_CLASS"]
- ssh_manager_classname = ssh_manager_fqclass[
- ssh_manager_fqclass.rfind(".") + 1 :
- ]
- ssh_manager_module_name = ssh_manager_fqclass[
- 0 : ssh_manager_fqclass.rfind(".")
- ]
- ssh_manager_class = getattr(
- importlib.import_module(ssh_manager_module_name), ssh_manager_classname
- )
-
- self._ssh_manager = ssh_manager_class(app)
+ self._ssh_manager = load_class_from_name(
Review Comment:
Drying this up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #25346: chore(async): Making create app configurable
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda merged PR #25346:
URL: https://github.com/apache/superset/pull/25346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org