You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/01 13:55:07 UTC
[GitHub] [superset] sfirke opened a new issue, #21991: No alert message when trying to save dashboard properties with invalid content
sfirke opened a new issue, #21991:
URL: https://github.com/apache/superset/issues/21991
## Description
I edited my dashboard properties -> Advanced to specify custom colors and I missed a comma. It wouldn't let me hit "APPLY" to save my changes. That's good. But there was no alert message saying "input is currently not valid JSON. Please correct to save your changes." Or something like that. It took me a while to figure out why the apply button was not functional.
I think users would benefit from an alert message and the graying out of the apply button while saving is not allowed. The ideal error message would also identify the invalid chunk of code, if possible.
The invalid JSON looked like `"Fire": "#CE2029", "Fires": "#CE2029" "EMS": "#0000FF"`, missing a comma.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] No alert message when trying to save dashboard properties with invalid content [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #21991:
URL: https://github.com/apache/superset/issues/21991#issuecomment-1936438945
Thanks for testing and for the update! I see it looks like this was fixed in #20823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] No alert message when trying to save dashboard properties with invalid content [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido closed issue #21991: No alert message when trying to save dashboard properties with invalid content
URL: https://github.com/apache/superset/issues/21991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] No alert message when trying to save dashboard properties with invalid content [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on issue #21991:
URL: https://github.com/apache/superset/issues/21991#issuecomment-1936430671
Hello @sfirke, I just tested a similar scenario and it looks like there is an error message popping up "JSON metadata is invalid!". I am closing this issue. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org