You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "jiaoqingbo (via GitHub)" <gi...@apache.org> on 2023/11/24 06:51:29 UTC
[PR] [CELEBORN-1140] Use try-with-resources to avoid FSDataInputStream not… [incubator-celeborn]
jiaoqingbo opened a new pull request, #2113:
URL: https://github.com/apache/incubator-celeborn/pull/2113
… being closed
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
As Title
### Why are the changes needed?
As Title
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
PASS GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1140] Use try-with-resources to avoid FSDataInputStream not being closed [incubator-celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #2113: [CELEBORN-1140] Use try-with-resources to avoid FSDataInputStream not being closed
URL: https://github.com/apache/incubator-celeborn/pull/2113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1140] Use try-with-resources to avoid FSDataInputStream not being closed [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2113:
URL: https://github.com/apache/incubator-celeborn/pull/2113#issuecomment-1825228173
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2113?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`788b0c3`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/788b0c340b6c5d31de76fc12983d60f71c3ef811?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 46.50% compared to head [(`2dce042`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2113?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 46.49%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2113 +/- ##
==========================================
- Coverage 46.50% 46.49% -0.00%
==========================================
Files 166 166
Lines 10758 10758
Branches 984 984
==========================================
- Hits 5002 5001 -1
Misses 5430 5430
- Partials 326 327 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2113?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org