You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "superbAura (via GitHub)" <gi...@apache.org> on 2024/09/16 05:23:30 UTC
[PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
superbAura opened a new pull request, #2410:
URL: https://github.com/apache/james-project/pull/2410
…r Injection
- Updated `DefaultImapDecoderFactory` to adhere to POJO design principles.
- Replaced internal `ImapParserFactory` creation with constructor injection of `UnpooledStatusResponseFactory`.
- Improved decoupling and maintainability by explicitly managing dependencies via the constructor.
- Updated class and method documentation to reflect changes and clarify the role of the factory.
This change enhances the clarity and testability of the `DefaultImapDecoderFactory` by removing direct dependency creation and enforcing a cleaner, more modular structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2363604908
@Arsnael
After applying the Code Style in my IntelliJ, the code style was applied to the source I modified, and the indentation was updated.
I will rollback if it causes any issues.
I fixed the build errors caused by the Code Style. may be .. build runtime is so long
The process of checking Code Style during the build was a refreshing experience for me.
I learned a lot today as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #2410:
URL: https://github.com/apache/james-project/pull/2410#discussion_r1772779275
##########
protocols/imap/src/test/java/org/apache/james/imap/main/DefaultImapDecoderFactoryTest.java:
##########
@@ -0,0 +1,59 @@
+/****************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information *
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the *
+ * "License"); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software distributed under the License is distributed on an *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
+ * KIND, either express or implied. See the License for the *
+ * specific language governing permissions and limitations *
+ * under the License. *
+ ****************************************************************/
+
+package org.apache.james.imap.main;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+import org.apache.james.imap.api.message.response.StatusResponseFactory;
+import org.apache.james.imap.decode.ImapDecoder;
+import org.apache.james.imap.message.response.UnpooledStatusResponseFactory;
+import org.junit.jupiter.api.Test;
+
+class DefaultImapDecoderFactoryTest {
+
+ @Test
+ void createDefaultImapDecoderFactoryWithDefaultConstructor() {
+ // Create an instance using the default constructor
+ DefaultImapDecoderFactory factory = new DefaultImapDecoderFactory();
+
+ // Assert that the factory is not null
+ assertNotNull(factory, "Factory instance should not be null");
+
+ // Build an ImapDecoder using the factory and assert it's not null
+ ImapDecoder decoder = factory.buildImapDecoder();
+ assertNotNull(decoder, "ImapDecoder instance should not be null");
+ }
+
+ @Test
+ void createDefaultImapDecoderFactoryWithCustomStatusResponseFactory() {
+ // Create a custom StatusResponseFactory
+ StatusResponseFactory customStatusResponseFactory = new UnpooledStatusResponseFactory();
+
+ // Create an instance using the custom StatusResponseFactory
+ DefaultImapDecoderFactory factory = new DefaultImapDecoderFactory(customStatusResponseFactory);
+
+ // Assert that the factory is not null
+ assertNotNull(factory, "Factory instance should not be null");
+
+ // Build an ImapDecoder using the factory and assert it's not null
+ ImapDecoder decoder = factory.buildImapDecoder();
+ assertNotNull(decoder, "ImapDecoder instance should not be null");
+ }
Review Comment:
This comment has not been answered yet @superbAura :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #2410:
URL: https://github.com/apache/james-project/pull/2410#discussion_r1760590779
##########
protocols/imap/src/main/java/org/apache/james/imap/main/DefaultImapDecoderFactory.java:
##########
@@ -27,20 +27,35 @@
import org.apache.james.imap.message.response.UnpooledStatusResponseFactory;
/**
- * TODO: this is temporary: should let the container do the coupling. TODO:
- * convert to POJO
+ * Factory class for creating `ImapDecoder` instances.
+ *
+ * This class is a POJO that manually manages its dependencies.
+ * Dependencies are injected through the constructor, which allows for
+ * better decoupling and easier testing.
+ *
+ * The creation of `ImapCommandParserFactory` is handled internally by
+ * this factory, based on the provided `UnpooledStatusResponseFactory`.
*/
public class DefaultImapDecoderFactory implements ImapDecoderFactory {
- public static ImapDecoder createDecoder() {
- final UnpooledStatusResponseFactory unpooledStatusResponseFactory = new UnpooledStatusResponseFactory();
- final ImapCommandParserFactory imapCommands = new ImapParserFactory(unpooledStatusResponseFactory);
- return new DefaultImapDecoder(unpooledStatusResponseFactory, imapCommands);
+ private final UnpooledStatusResponseFactory unpooledStatusResponseFactory;
+ private final ImapCommandParserFactory imapCommandParserFactory;
+
+ /**
+ * Constructs `DefaultImapDecoderFactory` with the given
+ * `UnpooledStatusResponseFactory`. The `ImapCommandParserFactory`
+ * is created internally using the provided `UnpooledStatusResponseFactory`.
+ *
+ * @param unpooledStatusResponseFactory The factory for creating status responses.
+ */
+ public DefaultImapDecoderFactory(UnpooledStatusResponseFactory unpooledStatusResponseFactory) {
Review Comment:
That code is very old... Aint very sure about this part but problems I can see:
- several test classes depend on DefaultImapDecoderFactory.buildImapDecoder() . This change without being adapted is definitely gonna break them
- have a look in `IMAPServerModule` . The DefaultImapDecoder is being provided by building directly it, not passing by the Factory. It would make sense maybe to do a refactoring there as well.
- you might want to pass the ImapCommandParserFactory as an argument too (to use in IMAPServerModule)
- you could maybe have a static method that would return a default imap encoder (as of now) just for tests purposes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2367087768
> Why all the indents? Can you not change that please? Thanks
Shall I rollback and apply all the line breaks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2375885256
> #Fetch apache repository
>
> git fetch apache
>
>
>
> git rebase -i apache/master
>
> # squash all the commits into one
>
>
>
> git push origin -f HEAD
> This PR reverts some changes unrelated to this work.
>
> Is this what is wanted?
Right. It seems like unrelated changes have been included in this PR, which wasn't intended
It seems this occurred during the process of syncing with the remote and pushing.
In the IMAPServerTest class, it looks like GenericKeyStoreException.class is not being imported correctly. This is causing the current build failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #2410:
URL: https://github.com/apache/james-project/pull/2410#discussion_r1766087497
##########
protocols/imap/src/main/java/org/apache/james/imap/main/DefaultImapDecoderFactory.java:
##########
@@ -27,20 +27,35 @@
import org.apache.james.imap.message.response.UnpooledStatusResponseFactory;
/**
- * TODO: this is temporary: should let the container do the coupling. TODO:
- * convert to POJO
+ * Factory class for creating `ImapDecoder` instances.
+ *
+ * This class is a POJO that manually manages its dependencies.
+ * Dependencies are injected through the constructor, which allows for
+ * better decoupling and easier testing.
+ *
+ * The creation of `ImapCommandParserFactory` is handled internally by
+ * this factory, based on the provided `UnpooledStatusResponseFactory`.
*/
public class DefaultImapDecoderFactory implements ImapDecoderFactory {
- public static ImapDecoder createDecoder() {
- final UnpooledStatusResponseFactory unpooledStatusResponseFactory = new UnpooledStatusResponseFactory();
- final ImapCommandParserFactory imapCommands = new ImapParserFactory(unpooledStatusResponseFactory);
- return new DefaultImapDecoder(unpooledStatusResponseFactory, imapCommands);
+ private final UnpooledStatusResponseFactory unpooledStatusResponseFactory;
+ private final ImapCommandParserFactory imapCommandParserFactory;
+
+ /**
+ * Constructs `DefaultImapDecoderFactory` with the given
+ * `UnpooledStatusResponseFactory`. The `ImapCommandParserFactory`
+ * is created internally using the provided `UnpooledStatusResponseFactory`.
+ *
+ * @param unpooledStatusResponseFactory The factory for creating status responses.
+ */
+ public DefaultImapDecoderFactory(UnpooledStatusResponseFactory unpooledStatusResponseFactory) {
Review Comment:
No problem, don't hesitate to ask if you got issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2372744356
> Could you possibly share a backlog or JIRA link for Apache James?
JIRA backlog: https://issues.apache.org/jira/projects/JAMES/issues/JAMES-3580?filter=allopenissues
> I have a lot of questions regarding Apache James, and if you’re okay with it, could you let me know if there's a Slack channel or another way to ask questions?"
You have two ways:
- subscribing to mailing lists => https://james.apache.org/mail.html
- gitter channel => https://app.gitter.im/#/room/#apache_james-project:gitter.im
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2367802105
> Shall I rollback and apply all the line breaks?
I feel very sorry for this as this is likely to be a big work, but yes please, this change would be way easier to review without all those unrelated changes.
Project policy is to have ll spacings being 4-space based. IDE shall be reconfigured in order to match this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #2410:
URL: https://github.com/apache/james-project/pull/2410#discussion_r1768134403
##########
protocols/imap/src/test/java/org/apache/james/imap/main/DefaultImapDecoderFactoryTest.java:
##########
@@ -0,0 +1,59 @@
+/****************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information *
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the *
+ * "License"); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software distributed under the License is distributed on an *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
+ * KIND, either express or implied. See the License for the *
+ * specific language governing permissions and limitations *
+ * under the License. *
+ ****************************************************************/
+
+package org.apache.james.imap.main;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+import org.apache.james.imap.api.message.response.StatusResponseFactory;
+import org.apache.james.imap.decode.ImapDecoder;
+import org.apache.james.imap.message.response.UnpooledStatusResponseFactory;
+import org.junit.jupiter.api.Test;
+
+class DefaultImapDecoderFactoryTest {
+
+ @Test
+ void createDefaultImapDecoderFactoryWithDefaultConstructor() {
+ // Create an instance using the default constructor
+ DefaultImapDecoderFactory factory = new DefaultImapDecoderFactory();
+
+ // Assert that the factory is not null
+ assertNotNull(factory, "Factory instance should not be null");
+
+ // Build an ImapDecoder using the factory and assert it's not null
+ ImapDecoder decoder = factory.buildImapDecoder();
+ assertNotNull(decoder, "ImapDecoder instance should not be null");
+ }
+
+ @Test
+ void createDefaultImapDecoderFactoryWithCustomStatusResponseFactory() {
+ // Create a custom StatusResponseFactory
+ StatusResponseFactory customStatusResponseFactory = new UnpooledStatusResponseFactory();
+
+ // Create an instance using the custom StatusResponseFactory
+ DefaultImapDecoderFactory factory = new DefaultImapDecoderFactory(customStatusResponseFactory);
+
+ // Assert that the factory is not null
+ assertNotNull(factory, "Factory instance should not be null");
+
+ // Build an ImapDecoder using the factory and assert it's not null
+ ImapDecoder decoder = factory.buildImapDecoder();
+ assertNotNull(decoder, "ImapDecoder instance should not be null");
+ }
Review Comment:
Maybe add a unit test for the constructor `public DefaultImapDecoderFactory(ImapCommandParserFactory imapCommandParserFactory, StatusResponseFactory statusResponseFactory)` and I think it should be alright for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2363036684
06:36:13,438 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.0:check (check-style) on project protocols-imap: You have 1 Checkstyle violation. -> [Help 1]
Still one checkstyle issue somewhere :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on code in PR #2410:
URL: https://github.com/apache/james-project/pull/2410#discussion_r1767821413
##########
protocols/imap/src/test/java/org/apache/james/imap/main/DefaultImapDecoderFactoryTest.java:
##########
@@ -0,0 +1,39 @@
+package org.apache.james.imap.main;
Review Comment:
Added the ASF license notice to the source files. Please feel free to review and let me know if there are any concerns. Thank you! !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #2410:
URL: https://github.com/apache/james-project/pull/2410#discussion_r1767979781
##########
protocols/imap/src/main/java/org/apache/james/imap/main/DefaultImapDecoderFactory.java:
##########
@@ -27,20 +28,46 @@
import org.apache.james.imap.message.response.UnpooledStatusResponseFactory;
/**
- * TODO: this is temporary: should let the container do the coupling. TODO:
- * convert to POJO
+ * Factory class for creating `ImapDecoder` instances.
+ *
+ * This class is a POJO that manually manages its dependencies.
+ * Dependencies are injected through the constructor, which allows for
+ * better decoupling and easier testing.
+ *
+ * The creation of `ImapCommandParserFactory` is handled internally by
+ * this factory, based on the provided `UnpooledStatusResponseFactory`.
*/
public class DefaultImapDecoderFactory implements ImapDecoderFactory {
- public static ImapDecoder createDecoder() {
- final UnpooledStatusResponseFactory unpooledStatusResponseFactory = new UnpooledStatusResponseFactory();
- final ImapCommandParserFactory imapCommands = new ImapParserFactory(unpooledStatusResponseFactory);
- return new DefaultImapDecoder(unpooledStatusResponseFactory, imapCommands);
+ private final StatusResponseFactory statusResponseFactory;
+ private final ImapCommandParserFactory imapCommandParserFactory;
+
+ /**
+ * Default constructor.
+ * This constructor creates an instance of DefaultImapDecoderFactory with an UnpooledStatusResponseFactory as the default implementation.
+ */
+ public DefaultImapDecoderFactory() {
+ this(new UnpooledStatusResponseFactory());
}
+ /**
+ * Constructor that accepts a specific implementation of StatusResponseFactory.
+ * This constructor allows for flexibility by enabling different implementations of StatusResponseFactory to be used.
+ *
+ * @param statusResponseFactory An implementation of StatusResponseFactory to be used for creating IMAP command parsers and decoders.
+ */
+ public DefaultImapDecoderFactory(StatusResponseFactory statusResponseFactory) {
+ this.statusResponseFactory = statusResponseFactory;
+ this.imapCommandParserFactory = new ImapParserFactory(statusResponseFactory);
Review Comment:
Not necessary, you should pass that as an argument as well, and not building the default (that you can pass via your `DefaultImapDecoderFactory()` constructor)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2369948319
> > Shall I rollback and apply all the line breaks?
>
> I feel very sorry for this as this is likely to be a big work, but yes please, this change would be way easier to review without all those unrelated changes.
>
> Project policy is to have ll spacings being 4-space based. IDE shall be reconfigured in order to match this.
I have completed the requested changes !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2372710353
> Fine with me though a rebase is needed in order to fix the conflict.
Thank you for confirming.
Could you possibly share a backlog or JIRA link for Apache James?
I have a lot of questions regarding Apache James, and if you’re okay with it, could you let me know if there's a Slack channel or another way to ask questions?"
Let me know if you need any changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on code in PR #2410:
URL: https://github.com/apache/james-project/pull/2410#discussion_r1766269396
##########
protocols/imap/src/main/java/org/apache/james/imap/main/DefaultImapDecoderFactory.java:
##########
@@ -27,20 +27,35 @@
import org.apache.james.imap.message.response.UnpooledStatusResponseFactory;
/**
- * TODO: this is temporary: should let the container do the coupling. TODO:
- * convert to POJO
+ * Factory class for creating `ImapDecoder` instances.
+ *
+ * This class is a POJO that manually manages its dependencies.
+ * Dependencies are injected through the constructor, which allows for
+ * better decoupling and easier testing.
+ *
+ * The creation of `ImapCommandParserFactory` is handled internally by
+ * this factory, based on the provided `UnpooledStatusResponseFactory`.
*/
public class DefaultImapDecoderFactory implements ImapDecoderFactory {
- public static ImapDecoder createDecoder() {
- final UnpooledStatusResponseFactory unpooledStatusResponseFactory = new UnpooledStatusResponseFactory();
- final ImapCommandParserFactory imapCommands = new ImapParserFactory(unpooledStatusResponseFactory);
- return new DefaultImapDecoder(unpooledStatusResponseFactory, imapCommands);
+ private final UnpooledStatusResponseFactory unpooledStatusResponseFactory;
+ private final ImapCommandParserFactory imapCommandParserFactory;
+
+ /**
+ * Constructs `DefaultImapDecoderFactory` with the given
+ * `UnpooledStatusResponseFactory`. The `ImapCommandParserFactory`
+ * is created internally using the provided `UnpooledStatusResponseFactory`.
+ *
+ * @param unpooledStatusResponseFactory The factory for creating status responses.
+ */
+ public DefaultImapDecoderFactory(UnpooledStatusResponseFactory unpooledStatusResponseFactory) {
Review Comment:
The continuous-integration/jenkins/pr-merge failed. I will check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2378327136
> Alright the code seems ok now, I will merge and squash all of this on github's end.
>
> Just maybe for next time, on your PR instead of doing numerous git merge with master that lead to absolute commit mess (40+ commits... it makes it hard to review), prefer maybe the git rebase instead?
>
> Like on your local branch :
>
> ```
> git fetch apache master
> git rebase apache/master
>
> [fix conflicts if necessary]
>
> git push origin HEAD -f
> ```
>
> Would help keep a clean commit history, in sync with master branch, with making life of people reviewing your PR easier.
>
> Thank you for the contribution though, kindly appreciated :)
It was a fun experience contributing to open source for the first time. I'll look for another task to work on !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2368691782
That's a very minor thing. I will edit it and upload it soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #2410:
URL: https://github.com/apache/james-project/pull/2410#discussion_r1776579594
##########
server/protocols/protocols-imap4/src/test/java/org/apache/james/imapserver/netty/IMAPServerTest.java:
##########
@@ -3305,15 +3305,15 @@ void tearDown() {
void shouldSupportManyConcurrentSSLConnections() throws Exception {
//Failed for 3.7.0, this serves as a non regression test
ConcurrentTestRunner.builder()
- .operation((a, b) -> {
- IMAPSClient imapsClient = imapsImplicitClient(port);
- boolean capability = imapsClient.capability();
- assertThat(capability).isTrue();
- imapsClient.close();
- })
- .threadCount(10)
- .operationCount(200)
- .runSuccessfullyWithin(Duration.ofMinutes(10));
+ .operation((a, b) -> {
+ IMAPSClient imapsClient = imapsImplicitClient(port);
+ boolean capability = imapsClient.capability();
+ assertThat(capability).isTrue();
+ imapsClient.close();
+ })
+ .threadCount(10)
+ .operationCount(200)
+ .runSuccessfullyWithin(Duration.ofMinutes(10));
Review Comment:
Can you revert all those unnecessary indents in that file please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on code in PR #2410:
URL: https://github.com/apache/james-project/pull/2410#discussion_r1766233479
##########
protocols/imap/src/main/java/org/apache/james/imap/main/DefaultImapDecoderFactory.java:
##########
@@ -27,20 +27,35 @@
import org.apache.james.imap.message.response.UnpooledStatusResponseFactory;
/**
- * TODO: this is temporary: should let the container do the coupling. TODO:
- * convert to POJO
+ * Factory class for creating `ImapDecoder` instances.
+ *
+ * This class is a POJO that manually manages its dependencies.
+ * Dependencies are injected through the constructor, which allows for
+ * better decoupling and easier testing.
+ *
+ * The creation of `ImapCommandParserFactory` is handled internally by
+ * this factory, based on the provided `UnpooledStatusResponseFactory`.
*/
public class DefaultImapDecoderFactory implements ImapDecoderFactory {
- public static ImapDecoder createDecoder() {
- final UnpooledStatusResponseFactory unpooledStatusResponseFactory = new UnpooledStatusResponseFactory();
- final ImapCommandParserFactory imapCommands = new ImapParserFactory(unpooledStatusResponseFactory);
- return new DefaultImapDecoder(unpooledStatusResponseFactory, imapCommands);
+ private final UnpooledStatusResponseFactory unpooledStatusResponseFactory;
+ private final ImapCommandParserFactory imapCommandParserFactory;
+
+ /**
+ * Constructs `DefaultImapDecoderFactory` with the given
+ * `UnpooledStatusResponseFactory`. The `ImapCommandParserFactory`
+ * is created internally using the provided `UnpooledStatusResponseFactory`.
+ *
+ * @param unpooledStatusResponseFactory The factory for creating status responses.
+ */
+ public DefaultImapDecoderFactory(UnpooledStatusResponseFactory unpooledStatusResponseFactory) {
Review Comment:
First, added a default constructor for DefaultImapDecoderFactory.
This addition enhances flexibility by allowing other classes to use the default constructor.
Additionally, added another constructor that accepts an implementation of StatusResponseFactory.
This change is to provide flexibility for the ResponseFactory in DefaultImapDecoderFactory in the future.
Also modified two other test classes to use the constructor-based approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2374069733
Please
```
#Fetch apache repository
git fetch apache
git rebase -i apache/master
# squash all the commits into one
git push origin -f HEAD
```
The git conflict is still present:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #2410:
URL: https://github.com/apache/james-project/pull/2410#discussion_r1766761423
##########
protocols/imap/src/test/java/org/apache/james/imap/main/DefaultImapDecoderFactoryTest.java:
##########
@@ -0,0 +1,39 @@
+package org.apache.james.imap.main;
Review Comment:
THis file misses the compulsory ASF V2 license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2375852335
it's done !
@chibenwa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2375488479
> Please
>
>
>
> ```
>
> #Fetch apache repository
>
> git fetch apache
>
>
>
> git rebase -i apache/master
>
> # squash all the commits into one
>
>
>
> git push origin -f HEAD
>
> ```
>
>
>
> The git conflict is still present:
>
>
>
> 
>
>
ok I'll do it soon !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2376034422
Still conflicts... I see some commits from other people that have been merged being pushed here (which is not wanted).
Cant you just do a rebase on latest master and squash everything into one commit instead of messy merges with master? Thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2378282341
Alright the code seems ok now, I will merge and squash all of this on github's end.
Just maybe for next time, on your PR instead of doing numerous git merge with master that lead to absolute commit mess (40+ commits... it makes it hard to review), prefer maybe the git rebase instead?
Like on your local branch :
```
git fetch apache master
git rebase apache/master
[fix conflicts if necessary]
git push origin HEAD -f
```
Would help keep a clean commit history, in sync with master branch, with making life of people reviewing your PR easier.
Thank you for the contribution though, kindly appreciated :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael merged PR #2410:
URL: https://github.com/apache/james-project/pull/2410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2362901676
I also use IntelliJ.
@Arsnael
I will improve the factory and builder pattern in the IMAPServerModule module.
Thank you.
If you have any references that I can refer to, I would appreciate it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2372748091
> > Could you possibly share a backlog or JIRA link for Apache James?
>
> JIRA backlog: https://issues.apache.org/jira/projects/JAMES/issues/JAMES-3580?filter=allopenissues
>
> > I have a lot of questions regarding Apache James, and if you’re okay with it, could you let me know if there's a Slack channel or another way to ask questions?"
>
> You have two ways:
>
> * subscribing to mailing lists => https://james.apache.org/mail.html
> * gitter channel => https://app.gitter.im/#/room/#apache_james-project:gitter.im
Thankx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2362821104
3 Checkstyle issues in the build. What IDE are you using btw? i personally use Intellij and it allows to navigate easily in the project. Also you can have a plugin to apply and check the checkstyle (to make sure it respects a certain number of coding rules within the project).
Checkstyle file used by James is at the root f the project: https://github.com/apache/james-project/blob/master/checkstyle.xml
Also I don't see a refactoring in IMAPServerModule to use the factory for building the DefaultImapDecoder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2363311654
Why all the indents? Can you not change that please? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on code in PR #2410:
URL: https://github.com/apache/james-project/pull/2410#discussion_r1766020840
##########
protocols/imap/src/main/java/org/apache/james/imap/main/DefaultImapDecoderFactory.java:
##########
@@ -27,20 +27,35 @@
import org.apache.james.imap.message.response.UnpooledStatusResponseFactory;
/**
- * TODO: this is temporary: should let the container do the coupling. TODO:
- * convert to POJO
+ * Factory class for creating `ImapDecoder` instances.
+ *
+ * This class is a POJO that manually manages its dependencies.
+ * Dependencies are injected through the constructor, which allows for
+ * better decoupling and easier testing.
+ *
+ * The creation of `ImapCommandParserFactory` is handled internally by
+ * this factory, based on the provided `UnpooledStatusResponseFactory`.
*/
public class DefaultImapDecoderFactory implements ImapDecoderFactory {
- public static ImapDecoder createDecoder() {
- final UnpooledStatusResponseFactory unpooledStatusResponseFactory = new UnpooledStatusResponseFactory();
- final ImapCommandParserFactory imapCommands = new ImapParserFactory(unpooledStatusResponseFactory);
- return new DefaultImapDecoder(unpooledStatusResponseFactory, imapCommands);
+ private final UnpooledStatusResponseFactory unpooledStatusResponseFactory;
+ private final ImapCommandParserFactory imapCommandParserFactory;
+
+ /**
+ * Constructs `DefaultImapDecoderFactory` with the given
+ * `UnpooledStatusResponseFactory`. The `ImapCommandParserFactory`
+ * is created internally using the provided `UnpooledStatusResponseFactory`.
+ *
+ * @param unpooledStatusResponseFactory The factory for creating status responses.
+ */
+ public DefaultImapDecoderFactory(UnpooledStatusResponseFactory unpooledStatusResponseFactory) {
Review Comment:
Understood. I will check if it's possible to refactor based on what you mentioned.
Thank you for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2352041757
Hello,
I am currently reviewing Apache James for developing a mail engine. While forking the source, I noticed a simple TO-DO comment and made a commit request.
Starting from 2025, we plan to use Apache James extensively. If given the opportunity, I would like to contribute significantly to its improvements.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] Refactor `DefaultImapDecoderFactory` to Use POJO Style and Constructo… [james-project]
Posted by "superbAura (via GitHub)" <gi...@apache.org>.
superbAura commented on PR #2410:
URL: https://github.com/apache/james-project/pull/2410#issuecomment-2376224753
> Still conflicts... I see some commits from other people that have been merged being pushed here (which is not wanted).
>
> Cant you just do a rebase on latest master and squash everything into one commit instead of messy merges with master? Thanks :)
I'm not sure if it's going well, but I completed the squash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org