You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Tim Armstrong (JIRA)" <ji...@apache.org> on 2019/03/06 23:17:00 UTC

[jira] [Commented] (IMPALA-5490) Upgrade to GCC 7.x

    [ https://issues.apache.org/jira/browse/IMPALA-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786210#comment-16786210 ] 

Tim Armstrong commented on IMPALA-5490:
---------------------------------------

I played around with this a bit a couple of months ago, got to the point of running benchmarks. I got stalled out on investigating potential regressions - too many other things to really drive it. Here's the patch [^0001-Switch-to-gcc7.patch] 

{noformat}
    +----------+-----------------------+---------+------------+------------+----------------+
    | Workload | File Format           | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) |
    +----------+-----------------------+---------+------------+------------+----------------+
    | TPCH(10) | parquet / none / none | 4.37    | +2.65%     | 2.31       | +0.60%         |
    +----------+-----------------------+---------+------------+------------+----------------+
    
    +----------+-----------+-----------------------+--------+-------------+------------+------------+----------------+-------+----------------+---------+-------+
    | Workload | Query     | File Format           | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%)  | Base StdDev(%) | Iters | Median Diff(%) | MW Zval | Tval  |
    +----------+-----------+-----------------------+--------+-------------+------------+------------+----------------+-------+----------------+---------+-------+
    | TPCH(10) | TPCH-AGG1 | parquet / none / none | 19.78  | 16.93       |   +16.84%  | * 26.31% * |   3.83%        | 20    |   +2.97%       | 1.59    | 2.43  |
    | TPCH(10) | TPCH-Q13  | parquet / none / none | 4.12   | 4.06        |   +1.37%   |   2.88%    |   4.23%        | 20    |   +1.87%       | 1.82    | 1.19  |
    | TPCH(10) | TPCH-Q21  | parquet / none / none | 8.93   | 8.83        |   +1.10%   |   1.29%    |   0.73%        | 20    |   +1.16%       | 2.82    | 3.29  |
    | TPCH(10) | TPCH-Q14  | parquet / none / none | 1.21   | 1.19        |   +1.55%   |   2.50%    |   2.54%        | 20    |   +0.22%       | 1.56    | 1.93  |
    | TPCH(10) | TPCH-Q11  | parquet / none / none | 0.77   | 0.77        |   +0.89%   |   2.07%    |   3.76%        | 20    |   +0.04%       | 0.31    | 0.93  |
    | TPCH(10) | TPCH-Q8   | parquet / none / none | 2.37   | 2.35        |   +0.70%   |   2.81%    |   2.57%        | 20    |   +0.13%       | 0.95    | 0.82  |
    | TPCH(10) | TPCH-Q20  | parquet / none / none | 1.24   | 1.23        |   +0.78%   |   3.00%    |   2.36%        | 20    |   +0.03%       | 0.48    | 0.91  |
    | TPCH(10) | TPCH-Q5   | parquet / none / none | 2.16   | 2.14        |   +0.70%   |   1.37%    |   1.97%        | 20    |   +0.11%       | 1.01    | 1.30  |
    | TPCH(10) | TPCH-Q12  | parquet / none / none | 1.11   | 1.10        |   +0.50%   |   3.74%    |   2.91%        | 20    |   +0.00%       | 0.07    | 0.47  |
    | TPCH(10) | TPCH-Q17  | parquet / none / none | 1.40   | 1.39        |   +0.56%   |   6.24%    |   2.66%        | 20    |   -0.07%       | -0.51   | 0.37  |
    | TPCH(10) | TPCH-Q1   | parquet / none / none | 3.98   | 3.96        |   +0.40%   |   1.13%    |   0.96%        | 20    |   +0.03%       | 0.92    | 1.20  |
    | TPCH(10) | TPCH-Q10  | parquet / none / none | 2.06   | 2.05        |   +0.26%   |   2.44%    |   2.54%        | 20    |   +0.05%       | 0.36    | 0.33  |
    | TPCH(10) | TPCH-Q19  | parquet / none / none | 1.68   | 1.67        |   +0.28%   |   1.97%    |   1.83%        | 20    |   +0.02%       | 0.28    | 0.46  |
    | TPCH(10) | TPCH-Q4   | parquet / none / none | 0.89   | 0.89        |   +0.17%   |   3.26%    |   3.34%        | 20    |   -0.04%       | -0.54   | 0.17  |
    | TPCH(10) | TPCH-AGG2 | parquet / none / none | 30.33  | 30.41       |   -0.25%   |   2.25%    |   3.56%        | 20    |   +0.33%       | 0.39    | -0.27 |
    | TPCH(10) | TPCH-Q16  | parquet / none / none | 1.16   | 1.16        |   -0.01%   |   1.80%    |   3.01%        | 20    |   -0.03%       | -0.16   | -0.01 |
    | TPCH(10) | TPCH-Q6   | parquet / none / none | 0.55   | 0.55        |   -0.11%   |   3.96%    |   4.79%        | 20    |   +0.04%       | 0.31    | -0.08 |
    | TPCH(10) | TPCH-Q22  | parquet / none / none | 1.17   | 1.18        |   -0.09%   |   1.59%    |   1.57%        | 20    |   -0.05%       | -0.89   | -0.18 |
    | TPCH(10) | TPCH-Q18  | parquet / none / none | 5.81   | 5.82        |   -0.26%   |   1.30%    |   1.40%        | 20    |   -0.01%       | -0.25   | -0.60 |
    | TPCH(10) | TPCH-AGG3 | parquet / none / none | 1.26   | 1.27        |   -0.48%   |   2.03%    |   0.90%        | 20    |   -0.02%       | -0.51   | -0.98 |
    | TPCH(10) | TPCH-Q15  | parquet / none / none | 1.44   | 1.44        |   -0.48%   |   3.05%    |   2.49%        | 20    |   -0.18%       | -0.89   | -0.55 |
    | TPCH(10) | TPCH-Q9   | parquet / none / none | 5.65   | 5.67        |   -0.22%   |   3.15%    |   1.50%        | 20    |   -0.80%       | -0.60   | -0.28 |
    | TPCH(10) | TPCH-Q3   | parquet / none / none | 1.86   | 1.88        |   -1.07%   |   1.71%    |   1.71%        | 20    |   -0.25%       | -1.56   | -2.00 |
    | TPCH(10) | TPCH-Q2   | parquet / none / none | 0.87   | 0.90        |   -2.34%   |   4.34%    |   3.31%        | 20    |   -0.24%       | -1.15   | -1.95 |
    | TPCH(10) | TPCH-Q7   | parquet / none / none | 7.40   | 7.53        |   -1.72%   |   2.76%    |   2.99%        | 20    |   -1.99%       | -2.12   | -1.91 |
    +----------+-----------+-----------------------+--------+-------------+------------+------------+----------------+-------+----------------+---------+-------+
{noformat}

> Upgrade to GCC 7.x
> ------------------
>
>                 Key: IMPALA-5490
>                 URL: https://issues.apache.org/jira/browse/IMPALA-5490
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Minor
>         Attachments: 0001-Switch-to-gcc7.patch
>
>
> This has some nice features like the [[nodiscard]] annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org