You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/10/27 18:29:29 UTC
Review Request 27236: SQOOP-1513: Link rest api changes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see JIRA for details.
Diffs
-----
common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
core/src/main/java/org/apache/sqoop/repository/Repository.java bd2a3be
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b4b5f3e
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 0a5b467
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5b03a8f
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java be9685b
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b715ad3
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml a6f7b0d
Diff: https://reviews.apache.org/r/27236/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27236: SQOOP-1513: Link rest api changes
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java, line 806
> > <https://reviews.apache.org/r/27236/diff/2/?file=734314#file734314line806>
> >
> > Maybe add an index on name? Maybe cool for a follow up Jira?
>
> Veena Basavaraj wrote:
> sure. a follow up jira since it needs a upgrade script as well, and it is optimization feature.
created a JIRA for it
> On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote:
> > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java, lines 52-56
> > <https://reviews.apache.org/r/27236/diff/2/?file=734316#file734316line52>
> >
> > Unrelated change. Pull out into separate jira?
>
> Veena Basavaraj wrote:
> sending another one now, if you can commit it.:)
https://reviews.apache.org/r/27241/
> On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote:
> > server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java, lines 42-46
> > <https://reviews.apache.org/r/27236/diff/2/?file=734317#file734317line42>
> >
> > Unrelated change. Pull out into separate jira?
https://reviews.apache.org/r/27241/
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/#review58644
-----------------------------------------------------------
On Oct. 27, 2014, 10:58 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27236/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:58 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA for details.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
> common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
> core/src/main/java/org/apache/sqoop/repository/Repository.java bd2a3be
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b4b5f3e
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 0a5b467
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5b03a8f
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java be9685b
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b715ad3
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
> server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
> server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml a6f7b0d
>
> Diff: https://reviews.apache.org/r/27236/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27236: SQOOP-1513: Link rest api changes
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Oct. 27, 2014, 6:37 p.m., Abraham Elmahrek wrote:
> > server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java, lines 44-46
> > <https://reviews.apache.org/r/27236/diff/2/?file=734322#file734322line44>
> >
> > I don't see any thing about a '/links' api in the attached doc.
>
> Veena Basavaraj wrote:
> it is similar to the connectors, might have missed, do you want me to ammend the doc?
Is there a Jira open for updating the docs? If so, I think it can be done there.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/#review58644
-----------------------------------------------------------
On Oct. 27, 2014, 5:58 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27236/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 5:58 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA for details.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
> common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
> core/src/main/java/org/apache/sqoop/repository/Repository.java bd2a3be
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b4b5f3e
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 0a5b467
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5b03a8f
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java be9685b
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b715ad3
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
> server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
> server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml a6f7b0d
>
> Diff: https://reviews.apache.org/r/27236/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27236: SQOOP-1513: Link rest api changes
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java, line 806
> > <https://reviews.apache.org/r/27236/diff/2/?file=734314#file734314line806>
> >
> > Maybe add an index on name? Maybe cool for a follow up Jira?
sure. a follow up jira since it needs a upgrade script as well, and it is optimization feature.
> On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote:
> > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java, lines 52-56
> > <https://reviews.apache.org/r/27236/diff/2/?file=734316#file734316line52>
> >
> > Unrelated change. Pull out into separate jira?
sending another one now, if you can commit it.:)
> On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote:
> > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java, lines 50-78
> > <https://reviews.apache.org/r/27236/diff/2/?file=734318#file734318line50>
> >
> > Can we have some javadocs (doesn't have to be API in its entirety)?
there is java docs, moved to the servlet since that is the main entry point.
> On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote:
> > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java, line 246
> > <https://reviews.apache.org/r/27236/diff/2/?file=734318#file734318line246>
> >
> > Is "v1/link/all" supported any more? Or are we switching to 'v1/links'.
for reasons of the command line client I have not removed any existing features. I have only added new ways so we can deprecate the all feature later
> On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote:
> > server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java, lines 44-46
> > <https://reviews.apache.org/r/27236/diff/2/?file=734322#file734322line44>
> >
> > I don't see any thing about a '/links' api in the attached doc.
it is similar to the connectors, might have missed, do you want me to ammend the doc?
> On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote:
> > server/src/main/webapp/WEB-INF/web.xml, lines 103-112
> > <https://reviews.apache.org/r/27236/diff/2/?file=734323#file734323line103>
> >
> > Is this really necessary? I don't see 'v1/links' in the attached design doc?
same as above, it is good to be consistent and not have different ways for the similar things, the docs might have missed it since I did not proof read it for everything, i hope we are not doing document driven development.!
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/#review58644
-----------------------------------------------------------
On Oct. 27, 2014, 10:58 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27236/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:58 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA for details.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
> common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
> core/src/main/java/org/apache/sqoop/repository/Repository.java bd2a3be
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b4b5f3e
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 0a5b467
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5b03a8f
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java be9685b
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b715ad3
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
> server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
> server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml a6f7b0d
>
> Diff: https://reviews.apache.org/r/27236/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27236: SQOOP-1513: Link rest api changes
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote:
> > server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java, lines 44-46
> > <https://reviews.apache.org/r/27236/diff/2/?file=734322#file734322line44>
> >
> > I don't see any thing about a '/links' api in the attached doc.
>
> Veena Basavaraj wrote:
> it is similar to the connectors, might have missed, do you want me to ammend the doc?
>
> Abraham Elmahrek wrote:
> Is there a Jira open for updating the docs? If so, I think it can be done there.
yes sir.since you ask it many time, I have memorized the ticket number lol
https://issues.apache.org/jira/browse/SQOOP-1518
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/#review58644
-----------------------------------------------------------
On Oct. 27, 2014, 10:58 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27236/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:58 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA for details.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
> common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
> core/src/main/java/org/apache/sqoop/repository/Repository.java bd2a3be
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b4b5f3e
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 0a5b467
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5b03a8f
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java be9685b
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b715ad3
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
> server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
> server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml a6f7b0d
>
> Diff: https://reviews.apache.org/r/27236/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27236: SQOOP-1513: Link rest api changes
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/#review58644
-----------------------------------------------------------
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
<https://reviews.apache.org/r/27236/#comment99705>
Maybe add an index on name? Maybe cool for a follow up Jira?
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
<https://reviews.apache.org/r/27236/#comment99715>
Unrelated change. Pull out into separate jira?
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java
<https://reviews.apache.org/r/27236/#comment99714>
Unrelated change. Pull out into separate jira?
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java
<https://reviews.apache.org/r/27236/#comment99702>
Can we have some javadocs (doesn't have to be API in its entirety)?
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java
<https://reviews.apache.org/r/27236/#comment99716>
Is "v1/link/all" supported any more? Or are we switching to 'v1/links'.
server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java
<https://reviews.apache.org/r/27236/#comment99712>
I don't see any thing about a '/links' api in the attached doc.
server/src/main/webapp/WEB-INF/web.xml
<https://reviews.apache.org/r/27236/#comment99713>
Is this really necessary? I don't see 'v1/links' in the attached design doc?
- Abraham Elmahrek
On Oct. 27, 2014, 5:58 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27236/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 5:58 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA for details.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
> common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
> core/src/main/java/org/apache/sqoop/repository/Repository.java bd2a3be
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b4b5f3e
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 0a5b467
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5b03a8f
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java be9685b
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b715ad3
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
> server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
> server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml a6f7b0d
>
> Diff: https://reviews.apache.org/r/27236/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27236: SQOOP-1513: Link rest api changes
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 27, 2014, 9:10 p.m., Abraham Elmahrek wrote:
> > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java, line 245
> > <https://reviews.apache.org/r/27236/diff/2-5/?file=734311#file734311line245>
> >
> > This doesn't actually have a "throws" statement. Unchecked exceptions typically aren't placed here.
ah true, removing. Its a run time.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/#review58763
-----------------------------------------------------------
On Oct. 27, 2014, 8:48 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27236/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 8:48 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA for details.
>
> Note :I just realized that it might really be more work in HUE to have th parent/child in URLS,
>
> so v1/link ? connector-id in the post data for creating a link rather than v1/connector/{cId}/link
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 64e5cb1
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
> common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
> core/src/main/java/org/apache/sqoop/repository/Repository.java fcee48b
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 7f19c28
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java 02b11fc
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 823426a
> server/src/main/java/org/apache/sqoop/server/RequestContext.java b1a74fc
> server/src/main/java/org/apache/sqoop/server/common/ServerError.java 02d9174
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
> server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
> server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml a6f7b0d
>
> Diff: https://reviews.apache.org/r/27236/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27236: SQOOP-1513: Link rest api changes
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/#review58763
-----------------------------------------------------------
Ship it!
Almost there... Just a couple of nit pick and you're good I think.
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
<https://reviews.apache.org/r/27236/#comment99911>
This doesn't actually have a "throws" statement. Unchecked exceptions typically aren't placed here.
core/src/main/java/org/apache/sqoop/repository/Repository.java
<https://reviews.apache.org/r/27236/#comment99912>
Same as above
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java
<https://reviews.apache.org/r/27236/#comment99913>
Return to 1 line?
- Abraham Elmahrek
On Oct. 28, 2014, 3:48 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27236/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 3:48 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA for details.
>
> Note :I just realized that it might really be more work in HUE to have th parent/child in URLS,
>
> so v1/link ? connector-id in the post data for creating a link rather than v1/connector/{cId}/link
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 64e5cb1
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
> common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
> core/src/main/java/org/apache/sqoop/repository/Repository.java fcee48b
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 7f19c28
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java 02b11fc
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 823426a
> server/src/main/java/org/apache/sqoop/server/RequestContext.java b1a74fc
> server/src/main/java/org/apache/sqoop/server/common/ServerError.java 02d9174
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
> server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
> server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml a6f7b0d
>
> Diff: https://reviews.apache.org/r/27236/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27236: SQOOP-1513: Link rest api changes
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/#review58767
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Oct. 28, 2014, 4:17 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27236/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 4:17 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA for details.
>
> Note :I just realized that it might really be more work in HUE to have th parent/child in URLS,
>
> so v1/link ? connector-id in the post data for creating a link rather than v1/connector/{cId}/link
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 64e5cb1
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
> common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
> core/src/main/java/org/apache/sqoop/repository/Repository.java fcee48b
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 7f19c28
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java 02b11fc
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 823426a
> server/src/main/java/org/apache/sqoop/server/RequestContext.java b1a74fc
> server/src/main/java/org/apache/sqoop/server/common/ServerError.java 02d9174
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
> server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
> server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml a6f7b0d
>
> Diff: https://reviews.apache.org/r/27236/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27236: SQOOP-1513: Link rest api changes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 9:17 p.m.)
Review request for Sqoop.
Changes
-------
addressed Abe's comments
Repository: sqoop-sqoop2
Description
-------
see JIRA for details.
Note :I just realized that it might really be more work in HUE to have th parent/child in URLS,
so v1/link ? connector-id in the post data for creating a link rather than v1/connector/{cId}/link
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 64e5cb1
common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
core/src/main/java/org/apache/sqoop/repository/Repository.java fcee48b
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 7f19c28
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java 02b11fc
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 823426a
server/src/main/java/org/apache/sqoop/server/RequestContext.java b1a74fc
server/src/main/java/org/apache/sqoop/server/common/ServerError.java 02d9174
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml a6f7b0d
Diff: https://reviews.apache.org/r/27236/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27236: SQOOP-1513: Link rest api changes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 8:48 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see JIRA for details.
Note :I just realized that it might really be more work in HUE to have th parent/child in URLS,
so v1/link ? connector-id in the post data for creating a link rather than v1/connector/{cId}/link
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 64e5cb1
common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
core/src/main/java/org/apache/sqoop/repository/Repository.java fcee48b
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 7f19c28
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java 02b11fc
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 823426a
server/src/main/java/org/apache/sqoop/server/RequestContext.java b1a74fc
server/src/main/java/org/apache/sqoop/server/common/ServerError.java 02d9174
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml a6f7b0d
Diff: https://reviews.apache.org/r/27236/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27236: SQOOP-1513: Link rest api changes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 6:41 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description (updated)
-------
see JIRA for details.
Note :I just realized that it might really be more work in HUE to have th parent/child in URLS,
so v1/link ? connector-id in the post data for creating a link rather than v1/connector/{cId}/link
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 64e5cb1
common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
core/src/main/java/org/apache/sqoop/repository/Repository.java fcee48b
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 7f19c28
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java 02b11fc
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 823426a
server/src/main/java/org/apache/sqoop/server/RequestContext.java b1a74fc
server/src/main/java/org/apache/sqoop/server/common/ServerError.java 02d9174
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml a6f7b0d
Diff: https://reviews.apache.org/r/27236/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27236: SQOOP-1513: Link rest api changes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 4:58 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see JIRA for details.
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
core/src/main/java/org/apache/sqoop/repository/Repository.java bd2a3be
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b4b5f3e
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 0a5b467
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b715ad3
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml a6f7b0d
Diff: https://reviews.apache.org/r/27236/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27236: SQOOP-1513: Link rest api changes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27236/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 10:58 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see JIRA for details.
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500
common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7d78826
core/src/main/java/org/apache/sqoop/repository/Repository.java bd2a3be
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b4b5f3e
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 0a5b467
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 37343d3
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5b03a8f
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java be9685b
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b715ad3
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java 781abc3
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd
server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009
server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml a6f7b0d
Diff: https://reviews.apache.org/r/27236/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj