You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by GitBox <gi...@apache.org> on 2022/01/17 07:27:31 UTC
[GitHub] [griffin] lipzhu opened a new pull request #596: [GRIFFIN-367] For task GRIFFIN-367, update local deploy document.
lipzhu opened a new pull request #596:
URL: https://github.com/apache/griffin/pull/596
1. Move the service-${version}.tar.gz from parent target folder to service module target.
2. Remove the diff change history for hive-site.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] whhe commented on a change in pull request #596: [GRIFFIN-367] For task GRIFFIN-367, update local deploy document.
Posted by GitBox <gi...@apache.org>.
whhe commented on a change in pull request #596:
URL: https://github.com/apache/griffin/pull/596#discussion_r785853228
##########
File path: service/pom.xml
##########
@@ -385,7 +385,6 @@ under the License.
<configuration>
<appendAssemblyId>false</appendAssemblyId>
<skipAssembly>false</skipAssembly>
- <outputDirectory>../target</outputDirectory>
Review comment:
Why move it? I think it's appropriate to put the deployment package at root directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] whhe commented on a change in pull request #596: [GRIFFIN-367] For task GRIFFIN-367, update local deploy document.
Posted by GitBox <gi...@apache.org>.
whhe commented on a change in pull request #596:
URL: https://github.com/apache/griffin/pull/596#discussion_r785921305
##########
File path: service/pom.xml
##########
@@ -385,7 +385,6 @@ under the License.
<configuration>
<appendAssemblyId>false</appendAssemblyId>
<skipAssembly>false</skipAssembly>
- <outputDirectory>../target</outputDirectory>
Review comment:
> The service-${version}.tar.gz location is not align with the Documention in https://github.com/apache/griffin/blob/master/griffin-doc/deploy/deploy-guide.md, or we can update the documentation to remove the confuse.
>
> > > > It's easy to build Griffin, just run maven command mvn clean install. Successfully building, you can get service-${version}.tar.gz and measure-${version}.jar from target folder in **service** and **measure** module.
You're right. I think it's better to update the doc, and the following commands should also be modified at the same time.
```bash
cd $GRIFFIN_INSTALL_DIR
tar -zxvf service-${version}.tar.gz
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] chitralverma commented on a change in pull request #596: [GRIFFIN-367] For task GRIFFIN-367, update local deploy document.
Posted by GitBox <gi...@apache.org>.
chitralverma commented on a change in pull request #596:
URL: https://github.com/apache/griffin/pull/596#discussion_r786042592
##########
File path: service/pom.xml
##########
@@ -385,7 +385,6 @@ under the License.
<configuration>
<appendAssemblyId>false</appendAssemblyId>
<skipAssembly>false</skipAssembly>
- <outputDirectory>../target</outputDirectory>
Review comment:
@lipzhu please update the docs instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] lipzhu commented on a change in pull request #596: [GRIFFIN-367] For task GRIFFIN-367, update local deploy document.
Posted by GitBox <gi...@apache.org>.
lipzhu commented on a change in pull request #596:
URL: https://github.com/apache/griffin/pull/596#discussion_r785865424
##########
File path: service/pom.xml
##########
@@ -385,7 +385,6 @@ under the License.
<configuration>
<appendAssemblyId>false</appendAssemblyId>
<skipAssembly>false</skipAssembly>
- <outputDirectory>../target</outputDirectory>
Review comment:
The service-${version}.tar.gz location is not align with the Documention in https://github.com/apache/griffin/blob/master/griffin-doc/deploy/deploy-guide.md, or we can update the documentation to remove the confuse.
>>>It's easy to build Griffin, just run maven command mvn clean install. Successfully building, you can get service-${version}.tar.gz and measure-${version}.jar from target folder in **service** and **measure** module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] whhe merged pull request #596: [GRIFFIN-367] For task GRIFFIN-367, update local deploy document.
Posted by GitBox <gi...@apache.org>.
whhe merged pull request #596:
URL: https://github.com/apache/griffin/pull/596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org