You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/16 21:56:29 UTC

[GitHub] zhreshold commented on issue #12840: [MXNET-1033] Fix a bug in MultiboxTarget GPU implementation

zhreshold commented on issue #12840: [MXNET-1033] Fix a bug in MultiboxTarget GPU implementation
URL: https://github.com/apache/incubator-mxnet/pull/12840#issuecomment-430415374
 
 
   The check was there to ensure the buffer is large enough for cuda merge sort implementation. I double checked the buffer is actually from the temp space https://github.com/apache/incubator-mxnet/blob/9c78437d895e9035ef1f30e247ffd0d9b4231829/src/operator/contrib/multibox_target-inl.h#L119 that has at least (11 - 4) * batch size * num_anchor (since I am using temp_space[4] as the buffer), it is safe to remove the check IMO. 
   
   But I would like to see a test case covering this. @apeforest Could you help me verify that with a unittest?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services