You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2026/04/16 07:11:16 UTC
(skywalking-infra-e2e) branch fix/disable-ryuk-when-cleanup-never created (now 3ca8cf4)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch fix/disable-ryuk-when-cleanup-never
in repository https://gitbox.apache.org/repos/asf/skywalking-infra-e2e.git
at 3ca8cf4 fix: disable Ryuk reaper when cleanup.on is never
This branch includes the following new commits:
new 3ca8cf4 fix: disable Ryuk reaper when cleanup.on is never
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(skywalking-infra-e2e) 01/01: fix: disable Ryuk reaper when cleanup.on is never
Posted by wu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch fix/disable-ryuk-when-cleanup-never
in repository https://gitbox.apache.org/repos/asf/skywalking-infra-e2e.git
commit 3ca8cf49948a713758ec1862ab44de15bac839bf
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Thu Apr 16 15:11:02 2026 +0800
fix: disable Ryuk reaper when cleanup.on is never
After migrating to testcontainers-go, the Ryuk reaper sidecar
automatically removes all containers when the e2e process exits,
which makes cleanup.on: never ineffective in compose mode.
Co-Authored-By: Claude Opus 4.6 (1M context) <no...@anthropic.com>
---
internal/components/setup/compose.go | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/internal/components/setup/compose.go b/internal/components/setup/compose.go
index 52acd98..f43d2fd 100644
--- a/internal/components/setup/compose.go
+++ b/internal/components/setup/compose.go
@@ -32,6 +32,7 @@ import (
"gopkg.in/yaml.v2"
"github.com/apache/skywalking-infra-e2e/internal/config"
+ "github.com/apache/skywalking-infra-e2e/internal/constant"
"github.com/apache/skywalking-infra-e2e/internal/logger"
"github.com/apache/skywalking-infra-e2e/internal/util"
)
@@ -55,6 +56,13 @@ func ComposeSetup(e2eConfig *config.E2EConfig) error {
util.ExportEnvVars(profilePath)
}
+ // Disable Ryuk reaper when cleanup.on is "never" so containers survive process exit.
+ if e2eConfig.Cleanup.On == constant.CleanUpNever {
+ if err := os.Setenv("TESTCONTAINERS_RYUK_DISABLED", "true"); err != nil {
+ return fmt.Errorf("failed to disable Ryuk reaper: %v", err)
+ }
+ }
+
// create compose stack
identifier := util.GetIdentity()
stack, err := compose.NewDockerComposeWith(