You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2021/03/23 17:42:04 UTC
[kudu-CR] KUDU-2612: allow ABORT TXN or FINALIZE COMMIT when transaction hasn't been started
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17217
Change subject: KUDU-2612: allow ABORT_TXN or FINALIZE_COMMIT when transaction hasn't been started
......................................................................
KUDU-2612: allow ABORT_TXN or FINALIZE_COMMIT when transaction hasn't been started
This patch makes allows ABORT_TXN to proceed even if the participant
hasn't yet replicated a BEGIN_TXN op.
The primary motivator for this is the following case:
- A write request is served by participant P1 of transaction T1.
- P1's TxnOpDispatcher successfully makes the RegisterParticipant call
for T1.
- P1 fails to replicate its BEGIN_TXN op for T1.
- The write request times out (no further retries happen).
- T1 is aborted, and ABORT_TXN ops are sent to all registered
participants, including P1.
- Since the BEGIN_TXN op wasn't successul on P1, its ABORT_TXN op is
also unsuccessful, causing the abort task to halt.
Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
---
M src/kudu/client/batcher.cc
M src/kudu/integration-tests/txn_write_ops-itest.cc
M src/kudu/tablet/lock_manager.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/tablet/txn_participant.h
M src/kudu/transactions/txn_status_manager.cc
9 files changed, 40 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/17217/1
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] KUDU-2612: route txn op dispatching errors to write ops
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17217 )
Change subject: KUDU-2612: route txn op dispatching errors to write ops
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 03 Apr 2021 03:10:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612: route txn op dispatching errors to write ops
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17217 )
Change subject: KUDU-2612: route txn op dispatching errors to write ops
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17217/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17217/1//COMMIT_MSG@9
PS1, Line 9: patch routes bad statuses fr
> nit: "patch makes allows ABORT_TXN"
Removed/reworded entirely
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 25 Mar 2021 21:54:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2612: allow ABORT TXN or FINALIZE COMMIT when transaction hasn't been started
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17217 )
Change subject: KUDU-2612: allow ABORT_TXN or FINALIZE_COMMIT when transaction hasn't been started
......................................................................
Patch Set 1:
(1 comment)
There are some failed tests in ASAN build. Looks a bit suspicious.
http://gerrit.cloudera.org:8080/#/c/17217/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17217/1//COMMIT_MSG@9
PS1, Line 9: patch makes allows ABORT_TXN
nit: "patch makes allows ABORT_TXN"
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Mar 2021 04:49:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2612: route txn op dispatching errors to write ops
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17217 )
Change subject: KUDU-2612: route txn op dispatching errors to write ops
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
LGMT, just one tiny code-style nit.
http://gerrit.cloudera.org:8080/#/c/17217/1/src/kudu/integration-tests/txn_write_ops-itest.cc
File src/kudu/integration-tests/txn_write_ops-itest.cc:
http://gerrit.cloudera.org:8080/#/c/17217/1/src/kudu/integration-tests/txn_write_ops-itest.cc@662
PS1, Line 662: TEST_F(TxnWriteOpsITest, TxnWriteAfterCommit) {
Thank you for fixing the underlying issues and enabling this scenario!
http://gerrit.cloudera.org:8080/#/c/17217/3/src/kudu/tablet/tablet_metadata.cc
File src/kudu/tablet/tablet_metadata.cc:
http://gerrit.cloudera.org:8080/#/c/17217/3/src/kudu/tablet/tablet_metadata.cc@841
PS3, Line 841: scoped_refptr<TxnMetadata>(
nit: since that's emplace semantics, is it possible to drop this piece?
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 31 Mar 2021 01:13:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2612: route txn op dispatching errors to write ops
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17217 )
Change subject: KUDU-2612: route txn op dispatching errors to write ops
......................................................................
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17217/5/src/kudu/client/batcher.cc
File src/kudu/client/batcher.cc:
http://gerrit.cloudera.org:8080/#/c/17217/5/src/kudu/client/batcher.cc@509
PS5, Line 509: if (resp_.has_error() &&
> nit: The 'code' isn't used anywhere in the code below except for this 'if (
Done
http://gerrit.cloudera.org:8080/#/c/17217/5/src/kudu/tablet/tablet_metadata.cc
File src/kudu/tablet/tablet_metadata.cc:
http://gerrit.cloudera.org:8080/#/c/17217/5/src/kudu/tablet/tablet_metadata.cc@839
PS5, Line 839: txn_metadata->set_commit_timestamp(commit_timestamp);
> nit: why not just FindOrDie() given there is CHECK(txn_metadata) below?
Done
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 03 Apr 2021 02:18:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2612: allow ABORT TXN or FINALIZE COMMIT when transaction hasn't been started
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17217 )
Change subject: KUDU-2612: allow ABORT_TXN or FINALIZE_COMMIT when transaction hasn't been started
......................................................................
Patch Set 1:
Oops, didn't mean to push this yet.
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Mar 2021 17:50:16 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612: route txn op dispatching errors to write ops
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17217 )
Change subject: KUDU-2612: route txn op dispatching errors to write ops
......................................................................
Patch Set 5: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/17217/5/src/kudu/client/batcher.cc
File src/kudu/client/batcher.cc:
http://gerrit.cloudera.org:8080/#/c/17217/5/src/kudu/client/batcher.cc@509
PS5, Line 509: const auto& code = resp_.error().code();
nit: The 'code' isn't used anywhere in the code below except for this 'if ()' condition, right? Also, I guess it's natural to gate the access to the 'error().code()' by 'has_error()', so why is this change then?
http://gerrit.cloudera.org:8080/#/c/17217/3/src/kudu/tablet/tablet_metadata.cc
File src/kudu/tablet/tablet_metadata.cc:
http://gerrit.cloudera.org:8080/#/c/17217/3/src/kudu/tablet/tablet_metadata.cc@841
PS3, Line 841: ommit_timestamp);
> Seems like we can't, based on the ASAN errors in https://gerrit.cloudera.or
Ah, makes sense. Thanks!
http://gerrit.cloudera.org:8080/#/c/17217/5/src/kudu/tablet/tablet_metadata.cc
File src/kudu/tablet/tablet_metadata.cc:
http://gerrit.cloudera.org:8080/#/c/17217/5/src/kudu/tablet/tablet_metadata.cc@839
PS5, Line 839: auto txn_metadata = FindPtrOrNull(txn_metadata_by_txn_id_, txn_id);
nit: why not just FindOrDie() given there is CHECK(txn_metadata) below?
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 03 Apr 2021 00:10:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2612: route txn op dispatching errors to write ops
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17217
to look at the new patch set (#2).
Change subject: KUDU-2612: route txn op dispatching errors to write ops
......................................................................
KUDU-2612: route txn op dispatching errors to write ops
This patch routes bad statuses from the TxnOpDispatcher to the write ops
that initiated the registration, and adjusts the batcher code to handle
such errors.
This also enables a couple of test cases that were written with this
behavior in mind; and adjusts some expected errors, addressing some
TODOs that expected this behavior.
A follow-up patch will make a similar change to the Java client.
Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
---
M src/kudu/client/batcher.cc
M src/kudu/integration-tests/txn_write_ops-itest.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
8 files changed, 89 insertions(+), 87 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/17217/2
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612: route txn op dispatching errors to write ops
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17217
to look at the new patch set (#4).
Change subject: KUDU-2612: route txn op dispatching errors to write ops
......................................................................
KUDU-2612: route txn op dispatching errors to write ops
This patch routes bad statuses from the TxnOpDispatcher to the write ops
that initiated the registration, and adjusts the batcher code to handle
such errors.
This also enables a couple of test cases that were written with this
behavior in mind; and adjusts some expected errors, addressing some
TODOs that expected this behavior.
A follow-up patch will make a similar change to the Java client.
Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
---
M src/kudu/client/batcher.cc
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/integration-tests/txn_write_ops-itest.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
9 files changed, 93 insertions(+), 92 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/17217/4
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2612: route txn op dispatching errors to write ops
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17217
to look at the new patch set (#6).
Change subject: KUDU-2612: route txn op dispatching errors to write ops
......................................................................
KUDU-2612: route txn op dispatching errors to write ops
This patch routes bad statuses from the TxnOpDispatcher to the write ops
that initiated the registration, and adjusts the batcher code to handle
such errors.
This also enables a couple of test cases that were written with this
behavior in mind; and adjusts some expected errors, addressing some
TODOs that expected this behavior.
A follow-up patch will make a similar change to the Java client.
Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
---
M src/kudu/client/batcher.cc
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/integration-tests/txn_write_ops-itest.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
10 files changed, 94 insertions(+), 96 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/17217/6
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2612: route txn op dispatching errors to write ops
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: KUDU-2612: route txn op dispatching errors to write ops
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2612: route txn op dispatching errors to write ops
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17217 )
Change subject: KUDU-2612: route txn op dispatching errors to write ops
......................................................................
KUDU-2612: route txn op dispatching errors to write ops
This patch routes bad statuses from the TxnOpDispatcher to the write ops
that initiated the registration, and adjusts the batcher code to handle
such errors.
This also enables a couple of test cases that were written with this
behavior in mind; and adjusts some expected errors, addressing some
TODOs that expected this behavior.
A follow-up patch will make a similar change to the Java client.
Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Reviewed-on: http://gerrit.cloudera.org:8080/17217
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/batcher.cc
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/integration-tests/txn_write_ops-itest.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
10 files changed, 94 insertions(+), 96 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2612: route txn op dispatching errors to write ops
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17217 )
Change subject: KUDU-2612: route txn op dispatching errors to write ops
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17217/1/src/kudu/integration-tests/txn_write_ops-itest.cc
File src/kudu/integration-tests/txn_write_ops-itest.cc:
http://gerrit.cloudera.org:8080/#/c/17217/1/src/kudu/integration-tests/txn_write_ops-itest.cc@662
PS1, Line 662: TEST_F(TxnWriteOpsITest, TxnWriteAfterCommit) {
> Thank you for fixing the underlying issues and enabling this scenario!
Definitely. Thanks for authoring it!
http://gerrit.cloudera.org:8080/#/c/17217/3/src/kudu/tablet/tablet_metadata.cc
File src/kudu/tablet/tablet_metadata.cc:
http://gerrit.cloudera.org:8080/#/c/17217/3/src/kudu/tablet/tablet_metadata.cc@841
PS3, Line 841: ommit_timestamp);
> nit: since that's emplace semantics, is it possible to drop this piece?
Seems like we can't, based on the ASAN errors in https://gerrit.cloudera.org/c/17233/1 that this is based on top of. I left a comment in that patch.
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 31 Mar 2021 05:39:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2612: route txn op dispatching errors to write ops
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17217
to look at the new patch set (#3).
Change subject: KUDU-2612: route txn op dispatching errors to write ops
......................................................................
KUDU-2612: route txn op dispatching errors to write ops
This patch routes bad statuses from the TxnOpDispatcher to the write ops
that initiated the registration, and adjusts the batcher code to handle
such errors.
This also enables a couple of test cases that were written with this
behavior in mind; and adjusts some expected errors, addressing some
TODOs that expected this behavior.
A follow-up patch will make a similar change to the Java client.
Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
---
M src/kudu/client/batcher.cc
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/integration-tests/txn_write_ops-itest.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
10 files changed, 96 insertions(+), 94 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/17217/3
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2612: route txn op dispatching errors to write ops
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17217 )
Change subject: KUDU-2612: route txn op dispatching errors to write ops
......................................................................
Patch Set 3: Verified+1
The test failure doesn't look related, but I'm looking into it because I haven't seen it before.
--
To view, visit http://gerrit.cloudera.org:8080/17217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935
Gerrit-Change-Number: 17217
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 25 Mar 2021 21:54:58 +0000
Gerrit-HasComments: No