[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17870: [improve][broker] Use separate IO event loop group for internal client.

[GitBox <gi...@apache.org>]

mattisonchao commented on code in PR #17870:
URL: https://github.com/apache/pulsar/pull/17870#discussion_r982365151


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -332,6 +334,10 @@ public PulsarService(ServiceConfiguration config,
 
         this.ioEventLoopGroup = EventLoopUtil.newEventLoopGroup(config.getNumIOThreads(), config.isEnableBusyWait(),
                 new DefaultThreadFactory("pulsar-io"));
+        // A shared io event group for broker clients to avoid internal clients from occupying IO
+        // threads for a long time and affecting the throughput of the broker.
+        this.brokerClientSharedIoEventLoopGroup = EventLoopUtil.newEventLoopGroup(config.getNumIOThreads(),

Review Comment:
   `config.getNumIOThreads()` 
   If we consider using the different values for the internal clients, we can introduce the new config in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org