Re: [PR] chore: forbide `with_default_features` override existing information [datafusion]

["irenjj (via GitHub)" <gi...@apache.org>]

irenjj commented on code in PR #14935:
URL: https://github.com/apache/datafusion/pull/14935#discussion_r1976239466


##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -1081,6 +1081,8 @@ impl SessionStateBuilder {
 
     /// Create default builder with defaults for table_factories, file formats, expr_planners and builtin
     /// scalar, aggregate and windows functions.
+    /// For each setter method call, default values will only be created and set if the corresponding
+    /// field is currently None, otherwise the existing value will be preserved.
     pub fn with_default_features(self) -> Self {

Review Comment:
   Thanks for the suggestion. I think the second approach is more suitable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org