[GitHub] [helix] narendly commented on a change in pull request #514: The WAGED rebalancer returns the previously calculated assignment on calculation failure

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #514: The WAGED rebalancer returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r335820180
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/monitoring/metrics/model/Metric.java
 ##########
 @@ -31,11 +31,6 @@
    */
   String getMetricName();
 
-  /**
-   * Resets the internal state of this metric.
-   */
-  void reset();
 
 Review comment:
   Should we keep this interface here to preserve the generality of the reset method? There could be other Metrics in addition to CountMetric and LatencyMetric that might benefit from reset() method.
   
   But this is a might-be, so we could keep this and perhaps move it back to the interface when we actually need it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org