You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/13 16:01:20 UTC
[GitHub] [camel-quarkus] zbendhiba opened a new pull request #3383: ⬆️ Use the Quarkus Artemis BOM and upgrade to 1.0.2
zbendhiba opened a new pull request #3383:
URL: https://github.com/apache/camel-quarkus/pull/3383
Fixes #3381
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #3383: ⬆️ Use the Quarkus Artemis BOM and upgrade to 1.0.2
Posted by GitBox <gi...@apache.org>.
aldettinger merged pull request #3383:
URL: https://github.com/apache/camel-quarkus/pull/3383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3383: ⬆️ Use the Quarkus Artemis BOM and upgrade to 1.0.2
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #3383:
URL: https://github.com/apache/camel-quarkus/pull/3383#discussion_r767902532
##########
File path: poms/bom-test/pom.xml
##########
@@ -54,6 +54,13 @@
<type>pom</type>
<scope>import</scope>
</dependency>
+ <dependency>
+ <groupId>io.quarkiverse.artemis</groupId>
+ <artifactId>quarkus-artemis-bom</artifactId>
Review comment:
I was not able to find this in a maven repo. Could you please provide a link to have a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3383: ⬆️ Use the Quarkus Artemis BOM and upgrade to 1.0.2
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3383:
URL: https://github.com/apache/camel-quarkus/pull/3383#issuecomment-992654169
> https://repository.jboss.org used to be flaky in the past. The CI failure is most probably unrelated.
>
> > transfer failed for [https://repository.jboss.org/nexus/service/local/repositories/thirdparty-releases/content/io/nessus/nessus-ipfs-client/1.0.0.Beta4/nessus-ipfs-client-1.0.0.Beta4.pom`](https://repository.jboss.org/nexus/service/local/repositories/thirdparty-releases/content/io/nessus/nessus-ipfs-client/1.0.0.Beta4/nessus-ipfs-client-1.0.0.Beta4.pom%60)
I agree, we are suffering the same kind of issue in another non related PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] oscerd commented on pull request #3383: ⬆️ Use the Quarkus Artemis BOM and upgrade to 1.0.2
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #3383:
URL: https://github.com/apache/camel-quarkus/pull/3383#issuecomment-992646629
Mvnrepository is not synched with the same timing of maven central. The source of Truth is always maven central
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3383: ⬆️ Use the Quarkus Artemis BOM and upgrade to 1.0.2
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #3383:
URL: https://github.com/apache/camel-quarkus/pull/3383#discussion_r767902002
##########
File path: pom.xml
##########
@@ -49,7 +49,7 @@
<debezium.version>1.6.1.Final</debezium.version><!-- May go back to Camel's ${debezium-version} when they are in sync https://repo1.maven.org/maven2/io/debezium/debezium-bom/ -->
<optaplanner.version>8.9.1.Final</optaplanner.version><!-- May go back to Camel's ${optaplanner-version} when they are in sync https://repo1.maven.org/maven2/org/optaplanner/optaplanner-quarkus/ -->
<quarkiverse-amazonservices.version>1.0.0</quarkiverse-amazonservices.version><!-- https://repo1.maven.org/maven2/io/quarkiverse/amazonservices/quarkus-amazon-services-parent/ -->
- <quarkiverse-artemis.version>1.0.1</quarkiverse-artemis.version><!-- https://repo1.maven.org/maven2/io/quarkiverse/artemis/quarkus-artemis-parent/ -->
+ <quarkiverse-artemis.version>1.0.2</quarkiverse-artemis.version><!-- https://repo1.maven.org/maven2/io/quarkiverse/artemis/quarkus-artemis-parent/ -->
Review comment:
The comment here refers to quarkus-artemis-parent. Are we using it anymore ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a change in pull request #3383: ⬆️ Use the Quarkus Artemis BOM and upgrade to 1.0.2
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on a change in pull request #3383:
URL: https://github.com/apache/camel-quarkus/pull/3383#discussion_r767908019
##########
File path: poms/bom-test/pom.xml
##########
@@ -54,6 +54,13 @@
<type>pom</type>
<scope>import</scope>
</dependency>
+ <dependency>
+ <groupId>io.quarkiverse.artemis</groupId>
+ <artifactId>quarkus-artemis-bom</artifactId>
Review comment:
Oh wait, why did worked for me ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a change in pull request #3383: ⬆️ Use the Quarkus Artemis BOM and upgrade to 1.0.2
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on a change in pull request #3383:
URL: https://github.com/apache/camel-quarkus/pull/3383#discussion_r767921662
##########
File path: pom.xml
##########
@@ -49,7 +49,7 @@
<debezium.version>1.6.1.Final</debezium.version><!-- May go back to Camel's ${debezium-version} when they are in sync https://repo1.maven.org/maven2/io/debezium/debezium-bom/ -->
<optaplanner.version>8.9.1.Final</optaplanner.version><!-- May go back to Camel's ${optaplanner-version} when they are in sync https://repo1.maven.org/maven2/org/optaplanner/optaplanner-quarkus/ -->
<quarkiverse-amazonservices.version>1.0.0</quarkiverse-amazonservices.version><!-- https://repo1.maven.org/maven2/io/quarkiverse/amazonservices/quarkus-amazon-services-parent/ -->
- <quarkiverse-artemis.version>1.0.1</quarkiverse-artemis.version><!-- https://repo1.maven.org/maven2/io/quarkiverse/artemis/quarkus-artemis-parent/ -->
+ <quarkiverse-artemis.version>1.0.2</quarkiverse-artemis.version><!-- https://repo1.maven.org/maven2/io/quarkiverse/artemis/quarkus-artemis-parent/ -->
Review comment:
Maybe rename it to quarkus artemis. I'll push later the fix. Waiting for the nexus and artifacts to be available.
The Artemis parent, includes now the quarkus bom and quarkus-artemis-bom. We don't refer to it in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a change in pull request #3383: ⬆️ Use the Quarkus Artemis BOM and upgrade to 1.0.2
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on a change in pull request #3383:
URL: https://github.com/apache/camel-quarkus/pull/3383#discussion_r767913668
##########
File path: poms/bom-test/pom.xml
##########
@@ -54,6 +54,13 @@
<type>pom</type>
<scope>import</scope>
</dependency>
+ <dependency>
+ <groupId>io.quarkiverse.artemis</groupId>
+ <artifactId>quarkus-artemis-bom</artifactId>
Review comment:
I don't know why it doesn't show yet on website. Maybe it's just a matter of time. It has been released 2 hours ago. I've uploaded the artifacts locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3383: ⬆️ Use the Quarkus Artemis BOM and upgrade to 1.0.2
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #3383:
URL: https://github.com/apache/camel-quarkus/pull/3383#discussion_r767923271
##########
File path: poms/bom-test/pom.xml
##########
@@ -54,6 +54,13 @@
<type>pom</type>
<scope>import</scope>
</dependency>
+ <dependency>
+ <groupId>io.quarkiverse.artemis</groupId>
+ <artifactId>quarkus-artemis-bom</artifactId>
Review comment:
ok, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3383: ⬆️ Use the Quarkus Artemis BOM and upgrade to 1.0.2
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #3383:
URL: https://github.com/apache/camel-quarkus/pull/3383#discussion_r767910738
##########
File path: poms/bom-test/pom.xml
##########
@@ -54,6 +54,13 @@
<type>pom</type>
<scope>import</scope>
</dependency>
+ <dependency>
+ <groupId>io.quarkiverse.artemis</groupId>
+ <artifactId>quarkus-artemis-bom</artifactId>
Review comment:
I did not try to build @zbendhiba . I was just looking for the pom on sites like https://mvnrepository.com/search?q=quarkus-artemis-bom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #3383: ⬆️ Use the Quarkus Artemis BOM and upgrade to 1.0.2
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #3383:
URL: https://github.com/apache/camel-quarkus/pull/3383#discussion_r767917242
##########
File path: poms/bom-test/pom.xml
##########
@@ -54,6 +54,13 @@
<type>pom</type>
<scope>import</scope>
</dependency>
+ <dependency>
+ <groupId>io.quarkiverse.artemis</groupId>
+ <artifactId>quarkus-artemis-bom</artifactId>
Review comment:
https://mvnrepository.com is a bit delayed. It is there in the Central https://repo1.maven.org/maven2/io/quarkiverse/artemis/quarkus-artemis-bom/1.0.2/quarkus-artemis-bom-1.0.2.pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org