You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "mikeal (JIRA)" <ji...@apache.org> on 2010/08/18 20:57:16 UTC

[jira] Created: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

GET /db/_design/doc/_info should not trigger an update
------------------------------------------------------

                 Key: COUCHDB-858
                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
             Project: CouchDB
          Issue Type: Bug
         Environment: All
            Reporter: mikeal


Ran across this in my futon rewrite.

A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 

This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900020#action_12900020 ] 

Adam Kocoloski commented on COUCHDB-858:
----------------------------------------

Thanks, that patch is exactly what I was proposing.

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Don-t-trigger-a-view-update-when-sending-a-GET.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920261#action_12920261 ] 

Paul Joseph Davis commented on COUCHDB-858:
-------------------------------------------

Klaus,

Can you add a test to see if this fixes COUCHDB-821 as well?

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-858:
----------------------------------

    Attachment:     (was: 0001-Fixes-COUCHDB-858.patch)

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-858:
----------------------------------

    Attachment: 0001-Fixes-COUCHDB-858.patch

Sorry. The previous patch wouldn't apply to current trunk. 

There's no change to the actual code, however.

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-858:
----------------------------------

    Attachment:     (was: 0001-Don-t-trigger-a-view-update-when-sending-a-GET.patch)

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899979#action_12899979 ] 

Adam Kocoloski commented on COUCHDB-858:
----------------------------------------

Other way around, an update is only triggered when the group is _not_ already open.

I think we should not fire off an update when initializing a group.  That's a very simple change, and addresses this ticket.  But perhaps users would prefer the same freshness options for _info that are available for _view.

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-858:
----------------------------------

    Attachment: 0001-Fixes-COUCHDB-858.patch

I've attached an updated version of the patch that also includes a test that checks whether COUCHDB-821 is fixed.

However, COUCHDB-821 doesn't seem to be related to this issue. COUCHDB-821 is rather related to COUCHDB-799, which is already fixed in trunk, though.

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-858:
----------------------------------

    Attachment:     (was: 0001-Fixes-COUCHDB-858.patch)

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-858:
----------------------------------

    Attachment:     (was: 0001-Fixes-COUCHDB-858.patch)

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924585#action_12924585 ] 

Filipe Manana commented on COUCHDB-858:
---------------------------------------

Hi Klaus,

The patch looks very good to me. Just 2 remarks:

1) avoid changing unnecessarily (white space only) the following line:

_id:"_design/test", // turn off couch.js id escaping?


2) In the test, avoid using an hardcoded Etag value. Just store the previous and current values and then compare them in the assertion

3) Don't forget the semicollons at the end of all your JavaScript lines (aparently some browsers are picky about it).

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-858:
----------------------------------

    Attachment: 0001-Fixes-COUCHDB-858.patch

Hi Filipe,
thanks for your review.

I've updated the patch.

Regarding your remarks:
1) Sure.
2) Actually it was hardcoded before and I didn't change that. Anyway, now it isn't hardcoded anymore.
3) I've spotted three other lines where there should be semicolons (at least for the sake of consistency). Now fixed that as well.

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-858:
----------------------------------

    Attachment: 0001-Fixes-COUCHDB-858.patch

Thanks again.
I had a messed up build configuration so that my changes to the source weren't reflected in what I was running.

The patch is updated.

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-858:
----------------------------------

    Attachment: 0001-Fixes-COUCHDB-858.patch

There was a typo. Sorry.

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-858:
----------------------------------

    Attachment:     (was: 0001-Fixes-COUCHDB-858.patch)

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-858:
----------------------------------

    Attachment: 0001-Fixes-COUCHDB-858.patch

Attached is an updated version of the previous patch. It adds corresponding test cases to the design_docs test suite.

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-858:
----------------------------------

    Attachment: 0001-Don-t-trigger-a-view-update-when-sending-a-GET.patch

Here the relevant piece from the IRC log:

kocolosk: i believe all one needs to do is remove the spawn_link couch_view_updater:update line from couch_view_group:init

I just wanted to see if kocolosk was right, and yes he was :)

The attached patch makes sure that a GET request to /db/_design/doc/_info never triggers an update of the view group.

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Don-t-trigger-a-view-update-when-sending-a-GET.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Joseph Davis updated COUCHDB-858:
--------------------------------------

    Skill Level: Regular Contributors Level (Easy to Medium)

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Don-t-trigger-a-view-update-when-sending-a-GET.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Filipe Manana resolved COUCHDB-858.
-----------------------------------

    Resolution: Fixed

Committed to trunk (revision 1027215)

Thanks Klaus.

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Klaus Trainer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Trainer updated COUCHDB-858:
----------------------------------

    Attachment:     (was: 0001-Fixes-COUCHDB-858.patch)

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COUCHDB-858) GET /db/_design/doc/_info should not trigger an update

Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924622#action_12924622 ] 

Filipe Manana commented on COUCHDB-858:
---------------------------------------

Thanks Klaus.
With your latest patch, the test doesn't pass. The following modifications make it pass:

diff --git a/share/www/script/test/design_docs.js b/share/www/script/test/design_docs.js
index f799212..a453be4 100644
--- a/share/www/script/test/design_docs.js
+++ b/share/www/script/test/design_docs.js
@@ -103,7 +103,8 @@ function() {
   var xhr = CouchDB.request("GET", "/test_suite_db/_design/test/_show/circular");
   T(xhr.status == 200);
   TEquals("javascript", JSON.parse(xhr.responseText).language);
-  var etag = xhr.getResponseHeader("etag");
+
+  var prev_view_sig = db.designInfo("_design/test").view_index.signature;
 
   db.bulkSave(makeDocs(1, numDocs + 1));
 
@@ -115,7 +116,7 @@ function() {
   TEquals(false, vinfo.compact_running);
   // test that GET /db/_design/test/_info
   // hasn't triggered an update of the views
-  TEquals(etag, vinfo.signature, 'ddoc sig');
+  TEquals(prev_view_sig, vinfo.signature, 'ddoc sig');
   for (var loop = 0; loop < 2; loop++) {
     T(db.view("test/all_docs_twice", {stale: "ok"}).total_rows == 0);
     T(db.view("test/single_doc", {stale: "ok"}).total_rows == 0);


Do you agree with them?
(you were comparing the etag of _show output with the signature (etag) of the view group)

> GET /db/_design/doc/_info should not trigger an update
> ------------------------------------------------------
>
>                 Key: COUCHDB-858
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-858
>             Project: CouchDB
>          Issue Type: Bug
>         Environment: All
>            Reporter: mikeal
>         Attachments: 0001-Fixes-COUCHDB-858.patch
>
>
> Ran across this in my futon rewrite.
> A call to the info for a ddoc triggers an update in some cases. koco says it's when that "group is open". 
> This request needs to either not trigger an update or respect stale=ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.