[GitHub] [lucene] kaivalnp commented on a diff in pull request #1054: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

[GitBox <gi...@apache.org>]

kaivalnp commented on code in PR #1054:
URL: https://github.com/apache/lucene/pull/1054#discussion_r939698986


##########
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##########
@@ -248,7 +269,9 @@ private void run(String... args) throws Exception {
           if (docVectorsPath == null) {
             throw new IllegalArgumentException("missing -docs arg");
           }
-          matchDocs = generateRandomBitSet(numDocs, selectivity);
+          if (prefilter) {

Review Comment:
   This `matchDocs` should be created even for post-filtered search, because it is used in `computeNN` to check which docs are filtered during brute-force search



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org