You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhan Reddy <mr...@gmail.com> on 2017/03/08 10:14:37 UTC
Review Request 57414: AMBARI-20337. Need to show timer while loading
coordinator name while bundle creation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57414/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
Bugs: AMBARI-20337
https://issues.apache.org/jira/browse/AMBARI-20337
Repository: ambari
Description
-------
Added the loading icon while fetching the coordinator name. And also showing the error message if any exception occurs.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-coord-config.js 2280f82
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 2d374a5
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs 56cacd6
Diff: https://reviews.apache.org/r/57414/diff/1/
Testing
-------
Manual
Thanks,
Madhan Reddy
Re: Review Request 57414: AMBARI-20337. Need to show timer while
loading coordinator name while bundle creation
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57414/#review168267
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On March 8, 2017, 10:14 a.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57414/
> -----------------------------------------------------------
>
> (Updated March 8, 2017, 10:14 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20337
> https://issues.apache.org/jira/browse/AMBARI-20337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added the loading icon while fetching the coordinator name. And also showing the error message if any exception occurs.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-coord-config.js 2280f82
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 2d374a5
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs 56cacd6
>
>
> Diff: https://reviews.apache.org/r/57414/diff/1/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Madhan Reddy
>
>
Re: Review Request 57414: AMBARI-20337. Need to show timer while
loading coordinator name while bundle creation
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57414/#review168266
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On March 8, 2017, 10:14 a.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57414/
> -----------------------------------------------------------
>
> (Updated March 8, 2017, 10:14 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20337
> https://issues.apache.org/jira/browse/AMBARI-20337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added the loading icon while fetching the coordinator name. And also showing the error message if any exception occurs.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-coord-config.js 2280f82
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 2d374a5
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs 56cacd6
>
>
> Diff: https://reviews.apache.org/r/57414/diff/1/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Madhan Reddy
>
>