[GitHub] [doris] weizhengte commented on a diff in pull request #18653: [Optimization](statistics) optimize the problem of slow deletion of statistics .

["weizhengte (via GitHub)" <gi...@apache.org>]

weizhengte commented on code in PR #18653:
URL: https://github.com/apache/doris/pull/18653#discussion_r1167808271


##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsRepository.java:
##########
@@ -179,15 +205,7 @@ private static void dropStatistics(Long dbId,
 
         Map<String, String> params = new HashMap<>();
         params.put("condition", predicate.toString());
-        StringSubstitutor stringSubstitutor = new StringSubstitutor(params);
-
-        try {
-            String statement = isHistogram ? stringSubstitutor.replace(DROP_TABLE_HISTOGRAM_TEMPLATE) :
-                    stringSubstitutor.replace(DROP_TABLE_STATISTICS_TEMPLATE);
-            StatisticsUtil.execUpdate(statement);
-        } catch (Exception e) {
-            LOG.warn("Drop statistics failed", e);
-        }
+        return params;
     }
 
     private static <T> void buildPredicate(String fieldName, Set<T> fieldValues, StringBuilder predicate) {

Review Comment:
   fieldValues could be Set<Long> tblIds, or Set<String> colNames... all converted in this method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org