[GitHub] [hudi] yihua commented on a diff in pull request #8125: [HUDI-5900] Clean up unused metadata configs

["yihua (via GitHub)" <gi...@apache.org>]

yihua commented on code in PR #8125:
URL: https://github.com/apache/hudi/pull/8125#discussion_r1133440107


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java:
##########
@@ -556,23 +554,10 @@ public void testUpdationOfPopulateMetaFieldsForMetadataTable() throws Exception
     tableType = COPY_ON_WRITE;
     init(tableType, false);
 
+    // populateMeta fields is false by default
     writeConfig = getWriteConfigBuilder(true, true, false)
         .withMetadataConfig(HoodieMetadataConfig.newBuilder()
             .enable(true)
-            .withPopulateMetaFields(true)
-            .build())
-        .build();
-    initWriteConfigAndMetatableWriter(writeConfig, true);
-    doWriteOperation(testTable, "0000001", INSERT);

Review Comment:
   We still need this to write the first batch?  If not, change the latter commit time `"0000002"` to `"0000001"`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org