You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/22 14:45:52 UTC

[GitHub] [arrow] sjperkins commented on a change in pull request #10565: ARROW-638: [C++] Complex Number Support via ExtensionTypes

sjperkins commented on a change in pull request #10565:
URL: https://github.com/apache/arrow/pull/10565#discussion_r773941345



##########
File path: cpp/src/arrow/python/type_traits.h
##########
@@ -334,6 +377,10 @@ static inline int NumPyTypeSize(int npy_type) {
       return 4;
     case NPY_FLOAT64:
       return 8;
+    case NPY_COMPLEX64:
+      return 16;
+    case NPY_COMPLEX128:
+      return 32;

Review comment:
       Indeed, thanks for catching this, fixed in  https://github.com/apache/arrow/pull/10565/commits/e31d556b03f5a8eae31df9a954e9dca8a0f27f14




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org